similar to: [PATCH] Add MD devices to guestfish device autocompletion

On filesystems whose dirent.d_type is DT_UNKNOWN or some unknown value, manually check whether an entry is a directory, thus completing in the proper way. --- fish/destpaths.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fish/destpaths.c b/fish/destpaths.c index f224106..df1ec00 100644 --- a/fish/destpaths.c +++ b/fish/destpaths.c @@ -191,7 +191,13 @@

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

The test is fine, but it should come after the fix in the list of commits, otherwise you break git bisection. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and

2018-01-23 12:11 GMT+02:00 Richard W.M. Jones <rjones@redhat.com>: > The test is fine, but it should come after the fix in the list of > commits, otherwise you break git bisection. Got it. Is there tests naming convention? Is it OK to call it test-partitioned-md-devices.sh (for example)? -- Mykola Ivanets

Test guestfish list-filesystems command finds file system on partitioned md device and does't take into account md device itself (similar to as physical devices are skipped if they are partitioned) --- tests/md/Makefile.am | 1 + tests/md/test-list-filesystems2.sh | 79 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 80 insertions(+) create mode 100755

The series below makes changes like these mechanically, one class of change per change-set: strcmp(...) == 0 to STREQ(...) strcmp(...) != 0 to STRNEQ(...) strncmp(...) == 0 to STREQLEN(...) strncmp(...) != 0 to STRNEQLEN(...) strcasecmp(...) == 0 to STRCASEEQ(...) strcasecmp(...) != 0 to STRCASENEQ(...) strncasecmp(...) == 0 to STRCASEEQLEN(...)

When an entry is a symlink, check whether it points to a directory, so the entry for it can be completed correctly. --- fish/destpaths.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fish/destpaths.c b/fish/destpaths.c index df1ec00..d39d6c0 100644 --- a/fish/destpaths.c +++ b/fish/destpaths.c @@ -192,6 +192,7 @@ complete_dest_paths_generator (const char *text, int state)

On Fri, Oct 31, 2014 at 05:56:10PM +0100, Pino Toscano wrote: > On filesystems whose dirent.d_type is DT_UNKNOWN or some unknown value, > manually check whether an entry is a directory, thus completing in the > proper way. Happens on Windows (NTFS) too, and it's also annoying there ... > --- > fish/destpaths.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-)

When you open a LUKS device, you have to associate it with a "raw" device mapper device (eg. /dev/mapper/lukstest). Previously there has been no way through the API to list such devices after they have been created. Also they are not revealed when you tab-complete /dev paths in guestfish. These two patches fix this. The first patch adds a new API called guestfs_list_dm_devices which

Only change from previous post is explicitly checking md_map for NULL before hash_free and lookup.

These patches are rebased on top of current master. In addition, I've made the following changes: * Fixed whitespace error. * Functions return -1 on error. * Added a debug message when guest contains md devices, but nothing was parsed from mdadm.conf.

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

This series fixes inspection in the case that fstab contains references to md devices. I've made a few changes since the previous posting, which I've summarised below. [PATCH 1/8] build: Create an MD variant of the dummy Fedora image I've double checked that no timestamp is required in the Makefile. The script will not run a second time to build fedora-md2.img. [PATCH 2/8] build:

This adds the mdadm-create API for creating RAID devices, and includes various fixes for the other two patches. Rich.

From: Pino Toscano <ptoscano@redhat.com> If the device name ends with a number, Linux uses partition names of the form <device>p<N>. Handle this case by knocking off the 'p' character. --- daemon/devsparts.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/daemon/devsparts.c b/daemon/devsparts.c index 5862ae2..b764f63 100644 --- a/daemon/devsparts.c +++

Original version linked from here: https://bugzilla.redhat.com/show_bug.cgi?id=1808977#c8 There is no change in the code in this series, but feedback from the original series was we shouldn't lose the error message in patch 7. When I tested this just now in fact we don't lose the error if debugging is enabled, but I have updated the commit message to note what the error message is in the

These commits, along with the associated changes to common: https://www.redhat.com/archives/libguestfs/2020-March/msg00286.html support the transparent decryption and inspection of Windows guests encrypted with BitLocker encryption. To do the BitLocker decryption requires cryptsetup 2.3.0 (although cryptsetup 2.3 is not required for existing LUKS use). It also requires a new-ish Linux kernel, I

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.