Richard W.M. Jones
2018-Jan-23 10:11 UTC
Re: [Libguestfs] [RFC PATCH v1 1/3] tests: md: Test guestfish list-filesystems command skipps partitioned md devices
The test is fine, but it should come after the fix in the list of commits, otherwise you break git bisection. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Nikolay Ivanets
2018-Jan-23 11:45 UTC
Re: [Libguestfs] [RFC PATCH v1 1/3] tests: md: Test guestfish list-filesystems command skipps partitioned md devices
2018-01-23 12:11 GMT+02:00 Richard W.M. Jones <rjones@redhat.com>:> The test is fine, but it should come after the fix in the list of > commits, otherwise you break git bisection.Got it. Is there tests naming convention? Is it OK to call it test-partitioned-md-devices.sh (for example)? -- Mykola Ivanets
Richard W.M. Jones
2018-Jan-23 11:48 UTC
Re: [Libguestfs] [RFC PATCH v1 1/3] tests: md: Test guestfish list-filesystems command skipps partitioned md devices
On Tue, Jan 23, 2018 at 01:45:42PM +0200, Nikolay Ivanets wrote:> 2018-01-23 12:11 GMT+02:00 Richard W.M. Jones <rjones@redhat.com>: > > The test is fine, but it should come after the fix in the list of > > commits, otherwise you break git bisection. > > Got it. Is there tests naming convention? > Is it OK to call it test-partitioned-md-devices.sh (for example)?Yes, that seems fine. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
Seemingly Similar Threads
- Re: [RFC PATCH v1 1/3] tests: md: Test guestfish list-filesystems command skipps partitioned md devices
- [RFC PATCH v1 1/3] tests: md: Test guestfish list-filesystems command skipps partitioned md devices
- Re: [RFC PATCH v1 3/3] daemon: list-filesystems: Don't list partitioned md devices
- Re: [RFC PATCH v1 3/3] daemon: list-filesystems: Don't list partitioned md devices
- Re: Guestfish command - "copy-out" not working for symbolic links