similar to: [PATCH 0/14] hivex: update gnulib and make "syntax-check" tests pass

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

Hi Rich, I've updated hivex to use the latest from gnulib and fixed a few syntax-check failures. With these changes, almost all of "make distcheck" succeeds. (details coming separately) >From c6300c44a1eda1a55a23249fde94882ea5a1c430 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 11:28:40 +0200 Subject: [PATCH hivex 1/2] maint:

Similar: hivex/hivex.c maint.mk: the above files include <assert.h> but don't use it make: *** [sc_prohibit_assert_without_use] Error 1 >From a71e5791293ac1e794fecffee8a2d616777f77e0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:08:09 +0100 Subject: [PATCH libguestfs] placate 'make syntax-check' *

I've pushed 10 commits which just clean up errors found by 'make syntax-check'. The remaining syntax-check errors are attached below. I think many of them are false alarms. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages.

Since commit d5b6f1df5ff2d387a5dfc89b8316c0dff67ce2c9, the daemon requires ocaml-hivex; OTOH, nothing checks it is actually available, so the build of the daemon will fail with a semi-cryptic error about the lack of a directory in the OCaml install prefix. As fix, check for the presence of the hivex module at build time, failing earlier if not present. The check is performed only when the daemon

Does hivex have a trivial-patch policy? >From e23c45a2f813ac29b022faa9112c1977b651862f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 28 Aug 2012 17:34:26 +0200 Subject: [PATCH hivex] maint: remove unnecessary mkdir -p * ocaml/Makefile.am (install-data-hook): Remove unneeded mkdir -p. It's job is handled by the very next mkdir -p. ---

There's a new syntax check rule from gnulib. It requires that you write e.g., exit (EXIT_SUCCESS), not exit (0). And the same for 1/EXIT_FAILURE and any other constants. There were a lot of violations, including a few false positives, so I started with the exemptions (see the .x-sc file below). Then I converted the vast majority automatically, with this: maint: use EXIT_SUCCESS and

On Fri, Nov 26, 2010 at 10:03:05AM -0800, Yandell, Henri wrote: > We?re looking into using Hivex and came across something odd. While > the license of hivex.c is LGPL 2.1, it appears to require the GPL > 3.0 licensed gnulib package for a few minor functions ( full_read, > full_write and c_toupper ). There are also a few GPL 3.0 build > files. It has always been our intention to

Since some modules (`getopt', for example) may copy files into the build directory, `top_builddir/lib' is needed as well as `top_srcdir/lib'. -- GNU Gnulib manual, section 2.2 Initial import This fixes an in-tree build failure on a Debian/sid system (see below). hivexml could be built out-of-tree, but it turned out that due to a missing include path, in this case the

I am attempting to compile Hivex (v1.3.18) and am getting a "handle.c:47:10: fatal error: 'hivex.h' file not found" error. I see that hivex.h is not included in the source and I suspect it is created during the configure phase. Full build log below. Any ideas of how this file is created and why it wasn't created? I was able to compile it before on earlier versions of macOS

x86 pm : provide CC7/PC2 residency Sandy bridge introduces new MSR to get cc7/pc2 residency (core C-state 7/package C-state 2). Print the cc7/pc2 residency when on sandy bridge platform. Signed-off-by: Yang Zhang <yang.z.zhang@intel.com> diff -r 662dbf6ee71c tools/libxc/xc_pm.c --- a/tools/libxc/xc_pm.c Mon Oct 24 18:01:07 2011 +0100 +++ b/tools/libxc/xc_pm.c Fri Oct 28

Hi Rich, I find it more readable (and safer to review) to avoid lines longer than 80 columns. When reviewing changes that wrap, I've noticed that it is harder to spot certain types of mistakes in the wrapped portion of a long line. >From 930118b380b35bb33e7719b0eb2ab6b31fa2d7e4 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Wed, 13 Apr 2011 16:08:57

--- configure.ac | 2 +- images/Makefile.am | 5 +++-- lib/Makefile.am | 14 +++++++------- ocaml/Makefile.am | 3 ++- ocaml/t/hivex_300_fold.ml | 3 +-- python/run-python-tests | 25 ------------------------- python/run-python-tests.in | 25 +++++++++++++++++++++++++ 7 files changed, 39 insertions(+), 38 deletions(-) delete mode

Hi I'm just posting this here in case someone is interested in building hivex on Windows (mingw32). The attached patch allows building the lib but not the tools (hivexsh etc..) as there are some more problems to solve. In short terms, this patch replaces file i/o functions and mmap(), munmap() with their win32api pendants. cu -- Unix _IS_ user friendly - it's just selective about

I'm trying to build hivex 1.2.7 on Ubuntu 10.04, and get the following failure: Making all in xml make[2]: Entering directory `/opt/sandbox/src/hivex/hivex-1.2.7/xml' CC hivexml-hivexml.o CCLD hivexml hivexml-hivexml.o: In function `main': /opt/sandbox/src/hivex/hivex-1.2.7/xml/hivexml.c:86: undefined reference to `rpl_getopt'

Hi, Few changes in hivex, sent as series to be clearly identified as hivex ones. After these patches, what about a new release of it? The last one is basically one year old, and the changes after 1.3.11 make hivex build and work fine on FreeBSD (and maybe more non-Linux OSes). Thanks, Pino Toscano (3): Fix shebang in perl scripts Update gnulib to latest. Update .gitignore with more

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

... and why they are (probably) not errors. > bindtextdomain > daemon/guestfsd.c > erlang/erl-guestfs-proto.c > examples/copy_over.c > examples/create_disk.c > examples/display_icon.c > examples/inspect_vm.c > examples/mount_local.c > examples/virt-dhcp-address.c > tests/c-api/test-add-drive-opts.c > tests/c-api/test-add-libvirt-dom.c >

On 2/1/2012 18:52, Erik de Castro Lopo wrote: > JonY wrote: > >> Alright, here's a quick fix, although it is more ugly than I remembered. >> >> Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h >> where available, and falls back to I64 on MSVC and then ll for others, >> all format warnings suppressed. > > JonY, > > Sorry

Hi Rich, I noticed that libguestfs's cfg.mk had an old (and relatively inefficient) version of the rule that checks for empty lines at EOF. The one in maint.mk is much more efficient: >From cf93f04a980ec01ef37db9a0d4c7b99015169eee Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Sep 2012 11:49:34 +0200 Subject: [PATCH libguestfs] maint: remove a