similar to: [PATCH virt-v2v] make most of "make distcheck" pass

There were a few "infelicities" that kept the "make distcheck" test from passing. These three patches combine to fix all of them, punting on only one by disabling the install-data-hook rule. >From 7504acedcb71bd80d99abe412e6669b267cade38 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Fri, 21 Aug 2009 13:37:18 +0200 Subject: [PATCH 1/3]

>From 9e99a1c6cb655a56d7f09dabd10a77a3802bf96d Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 17 Aug 2009 18:44:37 +0200 Subject: [PATCH libguestfs 1/2] avoid compiler warnings about unused vars in generated code * src/Makefile.am: Compile protocol.c into a convenience library, so it can have its own CFLAGS, and link that with the destination one. ---

There were a few unchecked syscalls in fish.c >From ba8b8b0684a03b6e6fbb939ed7e1cbf5e1000092 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Wed, 19 Aug 2009 10:01:07 +0200 Subject: [PATCH libguestfs] guestfish: detect a few more failed syscalls * fish/fish.c (issue_command): Detect/diagnose more failed syscalls. --- fish/fish.c | 26

Very similar to the one for protocol.c... >From b5896dfb673a6f8dfd536ae86a6ea3d2925d2af5 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 18 Aug 2009 10:15:57 +0200 Subject: [PATCH libguestfs] avoid compiler warnings about unused vars in generated code * fish/Makefile.am: Compile rc_protocol.c into a convenience library, so it can have its own CFLAGS, and

On principle, we shouldn't ignore write failure: >From 56317a61bc22e935dc750cf669a164bacc12cf12 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Thu, 20 Aug 2009 12:29:46 +0200 Subject: [PATCH libguestfs] daemon: diagnose socket write failure * daemon/proto.c (send_chunk): Don't ignore socket-write error. --- daemon/proto.c | 8 +++++--- 1 files

One final set: cmds.c:968:13: warning: 'print_lvm_pv' defined but not used cmds.c:1012:13: warning: 'print_lvm_vg' defined but not used cmds.c:1055:13: warning: 'print_lvm_lv' defined but not used cmds.c:1142:13: warning: 'print_dirent' defined but not used cmds.c:1196:13: warning: 'print_xattr' defined but not used cmds.c:1220:13:

I see the following warnings: cmds.c:934:13: warning: 'print_int_bool_list' defined but not used cmds.c:1093:13: warning: 'print_stat_list' defined but not used cmds.c:1124:13: warning: 'print_statvfs_list' defined but not used cmds.c:1171:13: warning: 'print_version_list' defined but not used This patch makes it so we don't emit the unused

Hello, All! Sorry for my english, I'am from Ukraine. I trying install Shout 2.0.1 module on my server: # perl Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Shout # make cp example2.pl blib/lib/example2.pl cp example.pl blib/lib/example.pl cp Shout.pm blib/lib/Shout.pm AutoSplitting blib/lib/Shout.pm (blib/lib/auto/Shout) /usr/bin/perl

I have this error compiling ASTCC: [root@pbx astcc]# make install mkdir -p /var/www mkdir -p /var/www/html/_astcc mkdir -p /var/www/cgi-bin/astcc-admin chmod 755 ./astcc.agi chmod 755 ./astcc-admin.cgi echo | ./astcc.agi >/dev/null Can't locate DBI.pm in @INC (@INC contains: /usr/lib/perl5/5.8.0/i386-linux-thread-multi /usr/lib/perl5/5.8.0

I got this build failure: Guestfs.hs:1941:11: parse error on input `module' where that (generated) file looked like this: 1940 modprobe :: GuestfsH -> String -> IO () 1941 modprobe h module = do 1942 r <- withCString module $ \module -> withForeignPtr h (\p -> c_modprobe p module) 1943 if (r == -1) 1944 then do 1945 err <-

These are the changes I made to the spec file related to gobject bindings and gobject introspection. TBH I wasn't sure how to properly package this. Rich. diff --git a/libguestfs.spec b/libguestfs.spec index 095a848..1b6e43d 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -29,7 +29,7 @@ Summary: Access and modify virtual machine disk images Name: libguestfs Epoch:

Hi Rich, I ran these commands as non-root: ./autogen.sh && make && make distcheck It got most of the way through, but failed in the VPATH part while rebuilding from a ./_build subdir, like this: make[4]: Entering directory `/h/j/w/co/hivex/hivex-1.3.6/_build/ocaml' mkdir -p /usr/lib64/ocaml mkdir -p /usr/lib64/ocaml/stublibs ocamlfind install \

Here is a bunch of small patches to make fish/ build with most warnings enabled: [1/9] edit.c: avoid warning about signed/unsigned comparison [2/9] fish.c: avoid warnings [3/9] tilde.c: avoid a warning [4/9] fish.c: avoid "assignment discards qualifiers..." warning [5/9] fish.c: avoid signed/unsigned-comparison warning [6/9] fish.c: don't perform arithmetic on void*

These patches first make src/ warning free, and then turn on the strict warning options. 75 0001-build-suppress-an-ignored-write-return-value-warning.patch 38 0002-build-suppress-an-ignored-dup-return-value-warning.patch 27 0003-generator.ml-suppress-signed-unsigned-compare-warnin.patch 48 0004-build-don-t-perform-arithmetic-on-void-pointers.patch 30

Ralf, It looks like fixing 'make distcheck' is going to be a huge pain in the neck. Is it not possible to make Jenkins do 'make check' instead of 'make distcheck'? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

It is part of the common submodule but not used in virt-v2v, so it is not included in distribution tarballs. --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 99c139b6..4dde5002 100644 --- a/Makefile.am +++ b/Makefile.am @@ -199,6 +199,7 @@ maintainer-check-extra-dist: grep -v '^common/protocol/' | \ grep -v

It is part of the common submodule but not used in libguestfs, so it is not included in distribution tarballs. --- Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 1def6e0a3..d3cf64cc1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -580,6 +580,7 @@ maintainer-check-extra-dist: ( git ls-files ; \ cd common; git ls-files | sed

Otherwise will fail like: https://mf4.xiph.org/jenkins/job/flac/lastUnsuccessfulBuild/console --- src/libFLAC/include/private/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libFLAC/include/private/Makefile.am b/src/libFLAC/include/private/Makefile.am index 62d8a18..2e33dc7 100644 --- a/src/libFLAC/include/private/Makefile.am +++ b/src/libFLAC/include/private/Makefile.am @@

The warnings in daemon were aggravating and risky for development (too easy to miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules

On Fri, Oct 23, 2015 at 02:34:53AM -0700, Jean-Christophe Manciot wrote: > Compiled from github sources and installed: > > "trying to overwrite > '/usr/lib/x86_64-linux-gnu/perl/5.20.2/perllocal.pod', which is also > in package git 1:2.6.0-1" > > What should be done to overcome that incompatibility with git? First off, don't use 'make install'