similar to: [PATCH] guestfs: don't fault upon failed vasprintf

Sorry about that. Matt noticed I introduced a compilation failure. Here's what I've pushed. >From ad7818c34d4d6ef6b0959ef7dbbf006968166030 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 3 Aug 2009 15:39:09 +0200 Subject: [PATCH] guestfs: fix typo in my recent change * src/guestfs.c (guestfs_perrorf): Rename former err to errnum, to avoid

Tested against openssh-SNAP-2013-03-04 Fix those 2 old warnings schnorr.c: In function 'debug3_bn': schnorr.c:494: warning: ignoring return value of 'vasprintf', declared with attribute warn_unused_result schnorr.c: In function 'debug3_buf': schnorr.c:519: warning: ignoring return value of 'vasprintf', declared with attribute warn_unused_result vasprintf return

Fix an off-by-one in asprintf and vasprintf. The return of vsnprintf is the number of bytes *not* including the terminating '\0'. The size argument to vsnprintf is the number of bytes *including* the terminating '\0'. diff -u klibc-0.188/klibc/asprintf.c udev/klibc-0.188/klibc/asprintf.c --- klibc-0.188/klibc/asprintf.c 2004-10-22 12:07:22.678906352 -0600 +++

Commit-ID: 17fabd540aeb5019909a024243c6d26610cab307 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=17fabd540aeb5019909a024243c6d26610cab307 Author: H. Peter Anvin <hpa at zytor.com> AuthorDate: Mon, 1 Feb 2016 01:55:04 -0800 Committer: H. Peter Anvin <hpa at zytor.com> CommitDate: Mon, 1 Feb 2016 01:55:04 -0800 [klibc] Make asprintf() a simple wrapper

https://bugzilla.mindrot.org/show_bug.cgi?id=1770 Summary: circular dependencies prevent building on platforms without strlcpy, vasprintf Product: Portable OpenSSH Version: 5.5p1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Build system

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Tue Dec 7 20:00:02 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-ubuntu for libguestfs. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux Tue Jun 21 23:20:39 BST 2011 ----- + git pull --rebase git://git.annexia.org/git/libguestfs.git master >From git://git.annexia.org/git/libguestfs *

This is an automatic message generated by the builder on builder-ubuntu for febootstrap. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 GNU/Linux Tue Dec 7 12:22:48 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap * branch

This is an automatic message generated by the builder on builder-ubuntu for febootstrap. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 GNU/Linux Fri Dec 10 22:00:01 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap * branch

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Tue Dec 7 20:40:02 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Fri Dec 10 20:00:01 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-ubuntu for febootstrap. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 GNU/Linux Tue Mar 15 22:00:01 GMT 2011 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap * branch

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Tue Mar 15 20:00:01 GMT 2011 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Fri Mar 18 20:00:01 GMT 2011 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-ubuntu for febootstrap. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux Tue Mar 22 22:00:01 GMT 2011 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-ubuntu for febootstrap. Log files from the build follow below. Linux builder-ubuntu 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:45:36 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux Fri Mar 18 22:00:01 GMT 2011 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

This is an automatic message generated by the builder on builder-debian for febootstrap. Log files from the build follow below. Linux builder-debian.home.annexia.org 2.6.36-trunk-amd64 #1 SMP Wed Oct 27 14:28:29 UTC 2010 x86_64 GNU/Linux Tue Dec 7 11:26:13 GMT 2010 ----- + git pull --rebase git://git.annexia.org/git/febootstrap.git master >From git://git.annexia.org/git/febootstrap *

On Wednesday, 11 October 2017 17:23:45 CEST Richard W.M. Jones wrote: > +static int > +mexp_vprintf (mexp_h *h, int password, const char *fs, va_list args) > { > - va_list args; > char *msg; > int len; > size_t n; > ssize_t r; > char *p; > > - va_start (args, fs); > len = vasprintf (&msg, fs, args); > - va_end (args); Due to the

hi, it can hardly be considered a memleak since I can see that the ret value is always checked in parent code (xasprintf() for example) and fatal() called if it's equal to -1 but the free() call is definitely missing there. --- bsd-asprintf.c Tue Dec 5 12:58:12 2006 +++ bsd-asprintf.c.new Thu Sep 13 16:51:40 2007 @@ -55,6 +55,7 @@ if (ret >= 0 && ret < INIT_SZ)

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >