similar to: [Bug 377] Reduce compiler warnings. Use unsigned args to the ctype.h is*() macros.

http://bugzilla.mindrot.org/show_bug.cgi?id=377 ------- Additional Comments From djm at mindrot.org 2003-01-07 21:26 ------- FYI: please attach patches rather than pasting them in comment fields (which corrupt them) Markus has fixed some of the signed subscripts in a int/u_int cleanup ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching

http://bugzilla.mindrot.org/show_bug.cgi?id=377 Summary: Reduce compiler warnings. Use unsigned args to the ctype.h is*() macros. Product: Portable OpenSSH Version: -current Platform: Sparc OS/Version: Solaris Status: NEW Severity: trivial Priority: P2 Component: Miscellaneous

http://bugzilla.mindrot.org/show_bug.cgi?id=565 djm at mindrot.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #304 is|0 |1 obsolete| | ------- Additional Comments From djm at mindrot.org 2003-05-26 11:04 ------- (From

In several places, openssh-2.9.9p2 passes a 'char' value to a ctype macro like 'isdigit'. This has undefined behavior on hosts with signed characters, if the character value happens to be negative. For example, isdigit('\200') expands to an array access that is a subscript error on hosts with signed characters where '\200' == -128. This leads to incorrect results,

Hm, finally subscribed here, forgot to... Anyway, I'm using klibc in udev and have added some needed functions (like ftruncate and vsyslog). Should I post the patches here before commiting them to the cvs tree? Also, it looks like ctype.h has a off-by-one bug. isspace(' ') returns 0 right now, but if you change the function from: __ctype_inline int isspace(int __c) { return

Hi, So far with the latest changes the projects I am trying to port works fine, except for a mismatch on what is considered the ansi behaviour of islower() in ctype.h: ----- i = 220 islower (i) = 0, ISLOWER (i) = 0 toupper (i) = 220, TOUPPER (i) = 220 i = 221 islower (i) = 0, ISLOWER (i) = 0 toupper (i) = 221, TOUPPER (i) = 221 i = 222 islower (i) = 0, ISLOWER (i) = 0 toupper (i) = 222, TOUPPER

http://bugzilla.mindrot.org/show_bug.cgi?id=407 ------- Additional Comments From djm at mindrot.org 2003-01-03 15:27 ------- Please retest with the latest OpenSSH (3.5p1) ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

https://bugzilla.mindrot.org/show_bug.cgi?id=1981 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2136| |ok+ Flags| | --- Comment #4 from Damien Miller <djm at mindrot.org>

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I have just uploaded openssh-1.2pre15 to http://violet.ibs.com.au/openssh/ Changes: - Merged big source cleanup from OpenBSD CVS. All the source now conforms to: http://www.openbsd.org/cgi-bin/man.cgi?query=style&apropos=0&sektion=9&manpath=OpenBSD+Current&format=html - Added BSD compatible install program - More

http://bugzilla.mindrot.org/show_bug.cgi?id=368 ------- Additional Comments From djm at mindrot.org 2003-05-14 22:59 ------- Please retest with a recent release, some of the older releases had OpenSSL issues. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=897 ------- Additional Comments From djm at mindrot.org 2005-06-21 13:08 ------- Have you had a chance to retest yet? I'd like to close this bug if possible. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.

Hi, Per the definitions of the ctype functions in POSIX-1.2008 "the c argument is an int, the value of which the application shall ensure is a character representable as an unsigned char or equal to the value of the macro EOF. If the argument has any other value, the behavior is undefined." For obvious reasons this results in problems if you use signed char variables as parameters in

https://bugzilla.mindrot.org/show_bug.cgi?id=1932 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #2 from Damien Miller <djm at mindrot.org> --- Set all RESOLVED bugs to CLOSED with release

See http://gcc.gnu.org/gcc-4.3/porting_to.html for details. Signed-off-by: Jon Ringle <jon at ringle.org> --- usr/include/klibc/compiler.h | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/usr/include/klibc/compiler.h b/usr/include/klibc/compiler.h index 816a4ee..e0da37e 100644 --- a/usr/include/klibc/compiler.h +++ b/usr/include/klibc/compiler.h @@ -24,7 +24,11

In 0.97 io.h is wrong in several places. it should be returning __v, not v. static __inline__ unsigned char inb(unsigned short __p) { unsigned char __v; asm volatile("inb %1,%0" : "=a" (__v) : "dN" (__p)); return v; } How do I get rid of these warnings? /home/mesa/boot/klibc/klibc/include/stdlib.h:21: warning: shadowing built-in function `abs'

http://bugzilla.mindrot.org/show_bug.cgi?id=517 djm at mindrot.org changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #265 is|0 |1 obsolete| | ------- Additional Comments From djm at mindrot.org 2003-05-15 18:50 ------- Created

This is a fourth cut of the hypervisor patch of the proposed XENMEM_claim_pages hypercall/subop, taking into account feedback from Jan and Keir and IanC, plus some fixes found via runtime debugging (using privcmd only) and some added comments/cleanup. [Logistical note: I will be out tomorrow (Friday) plus US holidays next week so my responsiveness to comments may be slower for awhile. --djm]

https://bugzilla.mindrot.org/show_bug.cgi?id=2189 Bug ID: 2189 Summary: Client fails to consider hostname when matching rfwd channel opens Product: Portable OpenSSH Version: -current Hardware: Other OS: All Status: NEW Severity: minor Priority: P5 Component: ssh

Signed-off-by: Thorsten Glaser <tg at mirbsd.org> --- usr/include/ctype.h | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/usr/include/ctype.h b/usr/include/ctype.h index 4fd162b..14a2f2d 100644 --- a/usr/include/ctype.h +++ b/usr/include/ctype.h @@ -47,6 +47,20 @@ __extern int tolower(int); extern const unsigned char __ctypes[]; +__must_inline

https://bugzilla.mindrot.org/show_bug.cgi?id=1909 Damien Miller <djm at mindrot.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |djm at mindrot.org Resolution|---