Shorewall users - Jun 2008 - small patch for MODULESDIR

Tom,

Would you be averse to a small patch to satisfy the kernel module
location of OpenWRT?  I thought I had proposed this before but I cannot
seem to find it in the archives.

--- /usr/share/shorewall-perl/prog.header	2008-06-28 14:05:03.000000000 -0400
+++ /tmp/prog.header	2008-06-28 14:03:57.000000000 -0400
@@ -216,7 +216,7 @@
 
     [ -n "${MODULE_SUFFIX:=o gz ko o.gz ko.gz}" ]
 
-    [ -z "$MODULESDIR" ] && MODULESDIR=/lib/modules/$(uname
-r)/kernel/net/ipv4/netfilter:/lib/modules/$(uname
-r)/kernel/net/netfilter:/lib/modules/$(uname -r)
+    [ -z "$MODULESDIR" ] && MODULESDIR=/lib/modules/$(uname
-r)/kernel/net/ipv4/netfilter:/lib/modules/$(uname -r)/kernel/net/netfilter
     MODULES=$(lsmod | cut -d '' '' -f1)
 
     for directory in $(split $MODULESDIR); do
@@ -248,7 +248,7 @@
     [ -n "${MODULE_SUFFIX:=o gz ko o.gz ko.gz}" ]
 
     [ -z "$MODULESDIR" ] && \
-	MODULESDIR=/lib/modules/$(uname
-r)/kernel/net/ipv4/netfilter:/lib/modules/$(uname
-r)/kernel/net/netfilter:/lib/modules/$(uname -r)
+	MODULESDIR=/lib/modules/$(uname
-r)/kernel/net/ipv4/netfilter:/lib/modules/$(uname -r)/kernel/net/netfilter
 
     for directory in $(split $MODULESDIR); do
 	[ -d $directory ] && moduledirectories="$moduledirectories
$directory"

I''d be happy to have just added this to the OpenWRT patches for
shorewall-lite, however this is needed on shorewall-lite''s respective
shorewall (proper) machine.

As an aside, given these two identical MODULESDIR=... assignments, maybe
even a function to keep it all in one place.  That''s gravy though.  :-)

Cheers,
b.



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It''s the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

Brian J. Murrell wrote:
> Tom,
> 
> Would you be averse to a small patch to satisfy the kernel module
> location of OpenWRT?  I thought I had proposed this before but I cannot
> seem to find it in the archives.
With Shorewall-perl, you can simply set MODULESDIR the way you want it 
in shorewall.conf:

	MODULESDIR=/lib/modules/$(uname -r)

and the exported script will execute this statement during its 
initialization:

	MODULESDIR="/lib/modules/$(uname -r)"

-Tom
-- 
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ teastep@shorewall.net
PGP Public Key   \ https://lists.shorewall.net/teastep.pgp.key



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It''s the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php

On Sat, 2008-06-28 at 11:56 -0700, Tom Eastep wrote:
> 
> With Shorewall-perl, you can simply set MODULESDIR the way you want it 
> in shorewall.conf:
> 
> 	MODULESDIR=/lib/modules/$(uname -r)
> 
> and the exported script will execute this statement during its 
> initialization:
> 
> 	MODULESDIR="/lib/modules/$(uname -r)"
Indeed, I did have:

MODULESDIR=/lib/modules/2.6.23.1

in mine, but of course, it broke on the new kernel.  I had briefly
wondered if a shell $() would work.

Cheers,
b.



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It''s the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php