The change included in RC1 to fix INCLUDE errors is OK for the 3.2 release but seems wrong in the long term. I have decided that /etc/shorewall/params should only be processed during the compile phase and that any shell variables required by extension scripts at run-time should be set in your /etc/shorewall/init script. As part of this change, extra white space will no longer be compressed from /etc/shorewall/params. You can update your RC1 using files at http://www1.shorewall.net/pub/shorewall/development/3.4/shorewall-3.4.0-RC1/errata/. To implement this change, either: a) Replace your /usr/share/shorewall/compiler file with the ''compiler'' file from the errata/Shorewall sub-directory; or b) Patch your /usr/share/shorewall/compiler file using the ''patch-3.4.0-RC1-1.diff patch from the errata/patches sub-directory. -Tom -- Tom Eastep \ Nothing is foolproof to a sufficiently talented fool Shoreline, \ http://shorewall.net Washington USA \ teastep@shorewall.net PGP Public Key \ https://lists.shorewall.net/teastep.pgp.key ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> The change included in RC1 to fix INCLUDE errors is OK for the 3.2 > release but seems wrong in the long term. I have decided that > /etc/shorewall/params should only be processed during the compile > phase and that any shell variables required by extension scripts at > run-time should be set in your /etc/shorewall/init script. > > As part of this change, extra white space will no longer be > compressed from /etc/shorewall/params. > > You can update your RC1 using files at > http://www1.shorewall.net/pub/shorewall/development/3.4/shorewall-3.4.0-RC1/errata/. > > To implement this change, either: > > a) Replace your /usr/share/shorewall/compiler file with the > ''compiler'' file from the errata/Shorewall sub-directory; or > > b) Patch your /usr/share/shorewall/compiler file using the > ''patch-3.4.0-RC1-1.diff patch from the errata/patches > sub-directory.Hi Tom, The patch-3.4.0-RC1-1.diff doesn''t apply without errors for me and diffing the two compiler files shows something different. Is this the wrong patch for 3.4.0-RC1? Thanks, Simon ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
Hi Simon, Simon Matter wrote:> > The patch-3.4.0-RC1-1.diff doesn''t apply without errors for me and diffing > the two compiler files shows something different. Is this the wrong patch > for 3.4.0-RC1?Ouch. When I tagged 3.4.0 RC1, I did so on a system that didn''t have a current copy of the main branch. As a consequence, the patch that I generated was against the wrong version of the code. I''ve attached the correct patch and have posted it to www1.shorewall.net. Sorry for the inconvenience. -Tom -- Tom Eastep \ Nothing is foolproof to a sufficiently talented fool Shoreline, \ http://shorewall.net Washington USA \ teastep@shorewall.net PGP Public Key \ https://lists.shorewall.net/teastep.pgp.key ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642