Shorewall users - Sep 2006 - Using -e instead of -x, bug of feature?

Hi Tom and everybody,

I was just wondering whether the usage of -e instead of -x is intented or
not (maybe for some minimalistic shell?).

Regards,
Simon

--- shorewall-3.2.3/shorewall.orig      2006-08-25 18:45:52.000000000 +0200
+++ shorewall-3.2.3/shorewall   2006-09-05 14:34:22.000000000 +0200
@@ -208,7 +208,7 @@
        fi

        if [ -n "$IPTABLES" ]; then
-           if [ ! -e "$IPTABLES" ]; then
+           if [ ! -x "$IPTABLES" ]; then
                echo "   ERROR: The program specified in IPTABLES does not
exist or is not executable" >&2
                exit 2
            fi
@@ -270,7 +270,7 @@
     fi

     if [ -n "$SHOREWALL_SHELL" ]; then
-       if [ ! -e "$SHOREWALL_SHELL" ]; then
+       if [ ! -x "$SHOREWALL_SHELL" ]; then
            echo "   ERROR: The program specified in SHOREWALL_SHELL does
not exist or is not executable" >&2
            exit 2
        fi
[simix@sup shorewall-3.2.3-1.src]$ cat shorewall-lite-3.2.3-exec_test.patch
--- shorewall-lite-3.2.3/shorewall-lite.orig    2006-08-09
16:38:40.000000000 +0200
+++ shorewall-lite-3.2.3/shorewall-lite 2006-09-05 14:34:41.000000000 +0200
@@ -189,7 +189,7 @@
     export LOGFORMAT

     if [ -n "$IPTABLES" ]; then
-       if [ ! -e "$IPTABLES" ]; then
+       if [ ! -x "$IPTABLES" ]; then
            echo "   ERROR: The program specified in IPTABLES does not
exist or is not executable" >&2
            exit 2
        fi
@@ -204,7 +204,7 @@
     export IPTABLES

     if [ -n "$SHOREWALL_SHELL" ]; then
-       if [ ! -e "$SHOREWALL_SHELL" ]; then
+       if [ ! -x "$SHOREWALL_SHELL" ]; then
            echo "   ERROR: The program specified in SHOREWALL_SHELL does
not exist or is not executable" >&2
            exit 2
        fi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

On Tue, 2006-09-05 at 14:42 +0200, Simon Matter wrote:
> Hi Tom and everybody,
> 
> I was just wondering whether the usage of -e instead of -x is intented or
> not (maybe for some minimalistic shell?).
It was unintentional.

Thanks,
-Tom
-- 
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ teastep@shorewall.net
PGP Public Key   \ https://lists.shorewall.net/teastep.pgp.key


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642