Shorewall users - May 2004 - Small patch for quiet.

Hello Tom and others,

The attached patch extends the command line option -q for the shorewall 
add and delete it will go to "default unix mode" aka no output if 
everything is ok.

Successfull adding:
-------------------------------------------------------------
[root]# shorewall -q add ppp0:10.10.10.1 rcs

Successfull deletion:
-------------------------------------------------------------
[root]# shorewall -q delete ppp0:10.10.10.1 rcs

Error deleting:
-------------------------------------------------------------
[root]# shorewall -q delete ppp0:10.10.10.1 rcs
    Warning: ppp0:10.10.10.1 does not appear to be in zone rcs

Error adding:
-------------------------------------------------------------
[root]# shorewall -q add ppp0:10.10.10.1 rcs
    Error: ppp0:10.10.10.1 already in zone rcs
Terminated

I wonder why there is an ''Terminated'' at when an error in
adding is
occuring, but not when deleting, imho the ''Terminated'' is not
really
needed... But you are the author ;-)

Also it''s ok for me if you don''t add it, I still have to build
my
scripts to do the automatic adding / deletion.

-- 
Met Vriendelijke groet/Yours Sincerely
Stijn Jonker <SJCJonker@sjc.nl>

Stijn Jonker wrote:
> The attached patch extends the command line option -q for the shorewall 
> add and delete it will go to "default unix mode" aka no output if
> everything is ok.
Thanks!
> 
> Error adding:
> -------------------------------------------------------------
> [root]# shorewall -q add ppp0:10.10.10.1 rcs
>    Error: ppp0:10.10.10.1 already in zone rcs
> Terminated
> 
> I wonder why there is an ''Terminated'' at when an error in
adding is
> occuring, but not when deleting, imho the ''Terminated'' is
not really
> needed... But you are the author ;-)
That message occurs because the stop_firewall function does "kill $$"
so
that the shell will stop if an error is detected in a sub-shell. I have 
no control over the "Terminated" message that results.

-Tom
-- 
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ teastep@shorewall.net