Shorewall users - Oct 2003 - icmp with multiport

Hi Shorewall-users,

  I have next rule
  ACCEPT      loc  $FW  icmp    0,8,11,12
  When try to start shorewall 1.4.7, it detect multiport and process
  rules terminated with
  iptables 1.2.8 .... invalid icmp-type "0,8,11,12"

  this small patch solve problem for me
--- firewall.icmpmport  Sat Oct  4 18:22:20 2003
+++ firewall    Wed Oct  8 17:19:54 2003
@@ -960,7 +960,7 @@
     local chain=$2
     local disposition=$3
     local rulenum-    local limit=${4:-$LOGLIMIT}
+    local limit="${4:-$LOGLIMIT}"
 
     shift;shift;shift;shift
 
@@ -2801,6 +2801,9 @@
        *)
 
            if [ -n "$MULTIPORT" -a \
+               "$protocol" != "icmp" -a \
+               "$protocol" != "ICMP" -a \
+               "$protocol" != "1" -a \
                "$ports" = "${ports%:*}" -a \
                "$cports" = "${cports%:*}" -a \
                `list_count $ports` -le 15 -a \   

-- 
Best regards,
 Andrew                          mailto:azh@tut.by

On Wed, 2003-10-08 at 07:46, Andrew Zhoglo wrote:
> Hi Shorewall-users,
> 
>   I have next rule
>   ACCEPT      loc  $FW  icmp    0,8,11,12
>   When try to start shorewall 1.4.7, it detect multiport and process
>   rules terminated with
>   iptables 1.2.8 .... invalid icmp-type "0,8,11,12"
> 
>   this small patch solve problem for me
Thanks -- I''ve been meaning to correct this wart. I''ve merged
your
patch.

-Tom
-- 
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ teastep@shorewall.net