Hi, I am currently in the process to pushing shorewall on openSUSE Factory (devel branch of openSUSE), to make it officially available with next openSUSE release main repository. During the process I have encountered some issues and would appreciate if you can clarify them. Is there any reason why you copy ifupdown scripts in the %post section of shorewall-init.spec. Why not list them in the %files section? The following files have the she-bang yet they are installed non-executable. Is it Ok to remove the she-bang from them /usr/share/shorewall/prog.header* /usr/share/shorewall/lib.* /usr/share/shorewall6/lib.* /usr/share/shorewall-lite/lib.* /usr/share/shorewall6-lite/lib.* /etc/shorewall/scfilter /etc/shorewall6/scfilter /usr/share/shorewall/configfiles/scfilter usr/share/shorewall6/configfiles/scfilter Thanks Togan Muftuoglu ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
On Wed, 2011-08-03 at 12:27 +0200, Togan Muftuoglu wrote:> > Is there any reason why you copy ifupdown scripts in the %post section > of shorewall-init.spec. Why not list them in the %files section?The ifupdown script must be installed in a different location, depending on the distribution (and version of the distribution). In your case, you can include it in the %files section.> > > The following files have the she-bang yet they are installed > non-executable. Is it Ok to remove the she-bang from them > > /usr/share/shorewall/prog.header* > /usr/share/shorewall/lib.* > /usr/share/shorewall6/lib.* > /usr/share/shorewall-lite/lib.* > /usr/share/shorewall6-lite/lib.* > /etc/shorewall/scfilter > /etc/shorewall6/scfilter > /usr/share/shorewall/configfiles/scfilter > usr/share/shorewall6/configfiles/scfilterThe prog.header* files become the first part of the compiled script, so must contain ''#!''. It can be removed from the lib.* files. I have it there primarily to cause Emacs to automatically choose shell mode when I edit the files. Currently, the function ''show_connection_filter()'' (*/lib.cli), depends on the ''#!'' in an scfilter. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
Hi Togan, I package shorewall for the Fedora repositories, and so I can answer from the perspective of those packages, rather than Tom''s: On 3 August 2011 11:27, Togan Muftuoglu <toganm@users.sourceforge.net> wrote:> Is there any reason why you copy ifupdown scripts in the %post section > of shorewall-init.spec. Why not list them in the %files section? >In the Fedora package we do as you suggest, list them in %files and install them during %install.> > The following files have the she-bang yet they are installed > non-executable. Is it Ok to remove the she-bang from them > > /usr/share/shorewall/prog.header* > /usr/share/shorewall/lib.* > /usr/share/shorewall6/lib.* > /usr/share/shorewall-lite/lib.* > /usr/share/shorewall6-lite/lib.* > /etc/shorewall/scfilter > /etc/shorewall6/scfilter > /usr/share/shorewall/configfiles/scfilter > usr/share/shorewall6/configfiles/scfilterWe generally remove the shebang from these (though note Tom''s email about scfilter). J. ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
On Aug 3, 2011, at 6:27 AM, Jonathan Underwood wrote:>> >> /usr/share/shorewall/prog.header* >> /usr/share/shorewall/lib.* >> /usr/share/shorewall6/lib.* >> /usr/share/shorewall-lite/lib.* >> /usr/share/shorewall6-lite/lib.* >> /etc/shorewall/scfilter >> /etc/shorewall6/scfilter >> /usr/share/shorewall/configfiles/scfilter >> usr/share/shorewall6/configfiles/scfilter > > We generally remove the shebang from these (though note Tom''s email > about scfilter).With the exception of the scfilter files, I have removed the shebang from the other files. As part of that change, the shebang in the compiled script will contain the pathname of the SHOREWALL_SHELL, rather than /bin/sh (when the two are different, of course). -Tom Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
On Wed, 2011-08-03 at 07:42 -0700, Tom Eastep wrote:> On Aug 3, 2011, at 6:27 AM, Jonathan Underwood wrote: > >> > >> /usr/share/shorewall/prog.header* > >> /usr/share/shorewall/lib.* > >> /usr/share/shorewall6/lib.* > >> /usr/share/shorewall-lite/lib.* > >> /usr/share/shorewall6-lite/lib.* > >> /etc/shorewall/scfilter > >> /etc/shorewall6/scfilter > >> /usr/share/shorewall/configfiles/scfilter > >> usr/share/shorewall6/configfiles/scfilter > > > > We generally remove the shebang from these (though note Tom''s email > > about scfilter). > > With the exception of the scfilter files, I have removed the shebang from the other files. > > As part of that change, the shebang in the compiled script will contain the pathname of the SHOREWALL_SHELL, rather than /bin/sh (when the two are different, of course).Note that I am currently targeting this change for 4.4.23. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
On Wed, 2011-08-03 at 07:42 -0700, Tom Eastep wrote:> > With the exception of the scfilter files, I have removed the shebang from the other files. >Took a closer look at the scfilter code in lib.cli, and it defaults to $SHORWEALL_SHELL if no shebang is present. So I''ve removed it from those files as well. Regards, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1
On 08/03/2011 03:27 PM, Jonathan Underwood wrote:> Hi Togan, > > I package shorewall for the Fedora repositories, and so I can answer > from the perspective of those packages, rather than Tom''s:<http://koji.fedoraproject.org/> is I guess where I can see the defora packages> On 3 August 2011 11:27, Togan Muftuoglu <toganm@users.sourceforge.net> wrote: >> Is there any reason why you copy ifupdown scripts in the %post section >> of shorewall-init.spec. Why not list them in the %files section? >> > > In the Fedora package we do as you suggest, list them in %files and > install them during %install.Now I do the same> > We generally remove the shebang from these (though note Tom''s email > about scfilter). >And now I do as well. Thanks to both you, That was helpful Togan ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1