Shorewall devel - Jun 2011 - qw(...) ... deprecated... in shorewall 4.4.20.2 after perl-5.14

Hello,

I am a Mageia (fork of Mandriva) tester and we have currently in our Cauldron
release, being the working version of Mageia 2, the latest version of perl being
perl-5.14.

But now we see a warning when starting shorewall installed from
shorewall-4.4.20.2-1.mga2.noarch.rpm:

Compiling...
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Config.pm line 3477.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Config.pm line 3682.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1599.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1603.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1607.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1611.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1616.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1642.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1646.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1650.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 1654.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Chains.pm line 4837.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Rules.pm line 463.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Misc.pm line 1829.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Compiler.pm line 111.
Use of qw(...) as parentheses is deprecated at
/usr/share/shorewall/Shorewall/Compiler.pm line 119.
Shorewall configuration compiled to /var/lib/shorewall/.restart
Restarting Shorewall...

The words seems to indicate this is harmless from the security point of view,
and probably a warning to shorewall developers that with future versions of perl
the scripting in sw needs adapting to such perl.

Can you please confirm our view?

Shouuld we raise a ticket on shorewall''s trac?

Thnanks in advance and regards,
=Dick Gevers

------------------------------------------------------------------------------
EditLive Enterprise is the world''s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

On Mon, 2011-06-13 at 06:01 +0000, Dick Gevers wrote:
> Hello,
> 
> I am a Mageia (fork of Mandriva) tester and we have currently in our
Cauldron
> release, being the working version of Mageia 2, the latest version of perl
being
> perl-5.14.
> 
> But now we see a warning when starting shorewall installed from
> shorewall-4.4.20.2-1.mga2.noarch.rpm:
...
> The words seems to indicate this is harmless from the security point of
view,
> and probably a warning to shorewall developers that with future versions of
perl
> the scripting in sw needs adapting to such perl.
> 
> Can you please confirm our view?
Yes -- it is a harmless(but annoying) warning from the Perl compiler.
> 
> Shouuld we raise a ticket on shorewall''s trac?
> 
Not necessary.

Attached is a patch that should correct the problem.

	cd /usr/share/shorewall/Shorewall
	patch < .../QW.patch

-Tom
-- 
Tom Eastep        \ When I die, I want to go like my Grandfather who
Shoreline,         \ died peacefully in his sleep. Not screaming like
Washington, USA     \ all of the passengers in his car
http://shorewall.net \________________________________________________




------------------------------------------------------------------------------
EditLive Enterprise is the world''s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

Tom Eastep <teastep <at> shorewall.net> writes:
> Yes -- it is a harmless(but annoying) warning from the Perl compiler.
 
> Attached is a patch that should correct the problem.
> 
> 	cd /usr/share/shorewall/Shorewall
> 	patch < .../QW.patch
> 
> -Tom
Brilliant! Thanks a million on behalf of all Mageians.

=Dick Gevers



------------------------------------------------------------------------------
EditLive Enterprise is the world''s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev