The attached patch adds more flexibility with LIBEXEC and PERLLIB parameters and corrects some typos. Togan ------------------------------------------------------------------------------ Forrester Wave Report - Recovery time is now measured in hours and minutes not days. Key insights are discussed in the 2010 Forrester Wave Report as part of an in-depth evaluation of disaster recovery service providers. Forrester found the best-in-class provider in terms of services and vision. Read this report now! http://p.sf.net/sfu/ibm-webcastpromo
Can you separate the flexibility part from the typo part? I''m having a hard time reviewing this patch when I don''t know which part each change is addressing. Thanks, -Tom On Apr 13, 2011, at 11:01 AM, Togan Muftuoglu wrote:> The attached patch adds more flexibility with LIBEXEC and PERLLIB > parameters and corrects some typos. > > Togan > <0001-redefined-LIBEXEC-and-PERLLIB-for-flexibility.patch>------------------------------------------------------------------------------ > Forrester Wave Report - Recovery time is now measured in hours and minutes > not days. Key insights are discussed in the 2010 Forrester Wave Report as > part of an in-depth evaluation of disaster recovery service providers. > Forrester found the best-in-class provider in terms of services and vision. > Read this report now! http://p.sf.net/sfu/ibm-webcastpromo_______________________________________________ > Shorewall-devel mailing list > Shorewall-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/shorewall-develTom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On Apr 14, 2011, at 5:27 PM, Tom Eastep wrote:> Can you separate the flexibility part from the typo part? I''m having a hard time reviewing this patch when I don''t know which part each change is addressing.Also, what usage scenario does the ''flexibility'' part address? What values of LIBEXEC and PERLLIB make any sense with your patch? Thanks, -Tom Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On 04/15/2011 02:27 AM, Tom Eastep wrote:> Can you separate the flexibility part from the typo part? I''m having a hard time reviewing this patch when I don''t know which part each change is addressing. >The attached patch fixes typos only. Togan ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On 04/15/2011 10:53 AM, Togan Muftuoglu wrote:> On 04/15/2011 02:27 AM, Tom Eastep wrote: >> Can you separate the flexibility part from the typo part? I''m having a hard time reviewing this patch when I don''t know which part each change is addressing. >> > > The attached patch fixes typos only.Thanks, Togan -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On 04/15/2011 04:25 AM, Tom Eastep wrote:> On Apr 14, 2011, at 5:27 PM, Tom Eastep wrote: > > Also, what usage scenario does the ''flexibility'' part address? What values of LIBEXEC and PERLLIB make any sense with your patch?In the default case /usr part is fixed so that means for instance to install in /opt is not possible. Also it is easier in making rpm packages to use the %_libexecdir and %perl_vendorlib and especially with the PERLLIB when I am supporting 4 versions of the distro makes my life easier( puts on selfishness hat) Thanks Togan ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On 04/15/2011 11:07 AM, Togan Muftuoglu wrote:> On 04/15/2011 04:25 AM, Tom Eastep wrote: >> On Apr 14, 2011, at 5:27 PM, Tom Eastep wrote: >> >> Also, what usage scenario does the ''flexibility'' part address? What values of LIBEXEC and PERLLIB make any sense with your patch? > > In the default case /usr part is fixed so that means for instance to > install in /opt is not possible. Also it is easier in making rpm > packages to use the %_libexecdir and %perl_vendorlib and especially with > the PERLLIB when I am supporting 4 versions of the distro makes my life > easier( puts on selfishness hat)Okay -- I have applied this change for release in 4.4.20. Maintainers who have taken advantage of LIBEXEC and PERLLIB when building your 4.4.19 packages must be prepared to change the values of these two environmental variables in 4.4.20. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On 04/16/2011 08:00 AM, Tom Eastep wrote:> On 04/15/2011 11:07 AM, Togan Muftuoglu wrote: >> On 04/15/2011 04:25 AM, Tom Eastep wrote: >>> On Apr 14, 2011, at 5:27 PM, Tom Eastep wrote: >>> >>> Also, what usage scenario does the ''flexibility'' part address? What values of LIBEXEC and PERLLIB make any sense with your patch? >> >> In the default case /usr part is fixed so that means for instance to >> install in /opt is not possible. Also it is easier in making rpm >> packages to use the %_libexecdir and %perl_vendorlib and especially with >> the PERLLIB when I am supporting 4 versions of the distro makes my life >> easier( puts on selfishness hat) > > Okay -- I have applied this change for release in 4.4.20. > > Maintainers who have taken advantage of LIBEXEC and PERLLIB when > building your 4.4.19 packages must be prepared to change the values of > these two environmental variables in 4.4.20.Unfortunately, I''ve had to reverse the patch because it is incomplete: a) It only modifies the installers. b) It does not make similar modifications to the uninstallers. c) More importantly, it doesn''t modify the code that actually uses the LIBEXEC setting. So: - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on a remote firewall that runs the corresponding -lite package. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote:> Unfortunately, I''ve had to reverse the patch because it is incomplete: > > a) It only modifies the installers. > b) It does not make similar modifications to the uninstallers. > c) More importantly, it doesn''t modify the code that actually uses the > LIBEXEC setting. So: > > - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl > - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on > a remote firewall that runs the corresponding -lite package. >I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911 -Tom Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
Hi, On 04/17/2011 09:53 PM, Tom Eastep wrote:> > On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote: >> Unfortunately, I''ve had to reverse the patch because it is incomplete: >> >> a) It only modifies the installers. >> b) It does not make similar modifications to the uninstallers. >> c) More importantly, it doesn''t modify the code that actually uses the >> LIBEXEC setting. So: >> >> - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl >> - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on >> a remote firewall that runs the corresponding -lite package. >> > I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911When I backport this commit to current 4.4.19.3 shorewall6 doesn''t start and gives the following error /sbin/shorewall6: Error in line 306: PERL5LIB=/usr/lib/perl5/vendor_perl/5.12.1: No such file or directory However shorewall starts with no errors. Any ideas ? Thanks Togan ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
On 05/11/2011 12:06 PM, Togan Muftuoglu wrote:> Hi, > > On 04/17/2011 09:53 PM, Tom Eastep wrote: >> >> On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote: >>> Unfortunately, I''ve had to reverse the patch because it is incomplete: >>> >>> a) It only modifies the installers. >>> b) It does not make similar modifications to the uninstallers. >>> c) More importantly, it doesn''t modify the code that actually uses the >>> LIBEXEC setting. So: >>> >>> - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl >>> - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on >>> a remote firewall that runs the corresponding -lite package. >>> >> I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911 > > When I backport this commit to current 4.4.19.3 shorewall6 doesn''t start > and gives the following error > > /sbin/shorewall6: Error in line 306: > PERL5LIB=/usr/lib/perl5/vendor_perl/5.12.1: No such file or directory > > > However shorewall starts with no errors. > > Any ideas ? >What is g_libexec being set to in /sbin/shorewall? Thanks, -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
On 05/11/2011 09:43 PM, Tom Eastep wrote:> On 05/11/2011 12:06 PM, Togan Muftuoglu wrote: >> Hi, >> >> On 04/17/2011 09:53 PM, Tom Eastep wrote: >>> >>> On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote: >>>> Unfortunately, I''ve had to reverse the patch because it is incomplete: >>>> >>>> a) It only modifies the installers. >>>> b) It does not make similar modifications to the uninstallers. >>>> c) More importantly, it doesn''t modify the code that actually uses the >>>> LIBEXEC setting. So: >>>> >>>> - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl >>>> - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on >>>> a remote firewall that runs the corresponding -lite package. >>>> >>> I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911 >> >> When I backport this commit to current 4.4.19.3 shorewall6 doesn''t start >> and gives the following error >> >> /sbin/shorewall6: Error in line 306: >> PERL5LIB=/usr/lib/perl5/vendor_perl/5.12.1: No such file or directory >> >> >> However shorewall starts with no errors. >> >> Any ideas ? >> > > What is g_libexec being set to in /sbin/shorewall?/usr/lib Togan ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
On 05/11/2011 12:43 PM, Tom Eastep wrote:> On 05/11/2011 12:06 PM, Togan Muftuoglu wrote: >> Hi, >> >> On 04/17/2011 09:53 PM, Tom Eastep wrote: >>> >>> On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote: >>>> Unfortunately, I''ve had to reverse the patch because it is incomplete: >>>> >>>> a) It only modifies the installers. >>>> b) It does not make similar modifications to the uninstallers. >>>> c) More importantly, it doesn''t modify the code that actually uses the >>>> LIBEXEC setting. So: >>>> >>>> - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl >>>> - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on >>>> a remote firewall that runs the corresponding -lite package. >>>> >>> I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911 >> >> When I backport this commit to current 4.4.19.3 shorewall6 doesn''t start >> and gives the following error >> >> /sbin/shorewall6: Error in line 306: >> PERL5LIB=/usr/lib/perl5/vendor_perl/5.12.1: No such file or directory >> >> >> However shorewall starts with no errors. >> >> Any ideas ? >> > > What is g_libexec being set to in /sbin/shorewall?Nevermind -- I have reproduced the problem. The attached patch corrects it. -Tom -- Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
On 05/11/2011 09:58 PM, Tom Eastep wrote:> On 05/11/2011 12:43 PM, Tom Eastep wrote: >> On 05/11/2011 12:06 PM, Togan Muftuoglu wrote: >>> Hi, >>> >>> On 04/17/2011 09:53 PM, Tom Eastep wrote: >>>> >>>> On Apr 17, 2011, at 8:02 AM, Tom Eastep wrote: >>>>> Unfortunately, I''ve had to reverse the patch because it is incomplete: >>>>> >>>>> a) It only modifies the installers. >>>>> b) It does not make similar modifications to the uninstallers. >>>>> c) More importantly, it doesn''t modify the code that actually uses the >>>>> LIBEXEC setting. So: >>>>> >>>>> - /sbin/shorewall and /sbin/shorewall6 can''t find compiler.pl >>>>> - /sbin/shorewall and /sbin/shorewall6 can''t find shorecaps on >>>>> a remote firewall that runs the corresponding -lite package. >>>>> >>>> I think I have it now. Commit is cdf2014ce21996c9fa6410501adcf297d8bb6911 >>> >>> When I backport this commit to current 4.4.19.3 shorewall6 doesn''t start >>> and gives the following error >>> >>> /sbin/shorewall6: Error in line 306: >>> PERL5LIB=/usr/lib/perl5/vendor_perl/5.12.1: No such file or directory >>> >>> >>> However shorewall starts with no errors. >>> >>> Any ideas ? >>> >> >> What is g_libexec being set to in /sbin/shorewall? > > Nevermind -- I have reproduced the problem. The attached patch corrects it. >I still have the same error message with shorewall6 however correcting shorewall6 as follows enables the startup of /sbin/shorewall6 without errors Thanks Togan --- shorewall6.orig +++ shorewall6 @@ -303,7 +303,8 @@ compiler() { if [ $g_perllib = /usr/share/shorewall ]; then $command $PERL $debugflags $pc $options $@ else - $command PERL5LIB=$g_perllib $PERL $debugflags $pc $options $@ + export PERL5LIB=$g_perllib + $command $PERL $debugflags $pc $options $@ fi } ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay
On May 11, 2011, at 2:17 PM, Togan Muftuoglu wrote:> > I still have the same error message with shorewall6 however correcting > shorewall6 as follows enables the startup of /sbin/shorewall6 without errors> --- shorewall6.orig > +++ shorewall6 > @@ -303,7 +303,8 @@ compiler() { > if [ $g_perllib = /usr/share/shorewall ]; then > $command $PERL $debugflags $pc $options $@ > else > - $command PERL5LIB=$g_perllib $PERL $debugflags $pc $options $@ > + export PERL5LIB=$g_perllib > + $command $PERL $debugflags $pc $options $@ > fi > }Thanks. To satisfy the Debian police, I''ll need to separate the assignment of PERL65LIB from its export. @@ -301,9 +301,11 @@ compiler() { fi if [ $g_perllib = share/shorewall ]; then - $command $PERL $debugflags $pc $options $@ + $PERL $debugflags $pc $options $@ else - $command PERL5LIB=$g_perllib $PERL $debugflags $pc $options $@ + PERL5LIB=$g_perllib + export PERL5LIB + $command $PERL $debugflags $pc $options $@ fi } -Tom Tom Eastep \ When I die, I want to go like my Grandfather who Shoreline, \ died peacefully in his sleep. Not screaming like Washington, USA \ all of the passengers in his car http://shorewall.net \________________________________________________ ------------------------------------------------------------------------------ Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay