search for: zyngier

.../0x78) [ 31.142909] [<c02902d0>] (free_irq) from [<c059d3a8>] (vp_del_vqs+0x68/0x1c0) [ 31.146299] [<c059d3a8>] (vp_del_vqs) from [<c056ca4c>] (pci_device_shutdown+0x3c/0x78) The obvious fix is to drop the affinity hint before freeing the interrupt. Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> --- drivers/virtio/virtio_pci_common.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index df548a6fb844..5a84f8207c02 100644 --- a/drivers/virtio/virtio_pci_common...

.../0x78) [ 31.142909] [<c02902d0>] (free_irq) from [<c059d3a8>] (vp_del_vqs+0x68/0x1c0) [ 31.146299] [<c059d3a8>] (vp_del_vqs) from [<c056ca4c>] (pci_device_shutdown+0x3c/0x78) The obvious fix is to drop the affinity hint before freeing the interrupt. Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> --- drivers/virtio/virtio_pci_common.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c index df548a6fb844..5a84f8207c02 100644 --- a/drivers/virtio/virtio_pci_common...

...Force use of DMA API for ARM-based systems with legacy devices") Reported-by: Robin Murphy <robin.murphy at arm.com> Cc: <stable at vger.kernel.org> Signed-off-by: Will Deacon <will.deacon at arm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Marc Zyngier <marc.zyngier at arm.com> --- I'll merge this for 4.10. Let's fix it properly for 4.11. drivers/virtio/virtio_ring.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 7e38ed7..409aeaa 100644 --- a/drivers/vir...

...Force use of DMA API for ARM-based systems with legacy devices") Reported-by: Robin Murphy <robin.murphy at arm.com> Cc: <stable at vger.kernel.org> Signed-off-by: Will Deacon <will.deacon at arm.com> Signed-off-by: Michael S. Tsirkin <mst at redhat.com> Acked-by: Marc Zyngier <marc.zyngier at arm.com> --- I'll merge this for 4.10. Let's fix it properly for 4.11. drivers/virtio/virtio_ring.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 7e38ed7..409aeaa 100644 --- a/drivers/vir...

On Wed, Mar 08, 2017 at 08:09:27AM +0000, Marc Zyngier wrote: > virtio-pci registers a per-vq affinity hint when using MSIX, > but fails to remove it when freeing the interrupt, resulting > in this type of splat: > > [ 31.111202] WARNING: CPU: 0 PID: 2823 at kernel/irq/manage.c:1503 __free_irq+0x2c4/0x2c8 > [ 31.114689] Modules l...

...d (by virtue of the registers to follow the endianess of the guest). Fix it by encoding the magic as an integer instead of a string. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Pawel Moll <pawel.moll at arm.com> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> --- So I'm not completely sure this is the right fix, and I can imagine other ways to cure the problem: - Reading the MAGIC register byte by byte. Is that allowed? The spec only says it is 32bit wide. - Using __raw_readl() instead. Is that a generic enough API?...

...d (by virtue of the registers to follow the endianess of the guest). Fix it by encoding the magic as an integer instead of a string. Cc: Rusty Russell <rusty at rustcorp.com.au> Cc: Michael S. Tsirkin <mst at redhat.com> Cc: Pawel Moll <pawel.moll at arm.com> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> --- So I'm not completely sure this is the right fix, and I can imagine other ways to cure the problem: - Reading the MAGIC register byte by byte. Is that allowed? The spec only says it is 32bit wide. - Using __raw_readl() instead. Is that a generic enough API?...

...d machines, the DMA ops will do the right thing, > + * so always use them with legacy devices. > + */ > + if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) > + return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1); > + > return false; > } > > Acked-by: Marc Zyngier <marc.zyngier at arm.com> Any chance this fix (or anything with similar effects) gets applied sometime soon? I cannot use the model without using a similar workaround: http://git.kernel.org/cgit/linux/kernel/git/maz/arm-platforms.git/commit/?h=kvm-arm64/gicv4-wip&id=622ff1190890c0ae60d5...

...d machines, the DMA ops will do the right thing, > + * so always use them with legacy devices. > + */ > + if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) > + return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1); > + > return false; > } > > Acked-by: Marc Zyngier <marc.zyngier at arm.com> Any chance this fix (or anything with similar effects) gets applied sometime soon? I cannot use the model without using a similar workaround: http://git.kernel.org/cgit/linux/kernel/git/maz/arm-platforms.git/commit/?h=kvm-arm64/gicv4-wip&id=622ff1190890c0ae60d5...

...(vp_dev->per_vq_vectors) { f6813487d drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 231 int v = vp_dev->vqs[vq->index]->msix_vector; fa3a32793 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 232 e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 233 if (v != VIRTIO_MSI_NO_VECTOR) { e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 234 int irq = pci_irq_vector(vp_dev->pci_dev, v); e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 235 e1c287efc drivers/virtio...

...(vp_dev->per_vq_vectors) { f6813487d drivers/virtio/virtio_pci_common.c Michael S. Tsirkin 2017-04-04 231 int v = vp_dev->vqs[vq->index]->msix_vector; fa3a32793 drivers/virtio/virtio_pci_common.c Christoph Hellwig 2016-11-17 232 e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 233 if (v != VIRTIO_MSI_NO_VECTOR) { e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 234 int irq = pci_irq_vector(vp_dev->pci_dev, v); e1c287efc drivers/virtio/virtio_pci_common.c Marc Zyngier 2017-03-08 235 e1c287efc drivers/virtio...

On Tue, Jan 24, 2017 at 04:04:11PM +0000, Marc Zyngier wrote: > On 20/01/17 10:33, Will Deacon wrote: > > On Thu, Jan 19, 2017 at 11:51:06PM +0200, Michael S. Tsirkin wrote: > >> On Mon, Jan 16, 2017 at 02:34:08PM +0000, Will Deacon wrote: > >>> On Mon, Jan 16, 2017 at 04:27:28PM +0200, Michael S. Tsirkin wrote: > >&...

On Thu, 28 Feb 2019 08:16:05 +0000, Greg KH <gregkh at linuxfoundation.org> wrote: Hi both, > > On Wed, Feb 27, 2019 at 04:36:39PM -0800, Daniel Verkamp wrote: > > Hello, > > > > In my testing of crosvm[1] with Linux 4.4.175, I am observing failures > > on a 'kevin' Chromebook (RK3399) device - the guest kernel does not > > even get to the

On Thu, 28 Feb 2019 08:16:05 +0000, Greg KH <gregkh at linuxfoundation.org> wrote: Hi both, > > On Wed, Feb 27, 2019 at 04:36:39PM -0800, Daniel Verkamp wrote: > > Hello, > > > > In my testing of crosvm[1] with Linux 4.4.175, I am observing failures > > on a 'kevin' Chromebook (RK3399) device - the guest kernel does not > > even get to the

Hi all, this small patch series implement guest SMP support for ARM, using the ARM PSCI interface for secondary cpu bringup. Stefano Stabellini (4): xen/arm: basic PSCI support, implement cpu_on xen/arm: support for guest SGI xen/arm: support vcpu_op hypercalls xen: move VCPUOP_register_vcpu_info to common code xen/arch/arm/domain.c | 66 ++++++++++++++++++++++++

...; -----Original Message----- > From: Yijing Wang [mailto:wangyijing at huawei.com] > Sent: Saturday, July 26, 2014 8:39 AM > To: linux-kernel at vger.kernel.org > Cc: Xinwei Hu; Wuyun; Bjorn Helgaas; linux-pci at vger.kernel.org; > Paul.Mundt at huawei.com; James E.J. Bottomley; Marc Zyngier; linux-arm- > kernel at lists.infradead.org; Russell King; linux-arch at vger.kernel.org; > Basu Arnab-B45036; virtualization at lists.linux-foundation.org; Hanjun Guo; > Yijing Wang > Subject: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device > > Hi all, > The series...

...; -----Original Message----- > From: Yijing Wang [mailto:wangyijing at huawei.com] > Sent: Saturday, July 26, 2014 8:39 AM > To: linux-kernel at vger.kernel.org > Cc: Xinwei Hu; Wuyun; Bjorn Helgaas; linux-pci at vger.kernel.org; > Paul.Mundt at huawei.com; James E.J. Bottomley; Marc Zyngier; linux-arm- > kernel at lists.infradead.org; Russell King; linux-arch at vger.kernel.org; > Basu Arnab-B45036; virtualization at lists.linux-foundation.org; Hanjun Guo; > Yijing Wang > Subject: [RFC PATCH 00/11] Refactor MSI to support Non-PCI device > > Hi all, > The series...

Hi all, this patch series introduces stolen ticks accounting for Xen on ARM. Stolen ticks are clocksource ticks that have been "stolen" from the cpu, typically because Linux is running in a virtual machine and the vcpu has been descheduled. To account for these ticks we introduce CONFIG_PARAVIRT and pv_time_ops so that we can make use of:

...o do this without loosing automatic interrupt NUMA affinity which was the main motivator for the rework. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Cornelia Huck (1): MAINTAINERS: fix virtio file pattern Marc Zyngier (1): virtio-pci: Remove affinity hint before freeing the interrupt Michael S. Tsirkin (9): virtio_net: enable big packets for large MTU values virtio: allow drivers to validate features virtio_net: clear MTU when out of range virtio_console: fix uninitialized variable...

...o do this without loosing automatic interrupt NUMA affinity which was the main motivator for the rework. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Cornelia Huck (1): MAINTAINERS: fix virtio file pattern Marc Zyngier (1): virtio-pci: Remove affinity hint before freeing the interrupt Michael S. Tsirkin (9): virtio_net: enable big packets for large MTU values virtio: allow drivers to validate features virtio_net: clear MTU when out of range virtio_console: fix uninitialized variable...