search for: zturner

By that logic we shouldn't have an 80 column limit in LLVM :) On Wed, Apr 8, 2015 at 3:35 PM Sean Silva <chisophugis at gmail.com> wrote: > On Wed, Apr 8, 2015 at 1:32 PM, Zachary Turner <zturner at google.com> wrote: > >> When the line is like 400 characters, it's pretty obnoxious. >> > > > I guess I'd need to see the particular situation, but in my experience > most editors will wrap the line for you in a reasonable-enough way. > > -- Sean Silva...

When the line is like 400 characters, it's pretty obnoxious. On Wed, Apr 8, 2015 at 1:32 PM Sean Silva <chisophugis at gmail.com> wrote: > On Wed, Apr 8, 2015 at 1:19 PM, Zachary Turner <zturner at google.com> wrote: > >> Just found another issue with CMake versions prior to 3.0. I need to >> write a long string, and prior to 3.0 there is no line continuation for >> quoted arguments. This might seem minor, but it's one of those things that >> when you ne...

...ob/clang-stage1-configure-RA/40391/> > > Update test_debuginfo.pl script to point to new tree location. (detail <http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/40391/changes#detail0>/ViewSVN <http://llvm.org/viewvc/llvm-project/?view=rev&rev=317949>) > by zturner <http://green.lab.llvm.org/green/user/zturner/> > -- adrian > >> On Nov 13, 2017, at 3:21 PM, Zachary Turner <zturner at google.com <mailto:zturner at google.com>> wrote: >> >> On the other hand this file hasn't changed recently, but I have no way to...

On the other hand this file hasn't changed recently, but I have no way to test this as it uses the LLDB code path, which only runs on OSX. On Mon, Nov 13, 2017 at 3:19 PM Zachary Turner <zturner at google.com> wrote: > I might be missing something, but this doesn't look like me? > > > http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/40478/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561 > > PASS: debuginfo-tests :: dbg-arg.c (34886 of 40729)...

> On Nov 10, 2017, at 2:50 PM, Zachary Turner <zturner at google.com> wrote: > > I checked in a fix for that already, sorry for the trouble. I’m waiting for it to cycle awesome. Thanks! -- adrian > On Fri, Nov 10, 2017 at 2:49 PM Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > It looks like th...

I've verified that none of the files I tried to check in had Windows-style line endings. It's something else. --paulr From: vsk at apple.com [mailto:vsk at apple.com] On Behalf Of Vedant Kumar Sent: Thursday, November 22, 2018 9:38 AM To: Robinson, Paul Cc: zturner at google.com; jyknight at google.com; llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] 'git llvm push' not working for me on Windows As a test case, try committing a change to clang/test/SemaCXX/sourceranges.cpp? I believe most editors force Windows-style line endings for that file (th...

...te: > > > > Yes I can reproduce this locally. It looks like we are not passing an > -isysroot (pointing to the SDK) to clang but it isn’t clear what lit magic > would expand this. > > > > -- adrian > > > >> On Nov 13, 2017, at 3:30 PM, Zachary Turner <zturner at google.com> wrote: > >> > >> Yea I'm preparing a revert right now. Does it happen for you when you > run debuginfo-tests locally? > >> > >> On Mon, Nov 13, 2017 at 3:28 PM Adrian Prantl <aprantl at apple.com> > wrote: > >> Since th...

Yes I can reproduce this locally. It looks like we are not passing an -isysroot (pointing to the SDK) to clang but it isn’t clear what lit magic would expand this. -- adrian > On Nov 13, 2017, at 3:30 PM, Zachary Turner <zturner at google.com> wrote: > > Yea I'm preparing a revert right now. Does it happen for you when you run debuginfo-tests locally? > > On Mon, Nov 13, 2017 at 3:28 PM Adrian Prantl <aprantl at apple.com <mailto:aprantl at apple.com>> wrote: > Since this is causing all...

> On Dec 6, 2017, at 10:10 AM, Zachary Turner <zturner at google.com> wrote: > > Adrian, Mike, Chris? Any update on this? I've temporarily switched to working on something different, but I plan to be back on this in a couple of weeks. It's been a month since my first revert of this CL, which seems like a reasonable amount of lead-t...

> On Dec 6, 2017, at 10:21 AM, Zachary Turner <zturner at google.com> wrote: > > Can I have some assurance that if it fails again, someone will look into who has access to the builders so I don't have to keep doing speculative commits? Sure. I did this last time and I promise to also do it this time. -- adrian > > On Wed, Dec 6,...

...gt;> Windows-style line endings. It's something else. >> >> --paulr >> >> >> >> *From:* vsk at apple.com [mailto:vsk at apple.com] *On Behalf Of *Vedant Kumar >> *Sent:* Thursday, November 22, 2018 9:38 AM >> *To:* Robinson, Paul >> *Cc:* zturner at google.com; jyknight at google.com; llvm-dev at lists.llvm.org >> *Subject:* Re: [llvm-dev] 'git llvm push' not working for me on Windows >> >> >> >> As a test case, try committing a change to >> clang/test/SemaCXX/sourceranges.cpp? >> >> &...

...ome control over the bits > that determine whether I'm able to make forward progress. > > If and when someone on the Apple side has some time to make this work with > their build infrastructure, I will be happy to revisit. > > On Mon, Nov 13, 2017 at 4:44 PM Zachary Turner <zturner at google.com> wrote: > >> Great! It's close to the end of the day, so I'll submit tomorrow to make >> sure everything has a chance to go fully green again to ensure I get >> failure emails if it breaks. >> >> On Mon, Nov 13, 2017 at 4:43 PM Adrian Prant...

FTR the commit where it failed for me had both llvm and clang changes. I wonder if that contributed. --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of via llvm-dev Sent: Monday, November 19, 2018 6:01 PM To: zturner at google.com; jyknight at google.com Cc: llvm-dev at lists.llvm.org Subject: Re: [llvm-dev] 'git llvm push' not working for me on Windows Hm. Just now it worked for me for r347271. If it happens again I'll try verbose mode and attach a log. Thanks, --paulr From: Zachary Turner [mai...

...thing has a chance to go fully green again to ensure I get failure emails if it breaks. On Mon, Nov 13, 2017 at 4:43 PM Adrian Prantl <aprantl at apple.com> wrote: > I can confirm that that fixes the issue! > > — adrian > > > On Nov 13, 2017, at 4:38 PM, Zachary Turner <zturner at google.com> wrote: > > Yea I also just found it. Try adding this code in the bottom of > debuginfo-tests/lit.cfg.py > > lit.util.usePlatformSdkOnDarwin(config, lit_config) > > > On Mon, Nov 13, 2017 at 4:38 PM Adrian Prantl <aprantl at apple.com> wrote: > &gt...

...m-dev at lists.llvm.org> wrote: > > This is in as of r317925. I'm keeping an eye out for failure notifications. I may or may not need help diagnosing if something does go wrong (although I'm keeping my fingers crossed) > > On Thu, Nov 9, 2017 at 4:05 PM Zachary Turner <zturner at google.com> wrote: > Since it's towards the end of the day already, I'll put this in tomorrow morning around 9 or 10, to make sure I'm around to fix anything that arises (or revert). > > > > On Thu, Nov 9, 2017 at 2:53 PM Mike Edwards <medwards at apple.com&gt...

Yes, -Tllvm works. [cid:image002.jpg at 01D4CCF6.C440CFF0] From: Zachary Turner <zturner at google.com> Sent: Monday, February 25, 2019 10:36 AM To: Leonardo Santagada <santagada at gmail.com> Cc: Alexandre Ganea <alexandre.ganea at ubisoft.com>; Reid Kleckner <rnk at google.com>; llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] Making LLD PDB ge...

On Thu, Sep 7, 2017 at 11:41 AM Adrian Prantl <aprantl at apple.com> wrote: > > > On Sep 7, 2017, at 11:23 AM, Zachary Turner <zturner at google.com> wrote: > > How do you run it? > > The repository is supposed to be cloned into llvm/tools/clang/test and > will then appear as part of check-clang. > > > It doesn't appear to be based on lit, any particular reason? > > It is most definitely ba...

It looks like the bots are still red? — Adrian > On Nov 10, 2017, at 3:14 PM, Zachary Turner <zturner at google.com> wrote: > > Wasn't quite fixed, but it got a lot further this time. This time there was still an issue in the test_debuginfo.pl <http://test_debuginfo.pl/> script regarding a hardcoded path to the llgdb.py script. I think I never encountered this locally because...

...;> --paulr >>>> >>>> >>>> >>>> *From:* vsk at apple.com [mailto:vsk at apple.com] *On Behalf Of *Vedant >>>> Kumar >>>> *Sent:* Thursday, November 22, 2018 9:38 AM >>>> *To:* Robinson, Paul >>>> *Cc:* zturner at google.com; jyknight at google.com; llvm-dev at lists.llvm.org >>>> *Subject:* Re: [llvm-dev] 'git llvm push' not working for me on Windows >>>> >>>> >>>> >>>> As a test case, try committing a change to >>>> clang/te...

...carried when obj2yaml writes a file, and that the layout function on yaml2coff does generate different indexes to the sections, none that look wrong, but it seems that it leaves some padding, but I didn't have time to look to closely at why. On Fri, Jan 26, 2018 at 6:52 PM, Zachary Turner <zturner at google.com> wrote: > Hmm, ok. In that case let me try again without my local changes. Maybe > they are getting in the way :-/ > > > On Fri, Jan 26, 2018 at 9:51 AM Leonardo Santagada <santagada at gmail.com> > wrote: > >> it is identical to me... wierd. &gt...