search for: zsbuf

This patch series silences some unknown cap warnings and fixes up coding style (patch 1+4). The most important part of this series are the two patches in the middle. They rework the state_fb code, so that we are able to render to not 64 byte aligned targets, as this is the only real use-case for render temporaries this allows us to drop temp code completely and simplifies a lot

...+42,45 @@ nv50_clear(struct pipe_context *pipe, struct pipe_surface *ps, struct pipe_scissor_state sc, s_sc = nv50->scissor; unsigned dirty = nv50->dirty; + /* if 'no buffers' case is possible, change this to if/return */ + assert(buffers && (s_fb.nr_cbufs > 0 || s_fb.zsbuf != NULL)); + nv50->dirty = 0; + fb.nr_cbufs = 0; - if (ps->format == PIPE_FORMAT_Z24S8_UNORM || - ps->format == PIPE_FORMAT_Z16_UNORM) { - fb.nr_cbufs = 0; - fb.zsbuf = ps; + if (buffers & PIPE_CLEAR_COLOR) { + /* Should we clear all color buffers (nv40 doesn't), clear_wi...

Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/gallium/drivers/nouveau/nv30/nv30_screen.c | 33 +++++++++++++------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c index 4baabaf..5c3d783 100644 --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c +++

https://bugs.freedesktop.org/show_bug.cgi?id=92306 Bug ID: 92306 Summary: GL Excess demo renders incorrectly on nv43 Product: Mesa Version: git Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/nouveau Assignee: nouveau

...b/src/mesa/state_tracker/st_atom_framebuffer.c @@ -177,8 +177,10 @@ update_framebuffer_state( struct st_context *st ) /* rendering to a GL texture, may have to update surface */ st_update_renderbuffer_surface(st, strb); } - pipe_surface_reference(&framebuffer->zsbuf, strb->surface); - update_framebuffer_size(framebuffer, strb->surface); + if (strb->surface) { + pipe_surface_reference(&framebuffer->zsbuf, strb->surface); + update_framebuffer_size(framebuffer, strb->surface); + } } else { strb = st...

https://bugs.freedesktop.org/show_bug.cgi?id=48742 Bug #: 48742 Summary: fbotexture -arb misrenders on nv43 Classification: Unclassified Product: Mesa Version: git Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/nouveau

...tatic INLINE enum pipe_format nv50_blit_zeta_to_colour_format(enum pipe_format format) Getting rid of that conversion naturally breaks stuff... by also hacking up nv50_blit_select_mode, I can restore it to a very similar broken mode as without the hackery (adding further hackery to force it to use zsbuf instead of cbuf breaks everything, but I suspect even more hackery could be performed to make it work). Unfortunately I don't know enough about this storage type business, and what effect it has on things like render targets, esp if you're lying about the type (i.e. it's trying to rende...

...EGIN_RING(chan, tesla, NV50TCL_CLEAR_COLOR(0), 4); + OUT_RING (chan, fui(rgba[0])); + OUT_RING (chan, fui(rgba[1])); + OUT_RING (chan, fui(rgba[2])); + OUT_RING (chan, fui(rgba[3])); + mode |= NV50TCL_CLEAR_COLOR_BITS(0); } if (buffers & PIPE_CLEAR_DEPTHSTENCIL) { + assert(fb->zsbuf != NULL); BEGIN_RING(chan, tesla, NV50TCL_CLEAR_DEPTH, 1); OUT_RING (chan, fui(depth)); BEGIN_RING(chan, tesla, NV50TCL_CLEAR_STENCIL, 1); OUT_RING (chan, stencil & 0xff); - - mode |= 0x03; + mode |= NV50TCL_CLEAR_DEPTH_STENCIL_BITS; } + assert(mode != 0); + BEGIN_RING(chan...

This CAP will determine whether ARB_framebuffer_object can be enabled. The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf textures. Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> --- src/gallium/docs/source/screen.rst | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c...

...lia Mirkin <imirkin at alum.mit.edu> wrote: > ping > > On Fri, Oct 4, 2013 at 4:32 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: >> This CAP will determine whether ARB_framebuffer_object can be enabled. >> The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf >> textures. >> >> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> >> --- >> src/gallium/docs/source/screen.rst | 3 +++ >> src/gallium/drivers/freedreno/freedreno_screen.c | 1 + >> src/gallium/drivers/i915/i915_screen.c...

https://bugs.freedesktop.org/show_bug.cgi?id=92922 Bug ID: 92922 Summary: Xorg random freeze Product: xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major Priority: medium Component: Driver/nouveau Assignee: nouveau at

ping On Fri, Oct 4, 2013 at 4:32 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: > This CAP will determine whether ARB_framebuffer_object can be enabled. > The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf > textures. > > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> > --- > src/gallium/docs/source/screen.rst | 3 +++ > src/gallium/drivers/freedreno/freedreno_screen.c | 1 + > src/gallium/drivers/i915/i915_screen.c | 1 + > src/galliu...

...in at alum.mit.edu> wrote: >> ping >> >> On Fri, Oct 4, 2013 at 4:32 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote: >>> This CAP will determine whether ARB_framebuffer_object can be enabled. >>> The nv30 driver does not allow mixing swizzled and linear zsbuf/cbuf >>> textures. >>> >>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu> >>> --- >>> src/gallium/docs/source/screen.rst | 3 +++ >>> src/gallium/drivers/freedreno/freedreno_screen.c | 1 + >>> src/gallium/dri...

OK, so there's a bunch of stuff in here. The geometry stuff is based on the work started by Bryan Cain and Christoph Bumiller. Patches 01-12: Add support for geometry shaders and fix related issues Patches 13-14: Make it possible for fb clears to operate on texture attachments with an explicit layer set (as is allowed in gl 3.2). Patches 15-17: Make ARB_texture_multisample work

...ouveau at lists.freedesktop.org Created attachment 142101 --> https://bugs.freedesktop.org/attachment.cgi?id=142101&action=edit glxinfo Every OpenGL application that wants to use a depth buffer always crashes, including glxgears: glxgears: dri2.c:906: dri2_allocate_textures: Assertion `*zsbuf' failed. I debugged the assertion with gdb: templ structure contents passed to resource_create(): $2 = {reference = {count = 0}, width0 = 300, height0 = 300, depth0 = 1, array_size = 1, format = PIPE_FORMAT_Z24X8_UNORM, target = PIPE_TEXTURE_2D, last_level = 0, nr_samples = 0, nr_storage_sa...

...+ > + for (i = 0; i < fb->nr_cbufs; i++) > + state.cbufs[i] = tegra_surface_unwrap(fb->cbufs[i]); > + > + while (i < PIPE_MAX_COLOR_BUFS) > + state.cbufs[i++] = NULL; > + > + state.zsbuf = tegra_surface_unwrap(fb->zsbuf); > + > + fb = &state; > + } > + > + context->gpu->set_framebuffer_state(context->gpu, fb); > +} > + > +static void > +tegra_set_polygon_stipple(struct pipe_context *pcontext, > +...

http://bugs.freedesktop.org/show_bug.cgi?id=23505 Summary: KDE's Kubrick has problems with xf86-video-nouveau driver Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/nouveau AssignedTo: nouveau at

...xt); + struct pipe_framebuffer_state state; + unsigned i; + + if (fb) { + memcpy(&state, fb, sizeof(state)); + + for (i = 0; i < fb->nr_cbufs; i++) + state.cbufs[i] = tegra_surface_unwrap(fb->cbufs[i]); + + while (i < PIPE_MAX_COLOR_BUFS) + state.cbufs[i++] = NULL; + + state.zsbuf = tegra_surface_unwrap(fb->zsbuf); + + fb = &state; + } + + context->gpu->set_framebuffer_state(context->gpu, fb); +} + +static void +tegra_set_polygon_stipple(struct pipe_context *pcontext, + const struct pipe_poly_stipple *stipple) +{ + struct tegra_context *context = to_tegr...

...u/nvc0/nvc0_state_validate.c @@ -130,7 +130,7 @@ nvc0_validate_fb(struct nvc0_context *nvc0) PUSH_DATA(push, 0); PUSH_DATA(push, 0); - nvc0_resource_fence(res, NOUVEAU_BO_WR); + nvc0_resource_fence(nvc0, res, NOUVEAU_BO_WR); assert(!fb->zsbuf); } @@ -523,8 +523,10 @@ nvc0_switch_pipe_context(struct nvc0_context *ctx_to) struct nvc0_context *ctx_from = ctx_to->screen->cur_ctx; unsigned s; - if (ctx_from) + if (ctx_from) { + PUSH_KICK(ctx_from->base.pushbuf); ctx_to->state = ctx_from->stat...

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- src/gallium/drivers/nouveau/nouveau_fence.c | 76 ++++++++++++------------- src/gallium/drivers/nouveau/nouveau_fence.h | 22 +++++-- src/gallium/drivers/nouveau/nouveau_screen.c | 9 +++ src/gallium/drivers/nouveau/nouveau_screen.h | 14 ++--- src/gallium/drivers/nouveau/nv30/nv30_context.c | 4 +-