search for: zern

Just an attempt to avoid overflows with an explicit check, I don't know if there's a better way to identify corrupt input here. James Zern (2): op_pcm_seek: fix int64 overflow op_fetch_and_process_page: fix int64 overflow src/opusfile.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.15.0.448.gf294e3d99a-goog

On Tue, Nov 28, 2017 at 3:22 PM, James Zern <jzern at google.com> wrote: > On Mon, Nov 20, 2017 at 1:07 PM, James Zern <jzern at google.com> wrote: >> Just an attempt to avoid overflows with an explicit check, I don't know if >> there's a better way to identify corrupt input here. >> >> James Ze...

James Zern wrote: > On Tue, Nov 28, 2017 at 3:22 PM, James Zern <jzern at google.com> wrote: >> On Mon, Nov 20, 2017 at 1:07 PM, James Zern <jzern at google.com> wrote: >>> Just an attempt to avoid overflows with an explicit check, I don't know if >>> there's a b...

r+ with James' fix. On 12/07/17 02:01 PM, James Zern wrote: > On Wed, Jul 12, 2017 at 10:58 AM, Felicia Lim <flim at google.com> wrote: >> |frame_size_enum| in tests/test_opus_encode.cl:117 is flagged as potentially >> uninitialized but get_frame_size_enum() will fail anyway if a valid value is >> not found. >> --- &g...

On Mon, Nov 20, 2017 at 1:07 PM, James Zern <jzern at google.com> wrote: > Just an attempt to avoid overflows with an explicit check, I don't know if > there's a better way to identify corrupt input here. > > James Zern (2): > op_pcm_seek: fix int64 overflow > op_fetch_and_process_page: fix int64 overflow...

This allows a clean build when using -Werror and the mentioned 'gcc -m32 -std=gnu90'. -------------- next part --------------

and rtcd disabled (CFLAGS=-mfpu=neon) broken since: cfdaf365 Optimize silk_NSQ_del_dec() for ARM NEON --- silk/arm/NSQ_del_dec_arm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/silk/arm/NSQ_del_dec_arm.h b/silk/arm/NSQ_del_dec_arm.h index c62b5055..9e76e169 100644 --- a/silk/arm/NSQ_del_dec_arm.h +++ b/silk/arm/NSQ_del_dec_arm.h @@ -43,7 +43,6 @@ void

|frame_size_enum| in tests/test_opus_encode.cl:117 is flagged as potentially uninitialized but get_frame_size_enum() will fail anyway if a valid value is not found. --- tests/test_opus_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_opus_common.h b/tests/test_opus_common.h index ff7f0142..8b878607 100644 --- a/tests/test_opus_common.h +++ b/tests/test_opus_common.h @@

On Thu, Dec 7, 2017 at 12:18 PM, Timothy B. Terriberry <tterribe at xiph.org> wrote: > [...] > > Sorry, I can't reply to the original patches because I didn't actually get > that e-mail due to local trouble with my mail server. I could pull the > patches from the list archive, however. Thanks for the reports. > Thanks for recovering them and having a look. I

On Wed, Jul 12, 2017 at 10:58 AM, Felicia Lim <flim at google.com> wrote: > |frame_size_enum| in tests/test_opus_encode.cl:117 is flagged as potentially > uninitialized but get_frame_size_enum() will fail anyway if a valid value is > not found. > --- > tests/test_opus_common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/test_opus_common.h

check for overflow with a negative diff --- src/opusfile.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/opusfile.c b/src/opusfile.c index 72f1272..df326af 100644 --- a/src/opusfile.c +++ b/src/opusfile.c @@ -2605,7 +2605,11 @@ int op_pcm_seek(OggOpusFile *_of,ogg_int64_t _pcm_offset){ would be better just to do a full seek.*/

check for overflow with a negative diff --- src/opusfile.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/opusfile.c b/src/opusfile.c index df326af..2bef277 100644 --- a/src/opusfile.c +++ b/src/opusfile.c @@ -2078,7 +2078,10 @@ static int op_fetch_and_process_page(OggOpusFile *_of, &&OP_LIKELY(diff<total_duration)){