search for: zelenko

> On Sep 7, 2016, at 4:50 PM, Joerg Sonnenberger via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On Wed, Sep 07, 2016 at 04:30:01PM -0700, Eugene Zelenko via llvm-dev wrote: >> What should be used for type declarations: typedef or using? typedef >> is there because of historical reasons, but LLVM code based is C++11 >> now. >> >> LLVM Coding Standards are not clear on this matter. > > Can you give some context f...

2017-05-02 0:50 GMT+02:00 Eugene Zelenko via llvm-dev <llvm-dev at lists.llvm.org>: > On Mon, May 1, 2017 at 3:27 PM, Michael Kruse <llvmdev at meinersbur.de> wrote: >> 2017-05-01 20:16 GMT+02:00 Eugene Zelenko via llvm-dev >> <llvm-dev at lists.llvm.org>: >>> Hi, Hongbin! >>> >>&gt...

2017-04-29 0:49 GMT+02:00 Eugene Zelenko via llvm-dev <llvm-dev at lists.llvm.org>: > Hi! > > I encounter problem with Polly build (in-tree, libraries are linked > statically). It appeared ~ 2 days agor for first time. > > include/llvm/IR/Attributes.h:73:14: fatal error: > 'llvm/IR/Attributes.gen' file n...

2017-05-01 20:16 GMT+02:00 Eugene Zelenko via llvm-dev <llvm-dev at lists.llvm.org>: > Hi, Hongbin! > > On Mon, May 1, 2017 at 11:06 AM, Hongbin Zheng <etherzhhb at gmail.com> wrote: >> Hi Eugene, >> >> It is strange, I also do a clean build with CMake+make with r301734 and it >> is ok. Could yo...

Hi! What should be used for type declarations: typedef or using? typedef is there because of historical reasons, but LLVM code based is C++11 now. LLVM Coding Standards are not clear on this matter. Eugene. Clang-tidy has modernize-use-using, but fix-it functionality is not perfect (https://llvm.org/bugs/show_bug.cgi?id=28334).

Hi! If I'm not mistaken old makefiles are not supported in 3.8. If this is a case, i think till be good idea to remove them before 3.8 branching. Eugene.

Hi! I encounter problem with Polly build (in-tree, libraries are linked statically). It appeared ~ 2 days agor for first time. include/llvm/IR/Attributes.h:73:14: fatal error: 'llvm/IR/Attributes.gen' file not found #include "llvm/IR/Attributes.gen" It seems that dependencies on IR are not set properly. Eugene.

Hi Eugene, It is strange, I also do a clean build with CMake+make with r301734 and it is ok. Could you provide more details? Thanks Hongbin On Mon, May 1, 2017 at 10:58 AM, Eugene Zelenko via llvm-dev < llvm-dev at lists.llvm.org> wrote: > Hi, Michael! > > On Sun, Apr 30, 2017 at 2:06 PM, Michael Kruse <llvmdev at meinersbur.de> > wrote: > > 2017-04-29 0:49 GMT+02:00 Eugene Zelenko via llvm-dev < > llvm-dev at lists.llvm.org>: > >> Hi...

...o cmake. Having an extra couple of weeks would be really useful. Philip On 01/07/2016 10:54 AM, Eric Christopher via llvm-dev wrote: > They're deprecated in 3.8. Chris and I are making plans for when > (after branch) the removal happens. > > On Thu, Jan 7, 2016, 10:44 AM Eugene Zelenko via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > Hi! > > If I'm not mistaken old makefiles are not supported in 3.8. If this is > a case, i think till be good idea to remove them before 3.8 branching. > >...

Hi! compiler-rt's CMakeLists.txt still contains tweaks for CMake version 2.8. Pre-2.8.12 are definitely irrelevant for CMake 3.4.3, but may be post-2.8.12 tweaks are irrelevant too? Eugene.

Hi! There is surge of spam bug reports with support phone numbers of various companies. I remember couple of such reports made ~ 2-3 weeks ago. I think will be good idea to block IP-addresses or their range, if Bugzilla support this, since a-mails are different. Eugene.

Hi! There are a lot of accepted but not closed revisions in Differential. Many of them were actually committed, but without Differential revision link or when it was specified in wrong way. I think will be good idea to create script which will match committed revisions with those in Differential: file list should be same and hashes of changed line could be calculated for each file. In case of

Hi! There were several new spam entries in Bugizlla, created from previously created accounts. I think will be good idea to delete them as well as block spammers accounts : Report IDs: 30192, 30191, 30187, 30186, 30185, 30182, 28766, 28717, 28715, 28714. Eugene.

Hi! This example currently uses pthread.h, but will be good idea to convert it to C++11 thread and synchronization objects. I think will be good idea if person who knows LLVM and C++1 better then me will take care about conversion. Eugene.

Hi! Company behind PVS-Studio analyzed relatively recent version of LLVM and some results are reported in http://www.viva64.com/en/b/0446/. Eugene.

...such that else makes the code more readable), we haven't gone back to do any cleanup of the codebase, but it's pretty consistently applied/desired in code review. I have a different impression: we are actively cleaning the codebase with tidy-checks. For instance look for `git log --author=Zelenko`. Another example is that a few months ago the entire LLDB codebase has been formatted with clang-format, after marking the specific places where it was not desirable (tables for instance) with comment to disable clang-format. — Mehdi > > All that said - sure, I'd like to have tools...

On Thu, Dec 29, 2016 at 10:04 AM Mehdi Amini via cfe-dev < cfe-dev at lists.llvm.org> wrote: > On Dec 29, 2016, at 5:54 AM, Daniel Berlin <dberlin at dberlin.org> wrote: > > > From yesterday discussion, Daniel Berlin proposed using emplace_back > everywhere to make code easier to maintain. I think it is valid argument, > but I believe it would reduce readability.

...p; have done so on several occasions as these sort of patches have been sent) & encourage efforts to provide the tools (like clang-tidy integration for patches and editors) to avoid mistakes going forward in an advisory (rather than mandatory) way. > For instance look for `git log --author=Zelenko`. > Another example is that a few months ago the entire LLDB codebase has been > formatted with clang-format, after marking the specific places where it was > not desirable (tables for instance) with comment to disable clang-format. > *nod* Only because it was so far out of LLVM's...

...Baranidharan Mohan, Benjamin Kramer, Bill >>> Wendling, Chandler Carruth, Craig Topper, Chris Jenneisch, Christian >>> Bielert, Daniel Dunbar, Daniel Jasper, David Blaikie, David Peixotto, >>> Dmitry N. Mikushin, Duncan P. N. Exon Smith, Eli Friedman, Eugene >>> Zelenko, George Burgess IV, Hans Wennborg, Hongbin Zheng, Huihui Zhang, >>> Jakub Kuderski, Johannes Doerfert, Justin Bogner, Karthik Senthil, Logan >>> Chien, Lawrence Hu, Mandeep Singh Grang, Matt Arsenault, Matthew >>> Simpson, Mehdi Amini, Micah Villmow, Michael Kruse, Matthi...

...r, Ajith Pandel, Baranidharan Mohan, >> Benjamin Kramer, BillWendling, Chandler Carruth, Craig Topper, Chris >> Jenneisch, ChristianBielert, Daniel Dunbar, Daniel Jasper, David >> Blaikie, David Peixotto,Dmitry N. Mikushin, Duncan P. N. Exon Smith, >> Eli Friedman, EugeneZelenko, George Burgess IV, Hans Wennborg, >> Hongbin Zheng, Huihui Zhang,Jakub Kuderski, Johannes Doerfert, Justin >> Bogner, Karthik Senthil, LoganChien, Lawrence Hu, Mandeep Singh >> Grang, Matt Arsenault, MatthewSimpson, Mehdi Amini, Micah Villmow, >> Michael Kruse, Matthias...