search for: zefan

I''ve noticed that: - with x86-64 Fedora 15 DVD install images: - du -sh <ROOT VOLUME> was 36 GB - btrfs df | grep -i data have shown over 40 GB used - without - du -sh <ROOT VOLUME> is 34 GB - btrfs df | grep -i data have shown less then 34 GB used It seems that iso files are considered compressable while they may not be (and penalty is severe - 3x). Regards

Kernel 3.1-rc8 btrfs-progs-0.19 mount options: noatime,autodefrag (space_cache is enabled) There are snapshots present on the filesystem. When I do a btrfs fi defrag on a file, the file becomes much more fragmented. The end result can be a file with 20k times more fragments than before. Initially I thought the extents were just smaller but were next to each other, so I checked with both

# uname -a Linux dhcppc1 3.0.1-xxxx-std-ipv6-64 #1 SMP Sun Aug 14 17:06:21 CEST 2011 x86_64 x86_64 x86_64 GNU/Linux mkdir test5 cd test5 dd if=/dev/null of=img5 bs=1 seek=2G dd if=/dev/null of=img6 bs=1 seek=2G losetup /dev/loop2 img5 losetup /dev/loop3 img6 mkfs.btrfs -d raid1 -m raid1 /dev/loop2 /dev/loop3 btrfs device scan btrfs filesystem show Label: none uuid:

It''s safe and easy to do so, provided the ranges don''t overlap. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/ioctl.c | 23 ++++++++++++++++------- 1 files changed, 16 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 0b06a5c..8fcd671 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2223,8 +2223,6 @@ static noinline lon...

...;'s a fix for on-disk free space cache. Others are small fixes and cleanups. The last three have been sent weeks ago. The patchset is also available in this repo: git://repo.or.cz/linux-btrfs-devel.git for-chris Note there''s a small confict with Al Viro''s vfs changes. Li Zefan (11): Btrfs: add pinned extents to on-disk free space cache correctly Btrfs: avoid possible NULL deref in io_ctl_drop_pages() Btrfs: check the return value of io_ctl_init() Btrfs: remove BUG_ON()s in btrfs_ioctl_setflags() Btrfs: reserve metadata space in btrfs_ioctl_s...

...art_transaction() was triggered while balancing. The cause is btrfs_relocate_chunk() started a transaction and then called iput() on the inode that stores free space cache, and iput() called btrfs_start_transaction() again. Reported-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 02ff4a1..4e9aa28 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3646,7 +3646,7 @@ void btrfs_evict_inode(struct inode *inod...

...30.1 MB/s # dd if=/dev/zero of=/mnt/tmp bs=4K count=1 conv=notrunc oflag=direct dd: writing `/mnt/tmp'': Input/output error 1+0 records in 0+0 records out btrfs_ordered_update_i_size() may return 1, but btrfs_endio_direct_write() mistakenly takes it as an error. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/inode.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 0ccc743..3bd35fe 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -5785,8 +5785,7 @@ again: if (test_bit(BTRFS_ORDERED_NOCO...

...erating on btrfs filesystems mounted with lzo option. - Allow to turn on lzo compression for defrag operation: # btrfs filesystem defragment -c[zlib, lzo] <file> Note: "-c zlib" will fail, because that''s how getopt() works for optional arguments. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- The lzo patchset for kernel code can be found here: http://marc.info/?l=linux-btrfs&m=128799063215123&w=2 --- btrfs.c | 2 +- btrfs_cmds.c | 24 ++++++++++++++++++++---- ctree.h | 18 +++++++++++------- ioctl.h | 9 ++++++++- 4 fi...

...we can implement snapshow-aware defrag: We set the EXTENT_DEFRAG flag when dirtying the extents that need defragmented, so later on writeback thread can differentiate between normal writeback and writeback started by defragmentation. This patch is used for the latter one. Originally patch by Li Zefan <lizf@cn.fujitsu.com> Signed-off-by: Liu Bo <bo.li.liu@oracle.com> --- fs/btrfs/extent_io.c | 8 ++++++++ fs/btrfs/extent_io.h | 2 ++ fs/btrfs/file.c | 4 ++-- fs/btrfs/inode.c | 20 ++++++++++++-------- fs/btrfs/ioctl.c | 8 ++++---- 5 files changed, 28 ins...

Hi! With 3.2-rc4 (probably earlier), Ext4 seems to remember what areas it trimmed: merkaba:~> fstrim -v /boot /boot: 224657408 bytes were trimmed merkaba:~> fstrim -v /boot /boot: 0 bytes were trimmed But BTRFS does not: merkaba:~> fstrim -v / /: 4431613952 bytes were trimmed merkaba:~> fstrim -v / /: 4341846016 bytes were trimmed Is it planned to add this feature to BTRFS

...@cn.fujitsu.com >Data: 30/11/2010 8.03 >A: <kreijack@libero.it> >Cc: <linux-btrfs@vger.kernel.org> >Ogg: Re: [PATCH 5/5] btrfs: Add ioctl to set snapshot readonly/writable > >Goffredo Baroncelli wrote: >> Hi Li, >> >> On Monday, 29 November, 2010, Li Zefan wrote: >>> This allows us to set a snapshot readonly or writable on the fly. >>> >>> Usage: >>> >>> Set BTRFS_SNAPSHOT_RDONLY/WRITABLE of btrfs_ioctl_vol_arg_v2->flags, >>> and then call ioctl(BTRFS_IOCTL_SNAP_SETFLAGS); >> >> I...

Signed-off-by: Jie Liu <jeff.liu@oracle.com> --- fs/btrfs/super.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 15634d4..16f31e1 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -406,7 +406,7 @@ static int btrfs_parse_early_options(const char *options, fmode_t flags, u64 *subvol_rootid, struct

The first four bytes is the length of all data chunks, and the first four bytes of each chunk is the length of compressed chunk data, even when there''s only one chunk, which is the case for inline extents. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- fs/btrfs/snappy.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/snappy.c b/fs/btrfs/snappy.c index d6bd607..35b877e 100644 --- a/fs/btrfs/snappy.c +++ b/fs/btrfs/snappy.c @@ -392,12 +392,16 @@ static int btrfs_snappy_decompress...

...s (+124/-9): Btrfs: deal with DIO bios that span more than one ordered extent (+89/-4) Btrfs: avoid NULL pointer deref in try_release_extent_buffer (+4/-2) Btrfs: don''t use migrate page without CONFIG_MIGRATION (+6/-1) Btrfs: add migrate page for metadata inode (+25/-2) Li Zefan (3) commits (+6/-6): btrfs: Check if dest_offset is block-size aligned before cloning file (+3/-4) btrfs: Show device attr correctly for symlinks (+1/-0) btrfs: Set file size correctly in file clone (+2/-2) Miao Xie (3) commits (+195/-45): btrfs: cleanup duplicate bio allocating fu...

...kvm at vger.kernel.org Signed-off-by: Asias He <asias at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings <ben at decadent.org.uk> Cc: Li Zefan <lizefan at huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> --- drivers/block/virtio_blk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -21,8 +21,6 @@ struct workqu...

...kvm at vger.kernel.org Signed-off-by: Asias He <asias at redhat.com> Acked-by: Michael S. Tsirkin <mst at redhat.com> Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings <ben at decadent.org.uk> Cc: Li Zefan <lizefan at huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org> --- drivers/block/virtio_blk.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -21,8 +21,6 @@ struct workqu...

...ression and when setting the default subvolume. Signed-off-by: Mitch Harder <mitch.harder@sabayonlinux.org> --- v1->v2 - Remove extraneous formatting change. v2->v3 - Consolidate into a single patch - Convert helper function to a static inline function. v3->v4 - Per feedback from Li Zefan, change function name from _chk_ to _set_ - Per feedback from David Sterba, make the helper function more generic. - The more generic function can also be implemented in the INCOMPAT check made for setting the default subvolume. fs/btrfs/ctree.h | 17 +++++++++++++++++ fs/btrfs/ioctl.c | 16...

...ize of the "struct btrfs_ioctl_search_key", because I used some un-used fields. I left the old code untouched, and I added another IOCTL, putting a warning in the old one. If we accept to break the binary compatibility we can reuse the old IOCTL. This patch is complementary to the Li Zefan ones [1], so for the best correctness both have to be applied. Comments are welcome Regards G.Baroncelli diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index f87552a..52075ed 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1134,11 +1134,11 @@ advance_key: if (key->offset < (u6...

Since the d_off in the first dirent for "." (that originates from the 4th argument "offset" of filldir() for the 2nd dirent for "..") is wrongly assigned in btrfs_real_readdir(), telldir returns same offset for different locations. | # mkfs.btrfs /dev/sdb1 | # mount /dev/sdb1 fs0 | # cd fs0 | # touch file0 file1 | # ../test | telldir: 0 | readdir: d_off = 2,

...gt; Sent: Tuesday, February 15, 2011 5:12 PM > To: Minchan Kim > Cc: Dan Magenheimer; gregkh@suse.de; Chris Mason; linux- > kernel@vger.kernel.org; linux-mm@kvack.org; ngupta@vflare.org; linux- > btrfs@vger.kernel.org; Josef Bacik; Dan Rosenberg; Yan Zheng; > miaox@cn.fujitsu.com; Li Zefan > Subject: Re: [PATCH V2 0/3] drivers/staging: zcache: dynamic page > cache/swap compression > > On Mon, Feb 14, 2011 at 4:35 AM, Minchan Kim <minchan.kim@gmail.com> > wrote: > > On Mon, Feb 14, 2011 at 10:29 AM, Matt <jackdachef@gmail.com> wrote: > >> On...