search for: yoriyuki

On Thu, Oct 01, 2015 at 07:09:02PM +0300, Roman Kagan wrote: > On Thu, Oct 01, 2015 at 04:22:14PM +0100, Richard W.M. Jones wrote: > > On Thu, Oct 01, 2015 at 06:04:03PM +0300, Roman Kagan wrote: > > > On Mon, Aug 10, 2015 at 06:55:28PM +0300, Roman Kagan wrote: > > > > Libguestfs supports passing an ISO image as a source of virtio windows > > > > drivers

...;XXX This won't work if paths contain non-ASCII.") Since String.lowercase assumes the string is ISO-8859-1, it could actually corrupt UTF-8 paths. As usual we're in a hard place here because we don't want to add dependencies on external libraries like Camomile (https://github.com/yoriyuki/Camomile) which would be the obvious choice, but no one has written a working replacement for mllib/common_utils.ml. Whatever you do, make sure it's obvious that it's still broken and needs to be fixed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjon...

...ontain non-ASCII.") > > Since String.lowercase assumes the string is ISO-8859-1, it could > actually corrupt UTF-8 paths. > > As usual we're in a hard place here because we don't want to add > dependencies on external libraries like Camomile > (https://github.com/yoriyuki/Camomile) which would be the obvious > choice, but no one has written a working replacement for > mllib/common_utils.ml. > > Whatever you do, make sure it's obvious that it's still broken and > needs to be fixed. The XXX comment was kept unmodified, and is now sitting at th...