search for: yongkui

----- Original Message ----- > On Thu, Aug 31, 2017 at 05:45:38AM -0400, Yongkui Guo wrote: > > Hi, > > > > I tried to do code coverage testing for libguestfs with gcov. > > > > The steps are shown as follows: > > 1. Download and install the source package(libguestfs-1.36.5-1.el7.src.rpm) > > Probably best to try building this from g...

...t qemu 1.5 (in RHEL 7) does not understand the file.file.filename= and file.driver= parameters. Go back to using the old-style file= and format= parameters when we're not trying to set the file.backing.file.locking=off parameter. Fixes commit 9fe592808ccfd9ed184b88ca9c6cad2e1798dee3. Thanks: Yongkui Guo, Václav Kadlčík. --- lib/launch-direct.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/lib/launch-direct.c b/lib/launch-direct.c index aa4139359..47e8f37de 100644 --- a/lib/launch-direct.c +++ b/lib/launch-direct.c @@ -255,17 +255,28 @@ a...

...mp/rpm-tmp.JoY6TA (%build) --------------------------------------------------------------------------------------- The patch in attachment added in libguestfs.spec aims to resolve the above issue. But it seems to have no effect. Any idea how to resolve this issue? Thanks. Best Regards Yongkui Guo IRC: yoguo Tel: 15010777318

On Thu, Aug 31, 2017 at 05:45:38AM -0400, Yongkui Guo wrote: > Hi, > > I tried to do code coverage testing for libguestfs with gcov. > > The steps are shown as follows: > 1. Download and install the source package(libguestfs-1.36.5-1.el7.src.rpm) Probably best to try building this from git instead of using RPMs, so we can get...

On Fri, Sep 01, 2017 at 04:28:52AM -0400, Yongkui Guo wrote: > > stamp-mlguestfs: libguestfsocaml.a $(guestfs_cmm) > > $(OCAMLMKLIB) -o mlguestfs \ > > $(libguestfsocaml_a_OBJECTS) guestfs.cmo \ > > $(LDFLAGS) \ > > $(LTLIBINTL) \ > > - -L../lib/.libs -lguestfs...

See comment in code for justification. Thanks: Yongkui Guo for finding the bug. --- daemon/xattr.c | 43 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/daemon/xattr.c b/daemon/xattr.c index 761f6074b..3257f241e 100644 --- a/daemon/xattr.c +++ b/daemon/xattr.c @@ -19,6 +19,8 @@ #include <c...

https://bugzilla.redhat.com/show_bug.cgi?id=1564983 Because Mount.mount_vfs was declared with the wrong type signature it could never be called correctly from outside the daemon. The root cause of this problem is that the generator doesn't generate the type signatures automatically (which it could do, and fairly easily). Therefore there are probably other similar bugs waiting to be found.

v1 here: https://www.redhat.com/archives/libguestfs/2020-March/msg00099.html This one fixes most of the points picked up in review, and does not strdup the strings which should keep down memory usage if that is a concern. Rich.

...xattr. For justification, see the comment I added in patch 3. Patch 1 & 2 are refactoring. I was on the verge of rewriting the whole file in OCaml, but OCaml doesn't have access to the relevant system calls so it would have been a bunch more work and not necessarily any simpler. Thanks: Yongkui Guo for identifying the bug. Rich.

...tion at build time (Pino Toscano). qemu ≥ 2.10 is supported (but not required). This adds mandatory locking to disks and libguestfs turns this off in certain circumstances when it is known to be safe (Lars Seipel, Peter Krempa, Daniel Berrangé, Pino Toscano, Fam Zheng, Yongkui Guo, Václav Kadlčík). Internals Most common code has been moved to the common/ subdirectory, with OCaml common code being in common/ml* directories (eg. common/visit and common/mlvisit contain the visitor library in C and OCaml respectively). The mllib directory ha...