search for: yara_fin

...derr, "(%d): Yara warning: %s\n", line, message); Ditto. In addition, IMHO this message should be shown only when verbose is true... like what is written in the API doc comment at the beginning of the function :) > +} > + > +/* Clean up yara handle on daemon exit. */ > +void yara_finalize (void) __attribute__((destructor)); > +void > +yara_finalize (void) > +{ > + int ret = 0; if (!initialized) return; > + > + if (rules != NULL) { > + yr_rules_destroy (rules); > + rules = NULL; > + } > + > + ret = yr_finalize (); > + if (re...

...ot;, line, message); > Ditto. > In addition, IMHO this message should be shown only when verbose is > true... like what is written in the API doc comment at the beginning > of the function :) > >> +} >> + >> +/* Clean up yara handle on daemon exit. */ >> +void yara_finalize (void) __attribute__((destructor)); >> +void >> +yara_finalize (void) >> +{ >> + int ret = 0; > if (!initialized) > return; > >> + >> + if (rules != NULL) { >> + yr_rules_destroy (rules); >> + rules = NULL; >> + }...

...e that calling reply_with_error is safe here. How do you avoid calling reply_with_error twice along error paths? > + else if (verbose) > + fprintf (stderr, "Yara warning (line %d): %s\n", line, message); > +} > + > +/* Clean up yara handle on daemon exit. */ > +void yara_finalize (void) __attribute__((destructor)); > + > +void > +yara_finalize (void) > +{ > + int r = 0; Shouldn't be initialized. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpres...

...r *message, void *data) +{ + if (level == YARA_ERROR_LEVEL_ERROR) + reply_with_error ("Yara error (line %d): %s", line, message); + else if (verbose) + fprintf (stderr, "Yara warning (line %d): %s\n", line, message); +} + +/* Clean up yara handle on daemon exit. */ +void yara_finalize (void) __attribute__((destructor)); + +void +yara_finalize (void) +{ + int ret = 0; + + if (!initialized) + return; + + if (rules != NULL) { + yr_rules_destroy (rules); + rules = NULL; + } + + ret = yr_finalize (); + if (ret != ERROR_SUCCESS) + perror ("yr_finalize"...

v2: - Fix yara dependency in packagelist - Use pkg-config where available - Improve longdesc of yara_load API - Fix libyara initialization and finalization - Import CLEANUP_FCLOSE - Add custom CLEANUP_DESTROY_YARA_COMPILER - Add rules compilation error callback - Other small fixes according to comments Matteo Cafasso (6): appliance: add yara dependency New API: yara_load New API:

...const char *message, void *data) +{ + if (level == YARA_ERROR_LEVEL_ERROR) + reply_with_error ("(%d): Yara error: %s", line, message); + else + fprintf (stderr, "(%d): Yara warning: %s\n", line, message); +} + +/* Clean up yara handle on daemon exit. */ +void yara_finalize (void) __attribute__((destructor)); +void +yara_finalize (void) +{ + int ret = 0; + + if (rules != NULL) { + yr_rules_destroy (rules); + rules = NULL; + } + + ret = yr_finalize (); + if (ret != ERROR_SUCCESS) + perror ("yr_finalize"); + + initialized = false; +} + +int...

...r *message, void *data) +{ + if (level == YARA_ERROR_LEVEL_ERROR) + reply_with_error ("Yara error (line %d): %s", line, message); + else if (verbose) + fprintf (stderr, "Yara warning (line %d): %s\n", line, message); +} + +/* Clean up yara handle on daemon exit. */ +void yara_finalize (void) __attribute__((destructor)); + +void +yara_finalize (void) +{ + int ret = 0; + + if (!initialized) + return; + + if (rules != NULL) { + yr_rules_destroy (rules); + rules = NULL; + } + + ret = yr_finalize (); + if (ret != ERROR_SUCCESS) + perror ("yr_finalize"...

...r *message, void *data) +{ + if (level == YARA_ERROR_LEVEL_ERROR) + reply_with_error ("Yara error (line %d): %s", line, message); + else if (verbose) + fprintf (stderr, "Yara warning (line %d): %s\n", line, message); +} + +/* Clean up yara handle on daemon exit. */ +void yara_finalize (void) __attribute__((destructor)); + +void +yara_finalize (void) +{ + int r = 0; + + if (!initialized) + return; + + if (rules != NULL) { + yr_rules_destroy (rules); + rules = NULL; + } + + r = yr_finalize (); + if (r != ERROR_SUCCESS) + perror ("yr_finalize"); + +...

...r *message, void *data) +{ + if (level == YARA_ERROR_LEVEL_ERROR) + reply_with_error ("Yara error (line %d): %s", line, message); + else if (verbose) + fprintf (stderr, "Yara warning (line %d): %s\n", line, message); +} + +/* Clean up yara handle on daemon exit. */ +void yara_finalize (void) __attribute__((destructor)); + +void +yara_finalize (void) +{ + int ret = 0; + + if (!initialized) + return; + + if (rules != NULL) { + yr_rules_destroy (rules); + rules = NULL; + } + + ret = yr_finalize (); + if (ret != ERROR_SUCCESS) + perror ("yr_finalize"...

...return -1; > + } > + > + len = xdr_getpos (&xdr); > + > + xdr_destroy (&xdr); > + > + /* Send serialised tsk_detection out. */ Typo in comment. > + return send_file_write (buf, len); > +} > + > /* Clean up yara handle on daemon exit. */ > void yara_finalize (void) __attribute__((destructor)); > void > diff --git a/generator/actions.ml b/generator/actions.ml > index 152c651..d9006f2 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -13280,6 +13280,16 @@ Previously loaded rules will be destroyed." }; >...

Rebase patches on top of 1.37.1. No changes since last series. Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am

v8: - Ignore returned value in daemon/upload.c - Report serialization errors in lib/yara.c Matteo Cafasso (8): daemon: ignore unused return value in upload function daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in

v3: - allow to load multiple rule files - added optional namespace parameter to yara_load - move destructor logic in yara module - use generic file upload logic - use generic temporary path function Matteo Cafasso (6): appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests

...dr_getpos (&xdr); >> + >> + xdr_destroy (&xdr); >> + >> + /* Send serialised tsk_detection out. */ > Typo in comment. > >> + return send_file_write (buf, len); >> +} >> + >> /* Clean up yara handle on daemon exit. */ >> void yara_finalize (void) __attribute__((destructor)); >> void >> diff --git a/generator/actions.ml b/generator/actions.ml >> index 152c651..d9006f2 100644 >> --- a/generator/actions.ml >> +++ b/generator/actions.ml >> @@ -13280,6 +13280,16 @@ Previously loaded rules will be...

...+ if (ret == 0) { + perror ("xdr_guestfs_int_yara_detection"); + return -1; + } + + len = xdr_getpos (&xdr); + + xdr_destroy (&xdr); + + /* Send serialised tsk_detection out. */ + return send_file_write (buf, len); +} + /* Clean up yara handle on daemon exit. */ void yara_finalize (void) __attribute__((destructor)); void diff --git a/generator/actions.ml b/generator/actions.ml index 152c651..d9006f2 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -13280,6 +13280,16 @@ Previously loaded rules will be destroyed." }; shortdesc = "destroy pre...

...+ if (r == 0) { + perror ("xdr_guestfs_int_yara_detection"); + return -1; + } + + len = xdr_getpos (&xdr); + + xdr_destroy (&xdr); + + /* Send serialised yara_detection out. */ + return send_file_write (buf, len); +} + /* Clean up yara handle on daemon exit. */ void yara_finalize (void) __attribute__((destructor)); diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index 59c571b9e..1f7decdd4 100644 --- a/generator/actions_yara.ml +++ b/generator/actions_yara.ml @@ -53,4 +53,12 @@ Previously loaded rules will be destroyed." }; longdesc = &quot...

...if (ret == 0) { + perror ("xdr_guestfs_int_yara_detection"); + return -1; + } + + len = xdr_getpos (&xdr); + + xdr_destroy (&xdr); + + /* Send serialised yara_detection out. */ + return send_file_write (buf, len); +} + /* Clean up yara handle on daemon exit. */ void yara_finalize (void) __attribute__((destructor)); diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index 9d93d9f11..2166d6f0a 100644 --- a/generator/actions_yara.ml +++ b/generator/actions_yara.ml @@ -53,4 +53,12 @@ Previously loaded rules will be destroyed." }; longdesc = &quot...

...if (ret == 0) { + perror ("xdr_guestfs_int_yara_detection"); + return -1; + } + + len = xdr_getpos (&xdr); + + xdr_destroy (&xdr); + + /* Send serialised yara_detection out. */ + return send_file_write (buf, len); +} + /* Clean up yara handle on daemon exit. */ void yara_finalize (void) __attribute__((destructor)); diff --git a/generator/actions_yara.ml b/generator/actions_yara.ml index fe71d53f5..a5a46e8c7 100644 --- a/generator/actions_yara.ml +++ b/generator/actions_yara.ml @@ -48,4 +48,12 @@ but belonging to different files." }; longdesc = "\ Destr...

Rebase patches on top of 1.35.25. No changes since last series. Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am

v9: - fixes according to comments Matteo Cafasso (7): daemon: expose file upload logic appliance: add yara dependency New API: yara_load New API: yara_destroy New API: internal_yara_scan New API: yara_scan yara_scan: added API tests appliance/packagelist.in | 4 + configure.ac | 1 + daemon/Makefile.am | 4 +-