search for: y9irgrgf3uxojwum

...ed with error message. However, the caller can easily overwrite the filled message. Instead of adding multiple "if (!extack->_msg)" checks before any NL_SET_ERR_MSG() call, which appears after call to the driver, let's add new macro to common code. [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal Signed-off-by: Leon Romanovsky <leonro at nvidia.com> --- Changelog: v2: * Removed () brackets around msg to fix compilation error. v1: https://lore.kernel.org/all/d4843760219f20367c27472f084bd8aa729cf321.1674995155.git.leon at kernel.org * Added special *_WEAK() macro instead of...

...caller can easily > overwrite the filled message. > > Instead of adding multiple "if (!extack->_msg)" checks before any > NL_SET_ERR_MSG() call, which appears after call to the driver, let's > add this check to common code. > > [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal > Signed-off-by: Leon Romanovsky <leonro at nvidia.com> > --- I would somewhat prefer not doing this, and instead introducing a new NL_SET_ERR_MSG_WEAK() of sorts. The reason has to do with the fact that an extack is sometimes also used to convey warnings rather than hard er...

...caller can easily > overwrite the filled message. > > Instead of adding multiple "if (!extack->_msg)" checks before any > NL_SET_ERR_MSG() call, which appears after call to the driver, let's > add new macro to common code. > > [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal > Signed-off-by: Leon Romanovsky <leonro at nvidia.com> I'm sorry for nit-picking, but checkpatch complains the author (leon at kernel.org) does not match the SoB tag. A v3 with a suitable From: tag should fix that. Thanks, Paolo

...te the filled message. > > > > Instead of adding multiple "if (!extack->_msg)" checks before any > > NL_SET_ERR_MSG() call, which appears after call to the driver, let's > > add this check to common code. > > > > [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal > > Signed-off-by: Leon Romanovsky <leonro at nvidia.com> > > --- > > I would somewhat prefer not doing this, and instead introducing a new > NL_SET_ERR_MSG_WEAK() of sorts. That'd be my preference too, FWIW. It's only the offload cases which need th...

...d with error message. However, the caller can easily overwrite the filled message. Instead of adding multiple "if (!extack->_msg)" checks before any NL_SET_ERR_MSG() call, which appears after call to the driver, let's add this check to common code. [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal Signed-off-by: Leon Romanovsky <leonro at nvidia.com> --- include/linux/netlink.h | 4 ++-- net/bridge/br_switchdev.c | 10 ++++------ net/dsa/master.c | 4 +--- net/dsa/slave.c | 5 ++--- 4 files changed, 9 insertions(+), 14 deletions(-) diff --git a/inclu...

...te the filled message. > > > > Instead of adding multiple "if (!extack->_msg)" checks before any > > NL_SET_ERR_MSG() call, which appears after call to the driver, let's > > add this check to common code. > > > > [1] https://lore.kernel.org/all/Y9Irgrgf3uxOjwUm at unreal > > Signed-off-by: Leon Romanovsky <leonro at nvidia.com> > > --- > > I would somewhat prefer not doing this, and instead introducing a new > NL_SET_ERR_MSG_WEAK() of sorts. It means changing ALL error unwind places where extack was forwarded before to subfunc...