search for: xxx_split

...es (Jason); > > - Add helper virtqueue_use_indirect() (Jason); > > - Just set id for the last descriptor of a list (Jason); > > - Calculate the prev in virtqueue_add_packed() (Jason); > > - Fix/improve desc suppression code (Jason/MST); > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > - Fix the comments and API in uapi (MST); > > - Remove the BUG_ON() for indirect (Jason); > > - Some other refinements and bug fixes; > > > > RFC v1 -> RFC v2: > > - Add indirect descriptor support - compile test only; > >...

...turn NULL; > + } > + > + if (!more_used(vq)) { > + pr_debug("No more buffers in queue\n"); > + END_USE(vq); > + return NULL; > + } So virtqueue_get_buf_ctx_split should only call more_used_split. to avoid such issues I think we should lay out the code like this: XXX_split XXX_packed XXX wrappers > +/* The standard layout I'd drop standard here. > for the packed ring is a continuous chunk of memory > + * which looks like this. > + * > + * struct vring_packed > + * { Can the opening bracket go on the prev line pls? > + * // The actual d...

...ueue_use_indirect() (Jason); > > > > - Just set id for the last descriptor of a list (Jason); > > > > - Calculate the prev in virtqueue_add_packed() (Jason); > > > > - Fix/improve desc suppression code (Jason/MST); > > > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > > > - Fix the comments and API in uapi (MST); > > > > - Remove the BUG_ON() for indirect (Jason); > > > > - Some other refinements and bug fixes; > > > > > > > > RFC v1 -> RFC v2: > > > > - Ad...

...turn NULL; > > +} > > I think the those copy-and-paste hunks could be avoided and the diff should > only contains renaming of the function. If yes, it would be very welcomed > since it requires to compare the changes verbatim otherwise. Michael suggested to lay out the code as: XXX_split XXX_packed XXX wrappers https://lkml.org/lkml/2018/4/13/410 That's why I moved some code. > > > + > > +/* > > + * The layout for the packed ring is a continuous chunk of memory > > + * which looks like this. > > + * > > + * struct vring_packed { >...

...- Split into small patches (Jason); > - Add helper virtqueue_use_indirect() (Jason); > - Just set id for the last descriptor of a list (Jason); > - Calculate the prev in virtqueue_add_packed() (Jason); > - Fix/improve desc suppression code (Jason/MST); > - Refine the code layout for XXX_split/packed and wrappers (MST); > - Fix the comments and API in uapi (MST); > - Remove the BUG_ON() for indirect (Jason); > - Some other refinements and bug fixes; > > RFC v1 -> RFC v2: > - Add indirect descriptor support - compile test only; > - Add event suppression supprt - c...

...gt; > > > - Just set id for the last descriptor of a list (Jason); > > > > > > - Calculate the prev in virtqueue_add_packed() (Jason); > > > > > > - Fix/improve desc suppression code (Jason/MST); > > > > > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > > > > > - Fix the comments and API in uapi (MST); > > > > > > - Remove the BUG_ON() for indirect (Jason); > > > > > > - Some other refinements and bug fixes; > > > > > > > > > > >...

...- Split into small patches (Jason); > - Add helper virtqueue_use_indirect() (Jason); > - Just set id for the last descriptor of a list (Jason); > - Calculate the prev in virtqueue_add_packed() (Jason); > - Fix/improve desc suppression code (Jason/MST); > - Refine the code layout for XXX_split/packed and wrappers (MST); > - Fix the comments and API in uapi (MST); > - Remove the BUG_ON() for indirect (Jason); > - Some other refinements and bug fixes; > > RFC v1 -> RFC v2: > - Add indirect descriptor support - compile test only; > - Add event suppression supprt - c...

...; - Add helper virtqueue_use_indirect() (Jason); > > > - Just set id for the last descriptor of a list (Jason); > > > - Calculate the prev in virtqueue_add_packed() (Jason); > > > - Fix/improve desc suppression code (Jason/MST); > > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > > - Fix the comments and API in uapi (MST); > > > - Remove the BUG_ON() for indirect (Jason); > > > - Some other refinements and bug fixes; > > > > > > RFC v1 -> RFC v2: > > > - Add indirect descriptor support...

..._use_indirect() (Jason); >>>>> - Just set id for the last descriptor of a list (Jason); >>>>> - Calculate the prev in virtqueue_add_packed() (Jason); >>>>> - Fix/improve desc suppression code (Jason/MST); >>>>> - Refine the code layout for XXX_split/packed and wrappers (MST); >>>>> - Fix the comments and API in uapi (MST); >>>>> - Remove the BUG_ON() for indirect (Jason); >>>>> - Some other refinements and bug fixes; >>>>> >>>>> RFC v1 -> RFC v2: >>>>>...

...es (Jason); > > - Add helper virtqueue_use_indirect() (Jason); > > - Just set id for the last descriptor of a list (Jason); > > - Calculate the prev in virtqueue_add_packed() (Jason); > > - Fix/improve desc suppression code (Jason/MST); > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > - Fix the comments and API in uapi (MST); > > - Remove the BUG_ON() for indirect (Jason); > > - Some other refinements and bug fixes; > > > > RFC v1 -> RFC v2: > > - Add indirect descriptor support - compile test only; > >...

...gt; - Just set id for the last descriptor of a list (Jason); > > > > > > > - Calculate the prev in virtqueue_add_packed() (Jason); > > > > > > > - Fix/improve desc suppression code (Jason/MST); > > > > > > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > > > > > > - Fix the comments and API in uapi (MST); > > > > > > > - Remove the BUG_ON() for indirect (Jason); > > > > > > > - Some other refinements and bug fixes; > > > > > > > >...

...id for the last descriptor of a list (Jason); > > > > > > > > - Calculate the prev in virtqueue_add_packed() (Jason); > > > > > > > > - Fix/improve desc suppression code (Jason/MST); > > > > > > > > - Refine the code layout for XXX_split/packed and wrappers (MST); > > > > > > > > - Fix the comments and API in uapi (MST); > > > > > > > > - Remove the BUG_ON() for indirect (Jason); > > > > > > > > - Some other refinements and bug fixes; > > > > > &...

On 2018?05?22? 16:16, Tiwei Bie wrote: > This commit introduces the support for creating packed ring. > All split ring specific functions are added _split suffix. > Some necessary stubs for packed ring are also added. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 801 +++++++++++++++++++++++------------ >

On 2018?05?22? 16:16, Tiwei Bie wrote: > This commit introduces the support for creating packed ring. > All split ring specific functions are added _split suffix. > Some necessary stubs for packed ring are also added. > > Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> > --- > drivers/virtio/virtio_ring.c | 801 +++++++++++++++++++++++------------ >

...rt; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...

...rt; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...

...rt; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...

...rt; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...

...et; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...

...rt; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_pack...