search for: xt_replace_t

...riority: P5 Component: ip_tables (kernel) AssignedTo: netfilter-buglog at lists.netfilter.org ReportedBy: pmodilaynen at gmail.com Estimated Hours: 0.0 Hello netfilter developers! I suspect a small bug in /kernel/net/ipv4/netfilter/ip_tables.c __do_replace() function. xt_replace_table() may return NULL when allocation of memory was not successful by xt_replace_table->xt_jumpstack_alloc() (in my case I suspect there were no free memory when it's happened): ... oldinfo = xt_replace_table(t, num_counters, newinfo, &ret); if (!oldinfo) goto pu...

...VED CC| |netfilter at linuxace.com Resolution| |INVALID --- Comment #2 from Phil Oester <netfilter at linuxace.com> 2013-06-06 17:11:05 CEST --- Unclear why you believe this is a bug. If the memory allocation in xt_replace_table fails, it returns NULL. At this point, the "goto put_module" is correct - we need to cleanup after ourselves. Your suggestion to "goto out" is not beneficial. Further, the backtrace you provided is because the memory system could not allocate memory. This has nothing wha...