search for: xmluriunescapestring

This adds coalescing of adjacent extents of the same type, as mentioned by Eric Blake in the commit message here: https://github.com/libguestfs/libnbd/commit/46072f6611f80245846a445766da071e457b00cd The patch series is rather long because it detours through adding the <vector.h> library from nbdkit into libnbd and replacing ad hoc uses of realloc, char ** etc in various places. Rich.

Hi All, Here's the latest patch. I think this should address the problem. The query string is now only appended to the end of a URI in the HTTP and HTTPS cases. The add-uri test now passes, and 'make check' still passes. -- Gabriel

...documented in the documentation text of the add_drive API - 'fullPath' in lib/drives.c is leaked - the new 'query' struct member in common/options/options.h is leaked - use safe_asprintf instead of asprintf in lib/drives.c, so it will abort already in case of failure - why was xmlURIUnescapeString() used? - in case of nbd URIs with a socket, now the path to the socket will be both in the server name, and as query string; see the various tests in fish/test-add-uri.sh Thanks, -- Pino Toscano

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.