search for: xml_quote_attr

...lement e -> + element_to_buf ~indent buf e +and element_to_buf ?(indent = 0) buf { e_name = name; e_attrs = attrs; e_children = children } = - output_spaces chan indent; - fprintf chan "<%s" name; - List.iter (fun (n, v) -> fprintf chan " %s='%s'" n (xml_quote_attr v)) attrs; + buffer_add_spaces buf indent; + bprintf buf "<%s" name; + List.iter (fun (n, v) -> bprintf buf " %s='%s'" n (xml_quote_attr v)) attrs; if children <> [] then ( - output_string chan ">"; + Buffer.add_string buf ">&...

Just refactoring. Rich.

The first four patches are straightforward. The final patch adds the -o rhv-upload output mode. It is still spooling into a temporary file because I've had some trouble getting streaming conversions working. There are other problems as outlined in the commit message, so this patch is not ready for upstream but is good for discussion. Also I hit this, which I'm assuming for now will be

...then false (* no match *) else loop lines diff --git a/v2v/utils.ml b/v2v/utils.ml index cdf7535..b78ef3c 100644 --- a/v2v/utils.ml +++ b/v2v/utils.ml @@ -31,16 +31,16 @@ let quote = Filename.quote * quotes around the attribute. *) let xml_quote_attr str = - let str = replace_str str "&" "&amp;" in - let str = replace_str str "'" "&apos;" in - let str = replace_str str "<" "&lt;" in - let str = replace_str str ">" "&gt;" in + let s...

Hide/prevent the use of bad string functions like String.lowercase. These are replaced by safe functions that won't break UTF-8 strings. Other miscellaneous refactoring. Rich.