search for: xlnx

Hi Thomas, Thank you for the patch. On Tue, Sep 15, 2020 at 04:59:57PM +0200, Thomas Zimmermann wrote: > The xlnx driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions as part of > this change. > > Two callbacks, .dumb_destroy and .gem_prime_import, were initialized &g...

Hi Thomas, Thank you for the patch. On Thu, Aug 13, 2020 at 10:36:43AM +0200, Thomas Zimmermann wrote: > The xlnx driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions as part of > this change. > > Two callbacks, .dumb_destroy and .gem_prime_import, were initialized &g...

...r scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com> --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index b47463473472..7ea0cd4f71d3 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -19,6 +19,7 @@ #i...

The xlnx driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .dumb_destroy and .gem_prime_import, were initialized to their default implementa...

The xlnx driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .dumb_destroy and .gem_prime_import, were initialized to their default implementa...

...e. Align the pitch according to hardware requirements. > > Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com> > Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com> > --- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c > index b47463473472..7ea0cd4f71d3 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c > +++ b/drivers/gpu/drm/xlnx/zyn...

...rding to hardware requirements. >> >> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> >> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com> >> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com> >> --- >> ? drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +++++-- >> ? 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c >> b/drivers/gpu/drm/xlnx/zynqmp_kms.c >> index b47463473472..7ea0cd4f71d3 100644 >> --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c >&g...

...ements. >>> >>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de> >>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com> >>> Cc: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com> >>> --- >>> ? drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +++++-- >>> ? 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/ >>> xlnx/zynqmp_kms.c >>> index b47463473472..7ea0cd4f71d3 100644 >>> --- a/drivers/gpu/drm...

Hi Am 16.01.25 um 11:03 schrieb Tomi Valkeinen: [...] > Aligning video= and dumb buffers almost sounds like going backwards. > video= parameter is bad, Who told you that? Video= is still the way to specify an initial display mode to the kernel and it will remain so. Of course, it is better to auto-detect settings, but that's for a different use case. Best regards Thomas >

Hi, On 20/01/2025 09:49, Thomas Zimmermann wrote: > Hi > > > Am 16.01.25 um 11:03 schrieb Tomi Valkeinen: > [...] >> Aligning video= and dumb buffers almost sounds like going backwards. >> video= parameter is bad, > > Who told you that? Video= is still the way to specify an initial display > mode to the kernel and it will remain so. You did =). "It

On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen <tomi.valkeinen at ideasonboard.com> wrote: > No disagreement there, we need CREATE_DUMB2. > > My point is that we have the current UAPI, and we have userspace using > it, but we don't have clear rules what the ioctl does with specific > parameters, and we don't document how it has to be used. > > Perhaps the situation

On Wed, Jan 15, 2025 at 02:34:26PM +0000, Daniel Stone wrote: > On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > > No disagreement there, we need CREATE_DUMB2. > > > > My point is that we have the current UAPI, and we have userspace using > > it, but we don't have clear rules what the ioctl does with specific > > parameters, and we don't document how

On Thu, Jan 16, 2025 at 10:43:40AM +0200, Laurent Pinchart wrote: > On Wed, Jan 15, 2025 at 02:34:26PM +0000, Daniel Stone wrote: > > On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: > > > No disagreement there, we need CREATE_DUMB2. > > > > > > My point is that we have the current UAPI, and we have userspace using > > > it, but we don't have

Hi, On 16/01/2025 11:38, Laurent Pinchart wrote: > On Thu, Jan 16, 2025 at 10:43:40AM +0200, Laurent Pinchart wrote: >> On Wed, Jan 15, 2025 at 02:34:26PM +0000, Daniel Stone wrote: >>> On Wed, 15 Jan 2025 at 14:20, Tomi Valkeinen wrote: >>>> No disagreement there, we need CREATE_DUMB2. >>>> >>>> My point is that we have the current UAPI, and

Hi Am 15.01.25 um 14:33 schrieb Tomi Valkeinen: [...] >> Yeah, there are constrains in the scanline and buffer alignments and >> orientation. And if we say that bpp==12 means NV12, it will be a >> problem for all other cases where bpp==12 makes sense. > > I feel I still don't quite understand. Can't we define and document > CREATE_DUMB like this: > >

Hi Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: [...] >> These are all good points. Did you read my discussion with Andy on >> patch 2? I think it resolves all the points you have. The current >> CREATE_DUMB > > I had missed the discussion, and, indeed, the patch you attached fixes > the problem on Xilinx. Great. Thanks for testing. > >> ioctl is

On 15/01/2025 15:45, Thomas Zimmermann wrote: > Hi > > > Am 15.01.25 um 14:33 schrieb Tomi Valkeinen: > [...] >>> Yeah, there are constrains in the scanline and buffer alignments and >>> orientation. And if we say that bpp==12 means NV12, it will be a >>> problem for all other cases where bpp==12 makes sense. >> >> I feel I still don't

Hi Am 15.01.25 um 15:20 schrieb Tomi Valkeinen: [...] > > My point is that we have the current UAPI, and we have userspace using > it, but we don't have clear rules what the ioctl does with specific > parameters, and we don't document how it has to be used. > > Perhaps the situation is bad, and all we can really say is that > CREATE_DUMB only works for use with

Hi, On 15/01/2025 14:34, Thomas Zimmermann wrote: > Hi > > > Am 15.01.25 um 13:06 schrieb Tomi Valkeinen: >> Hi, >> >> On 15/01/2025 13:37, Thomas Zimmermann wrote: >>> Hi >>> >>> >>> Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: >>> [...] >>>>> These are all good points. Did you read my discussion with

Hi, On 15/01/2025 13:37, Thomas Zimmermann wrote: > Hi > > > Am 15.01.25 um 11:58 schrieb Tomi Valkeinen: > [...] >>> These are all good points. Did you read my discussion with Andy on >>> patch 2? I think it resolves all the points you have. The current >>> CREATE_DUMB >> >> I had missed the discussion, and, indeed, the patch you