search for: xinliangli

On Tue, Jul 16, 2013 at 1:37 PM, Xinliang David Li <xinliangli at gmail.com>wrote: > On Tue, Jul 16, 2013 at 1:33 PM, Chandler Carruth <chandlerc at google.com> > wrote: > > On Tue, Jul 16, 2013 at 1:18 PM, Xinliang David Li <xinliangli at gmail.com > > > > wrote: > >> > >> Ignoring FE time which can be fu...

...gold linker. David On Tue, Oct 4, 2016 at 6:58 AM, Teresa Johnson <tejohnson at google.com> wrote: > > > On Mon, Oct 3, 2016 at 6:15 PM, Teresa Johnson <tejohnson at google.com> > wrote: > >> >> >> On Mon, Oct 3, 2016 at 5:24 PM, Xinliang David Li <xinliangli at gmail.com> >> wrote: >> >>> Small repro: >>> >>> __attribute__((weak)) int hello_world(); >>> >>> int test() { >>> if (hello_world) >>> return hello_world(); >>> return 0; >>> } >>>...

On Apr 17, 2014, at 11:09 AM, Xinliang David Li <xinliangli at gmail.com> wrote: > > On Thu, Apr 17, 2014 at 10:58 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: > > On 2014-Apr-17, at 10:38, Xinliang David Li <xinliangli at gmail.com> wrote: > > > > > Another idea is to use stack local counters per...

...unctions are defined in-class. > --paulr > > >> >> David >> >> > >> >> >> >> Thanks, >> >> Easwaran >> >> >> >> >> >> On Wed, Jun 24, 2015 at 12:56 PM, Xinliang David Li >> >> <xinliangli at gmail.com> wrote: >> >> > The problem is that the other way around is not true: a function >> >> > linkonce_odr linkage may be neither inline declared nor have in-class >> >> > definition. >> >> > >> >> > David >&gt...

On Tue, Jul 16, 2013 at 1:40 PM, Chandler Carruth <chandlerc at google.com> wrote: > On Tue, Jul 16, 2013 at 1:37 PM, Xinliang David Li <xinliangli at gmail.com> > wrote: >> >> On Tue, Jul 16, 2013 at 1:33 PM, Chandler Carruth <chandlerc at google.com> >> wrote: >> > On Tue, Jul 16, 2013 at 1:18 PM, Xinliang David Li >> > <xinliangli at gmail.com> >> > wrote: >> >> >...

...' it is effectively noise in that situation. > --paulr You are assuming most of the functions are defined in-class, which I think is not true. David > >> >> Thanks, >> Easwaran >> >> >> On Wed, Jun 24, 2015 at 12:56 PM, Xinliang David Li >> <xinliangli at gmail.com> wrote: >> > The problem is that the other way around is not true: a function >> > linkonce_odr linkage may be neither inline declared nor have in-class >> > definition. >> > >> > David >> > >> > >> > On Wed, Ju...

On Mon, Oct 3, 2016 at 5:24 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > Small repro: > > __attribute__((weak)) int hello_world(); > > int test() { > if (hello_world) > return hello_world(); > return 0; > } > > $ clang -fuse-ld=gold -flto=thin -O2 -shared -fPIC -o libmore.so more.c > $ objdump -t...

...;> >> >> >> > >> >> >> >> >> >> Thanks, >> >> >> Easwaran >> >> >> >> >> >> >> >> >> On Wed, Jun 24, 2015 at 12:56 PM, Xinliang David Li >> >> >> <xinliangli at gmail.com> wrote: >> >> >> > The problem is that the other way around is not true: a function >> >> >> > linkonce_odr linkage may be neither inline declared nor have in- >> class >> >> >> > definition. >> >> >...

On Fri, Aug 12, 2016 at 12:15 PM, Xinliang David Li via llvm-dev < llvm-dev at lists.llvm.org> wrote: > +dehao. > > There are two potential problems: > > 1) the branch gets eliminated in the binary that is being profiled, so > there is no profile data > This seems like a fundamental problem for PGO. Maybe it is also responsible for this bug:

On Mon, Oct 3, 2016 at 3:53 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > What is the linker command line buidling liblldb.so? is libgcc.a passed in? > There is no difference in the linker command for liblldb.so or bin/lldb between the ld.bfd and ld.gold cases, and neither links libgcc.a that I can see. The difference appears to be that...

...On Oct 28, 2010, at 2:43 PM, Xinliang David Li wrote: >> >> > >> > >> > 2010/10/27 Rafael Espíndola <rafael.espindola at gmail.com >> <mailto:rafael.espindola at gmail.com>> >> >> > 2010/10/27 Xinliang David Li <xinliangli at gmail.com >> <mailto:xinliangli at gmail.com>>: >> >> > > Thanks. Just built clang and saw the meta data and annotations >> on the memory >> > > accesses -- is any opt pass consuming the information? >> > >>...

...t; 2010/10/27 Rafael Espíndola <rafael.espindola at gmail.com > <mailto:rafael.espindola at gmail.com> > <mailto:rafael.espindola at gmail.com > <mailto:rafael.espindola at gmail.com>>> > > > 2010/10/27 Xinliang David Li <xinliangli at gmail.com > <mailto:xinliangli at gmail.com> > <mailto:xinliangli at gmail.com <mailto:xinliangli at gmail.com>>>: > > > > Thanks. Just built clang and saw the meta data and annotations > on the memory > &...

...definitions is one part of my question. Even if there is a way to do that without passing the hint, I'm interested in getting feedback on treating it at-par with functions having the inline hint in inline cost analysis. Thanks, Easwaran On Wed, Jun 24, 2015 at 12:56 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > The problem is that the other way around is not true: a function > linkonce_odr linkage may be neither inline declared nor have in-class > definition. > > David > > > On Wed, Jun 24, 2015 at 11:53 AM, Robinson, Paul > <Paul_Robinson at playsta...

On Tue, Mar 24, 2015 at 11:46 AM, Xinliang David Li <xinliangli at gmail.com> wrote: > On Tue, Mar 24, 2015 at 11:29 AM, Chandler Carruth <chandlerc at google.com> > wrote: > >> Sorry I haven't responded earlier, but one point here still doesn't make >> sense to me: >> >> On Tue, Mar 24, 2015 at 10:27 AM, Xinli...

On Fri, Mar 27, 2015 at 4:09 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > How about only removing the scaling limit when PGO is on? I don't see the > need for this change without PGO. This is what my patch does, and it's getting into issues. With the scaling limit gone, the frequencies propagated overflow 64bits, so they need to...

...al truth, but intuitively, the description of 'inline' in C++ standard seems to influence what methods are defined in-class. - Easwaran > --paulr > >> >> Thanks, >> Easwaran >> >> >> On Wed, Jun 24, 2015 at 12:56 PM, Xinliang David Li >> <xinliangli at gmail.com> wrote: >> > The problem is that the other way around is not true: a function >> > linkonce_odr linkage may be neither inline declared nor have in-class >> > definition. >> > >> > David >> > >> > >> > On Wed, Ju...

On 2014-Apr-17, at 10:38, Xinliang David Li <xinliangli at gmail.com> wrote: > > Another idea is to use stack local counters per function -- synced up with global counters on entry and exit. the problem with it is for deeply recursive calls, stack pressure can be too high. I think they'd need to be synced with global counters before func...

David, Yes, that is very helpful. Thanks! --randy From: Xinliang David Li [mailto:xinliangli at gmail.com] Sent: Wednesday, May 27, 2015 12:53 PM To: Randy Chapman Cc: Lee Hunt; llvmdev at cs.uiuc.edu Subject: Re: FW: [LLVMdev] Capabilities of Clang's PGO (e.g. improving code density) On Wed, May 27, 2015 at 12:40 PM, Randy Chapman <randyc at microsoft.com<mailto:randyc at mic...

----- Original Message ----- > From: "Hal Finkel via llvm-dev" <llvm-dev at lists.llvm.org> > To: "Xinliang David Li" <xinliangli at gmail.com> > Cc: "llvm-dev" <llvm-dev at lists.llvm.org> > Sent: Friday, February 26, 2016 11:07:35 PM > Subject: Re: [llvm-dev] Possible soundness issue with > available_externally (split from "RFC: Add guard intrinsics") > ----- Original Message ---...

Capping also leads to other kinds of problems -- e.g., sum of incoming edge count (callgraph) does not match the callee entry count etc. David On Tue, Mar 24, 2015 at 12:50 PM, Xinliang David Li <xinliangli at gmail.com> wrote: > > > On Tue, Mar 24, 2015 at 12:45 PM, Chandler Carruth <chandlerc at google.com> > wrote: > >> >> On Tue, Mar 24, 2015 at 11:46 AM, Xinliang David Li <xinliangli at gmail.com >> > wrote: >> >>> On Tue, Mar 24, 20...