search for: xfree

...817528171 -0800 +++ auth2-jpake.c 2012-12-19 17:05:59.044554766 -0800 @@ -178,7 +178,7 @@ fatal("%s: not enough bytes for rawsalt (want %u have %u)", __func__, len, digest_len); memcpy(rawsalt, digest, len); - bzero(digest, digest_len); + memset(digest, 0, digest_len); xfree(digest); } @@ -203,10 +203,10 @@ fatal("%s: want %u", __func__, want); derive_rawsalt(user, rawsalt, sizeof(rawsalt)); - bzero(ret, sizeof(ret)); + memset(ret, 0, sizeof(ret)); for (i = 0; i < want; i++) ret[i] = pw_encode64(rawsalt[i]); - bzero(rawsalt, sizeof(raw...

...17:05:59.044554766 -0800 @@ -178,7 +178,7 @@ fatal("%s: not enough bytes for rawsalt (want %u have %u)", __func__, len, digest_len); memcpy(rawsalt, digest, len); - bzero(digest, digest_len); + memset(digest, 0, digest_len); xfree(digest); } @@ -203,10 +203,10 @@ fatal("%s: want %u", __func__, want); derive_rawsalt(user, rawsalt, sizeof(rawsalt)); - bzero(ret, sizeof(ret)); + memset(ret, 0, sizeof(ret)); for (i = 0; i < want; i++) ret[i] = pw_encode...

...mds[y].c; y++) { + if (!strncasecmp(cmd, cmds[y].c, cmdlen)) + list[count++] = xstrdup(cmds[y].c); + + list[count] = NULL; + } + + if (count > 0) { + char *tmp = complete_ambiguous(cmd, list, count); + + if (count > 1) + complete_display(list, 0); + + for (y = 1; list[y]; y++) + xfree(list[y]); + xfree(list); + + if (tmp != NULL) { + if (strlen(tmp) > strlen(cmd)) + if (el_insertstr(el, tmp + strlen(cmd)) == -1) + fatal("el_insertstr failed."); + + xfree(tmp); + } + } + + return (count); +} + +int +complete_is_remote(char *cmd) { + int i; + + if (cmd...

There are several memory management bugs here. First, the variable tmp is allocated by infer_path. In one path this allocating function is called again on the same variable without freeing the first instance. In another path the variable is just not freed. The fix is to add the xfree before the second call to infer_path and to move the existing xfree to cover both paths (in one case this is on the result of the first infer_path in the second it is on the second call. The second bug is deadcode. The abs_dst variable has always been freed by the time the value is checked to cal...

http://bugzilla.mindrot.org/show_bug.cgi?id=996 Summary: Fatal error in xfree() when scp invokes ssh with a LocalForward config Product: Portable OpenSSH Version: 4.0p1 Platform: All OS/Version: FreeBSD Status: NEW Severity: normal Priority: P2 Component: ssh Assigned...

..._domain.params || - !d->arch.hvm_domain.io_handler ) + if ( !d->arch.hvm_domain.params || !d->arch.hvm_domain.io_handler ) goto fail0; d->arch.hvm_domain.io_handler->num_slot = 0; @@ -578,7 +573,6 @@ int hvm_domain_initialise(struct domain *d) fail0: xfree(d->arch.hvm_domain.io_handler); xfree(d->arch.hvm_domain.params); - xfree(d->arch.hvm_domain.pbuf); return rc; } @@ -603,7 +597,6 @@ void hvm_domain_relinquish_resources(struct domain *d) xfree(d->arch.hvm_domain.io_handler); xfree(d->arch.hvm_domain.param...

Hi, I noticed that Markus has fixed the temporary file cleanup problems in OpenSSH cvs. What files need patching for this ? I only noticed changes in: session.c, channels.h and channels.c. -Jarno -- Jarno Huuskonen <Jarno.Huuskonen at uku.fi>

How well does Wine work on any of the XFree 4.x servers? I looked for this information at WineHQ, but couldn't seem to find anything. Thanks in advance. -- Matthew Cline | Suppose you were an idiot. And suppose that matt@nightrealms.com | you were a member of Congress. But I repeat | myself. -- Mark Tw...

Patch is below : diff -nru openssh-3.8.1p1/auth-options.c openssh-3.8.1p1-devs//auth-options.c --- openssh-3.8.1p1/auth-options.c Tue Jun 3 02:25:48 2003 +++ openssh-3.8.1p1-devs//auth-options.c Mon Feb 21 16:56:49 2005 @@ -265,6 +265,81 @@ xfree(patterns); goto next_option; } + +/* e.g: permitopenned="158.156.0.0/255.255.255.0:25[-1024]" + * note that part between [] is optionnal for 1 port specification + */ + cp = "permitopennet=\""; + if (strncasecmp(opts, cp, strlen(cp)) == 0) { + char netblock[256],...

On Sun, 2004-08-08 at 14:10, Dr Mike Waters wrote: snip > Thanks for the responses guys. > > I used to have RH9 installed on this machine and I found out about the > separate developer packages then. I thought that I had got the relevant > XFree devel package installed, but although it showed up in the rpm database > as being present, the required files were not present. I did a forced rpm > upgrade from the WhiteBox updates directory and that problem is now fixed, > at least for car. Marc, thanks for the pointer on the rgl proble...

...9/12/04 09:24:48 1.33 +++ sshd.c 1999/12/07 03:55:18 @@ -1551,24 +1551,41 @@ get_remote_port(), user); -#ifdef HAVE_LIBPAM - do_pam_account_and_session(pw->pw_name, client_user); +#ifndef HAVE_LIBPAM + if (authenticated) + return; - /* Clean up */ - if (client_user != NULL) - xfree(client_user); + if (attempt > AUTH_FAIL_MAX) + packet_disconnect(AUTH_FAIL_MSG, pw->pw_name); +#else /* HAVE_LIBPAM */ + if (authenticated) { + do_pam_account_and_session(pw->pw_name, client_user); - if (password != NULL) { - memset(password, 0, strlen(password)); - xfree(pass...

...+++ openssh/deattack.c 22 Aug 2003 05:34:05 -0000 @@ -112,20 +112,26 @@ if (len <= HASH_MINBLOCKS) { for (c = buf; c < buf + len; c += SSH_BLOCKSIZE) { if (IV && (!CMP(c, IV))) { - if ((check_crc(c, buf, len, IV))) + if ((check_crc(c, buf, len, IV))) { + if (h) + xfree(h); return (DEATTACK_DETECTED); - else + } else break; } for (d = buf; d < c; d += SSH_BLOCKSIZE) { if (!CMP(c, d)) { - if ((check_crc(c, buf, len, IV))) + if ((check_crc(c, buf, len, IV))) { + if (h) + xfree(h); return (DEATTACK_DETECTED); -...

The variable local_user was allocated by xstrdup and is not freed or pointed to in this branch. This patch adds the xfree. This entire set of patches passed the regression tests on my system. Bug found by Coverity. Signed-off-by: Kylene Hall <kjhall at us.ibm.com> --- sshconnect.c | 1 + 1 files changed, 1 insertion(+) diff -uprN openssh-4.3p2/sshconnect.c openssh-4.3p2-kylie/sshconnect.c --- openssh-4.3p2/s...

...log X11 forwards that are established, ideally with a username and remote display information, but whatever I can get, I'll take. Any help would be great. session.c: packet_check_eom(); success = session_setup_x11fwd(s); if (!success) { xfree(s->auth_proto); xfree(s->auth_data); s->auth_proto = NULL; s->auth_data = NULL; } else { verbose("jblaine testing : w00t? : %s", s->auth_display); }

...close(fp); return (n); + } /* Count entries for sort */ for (n = 0; d[n] != NULL; n++) *************** *** 583,598 **** memset(&sb, 0, sizeof(sb)); attrib_to_stat(&d[n]->a, &sb); lname = ls_file(fname, &sb, 1); ! printf("%s\n", lname); xfree(lname); } else { /* XXX - multicolumn display would be nice here */ ! printf("%s\n", fname); } xfree(fname); } free_sftp_dirents(d); return (0); } --- 603,619 ---- memset(&sb, 0, sizeof(sb)); attrib_to_stat(&d[n]->a, &sb); lna...

...2p1, SSH protocols 1.5/2.0, OpenSSL 0x0090603f phil at polaris:/home/phil 2> ssh -p 10 root at polaris.ipal.net Connection closed by 209.102.208.19 phil at polaris:/home/phil 3> ============================================================================= Message in syslog on server: fatal: xfree: NULL pointer given as argument Additional test: Telnet to SSH port (test port 10, not 22) shows normal banner and after pressing return gives "Protocol mismatch." as normally seen when using telnet to sshd (e.g. the above error must be later in the protocol sequence than raw telnet wou...

...-kbdint.c 2 Jul 2002 02:19:35 -0000 @@ -49,10 +49,6 @@ if (options.challenge_response_authentication) authenticated = auth2_challenge(authctxt, devs); -#ifdef USE_PAM - if (authenticated == 0 && options.pam_authentication_via_kbd_int) - authenticated = auth2_pam(authctxt); -#endif xfree(devs); xfree(lang); #ifdef HAVE_CYGWIN Index: auth2-pam.c =================================================================== RCS file: /var/cvs/openssh/auth2-pam.c,v retrieving revision 1.14 diff -u -r1.14 auth2-pam.c --- auth2-pam.c 28 Jun 2002 16:48:12 -0000 1.14 +++ auth2-pam.c 2 Jul 2002 02...

...kbdint.c 25 Jun 2002 01:42:11 -0000 @@ -49,10 +49,6 @@ if (options.challenge_response_authentication) authenticated = auth2_challenge(authctxt, devs); -#ifdef USE_PAM - if (authenticated == 0 && options.pam_authentication_via_kbd_int) - authenticated = auth2_pam(authctxt); -#endif xfree(devs); xfree(lang); #ifdef HAVE_CYGWIN Index: auth2-pam.c =================================================================== RCS file: /var/cvs/openssh/auth2-pam.c,v retrieving revision 1.12 diff -u -r1.12 auth2-pam.c --- auth2-pam.c 22 Jan 2002 12:43:13 -0000 1.12 +++ auth2-pam.c 25 Jun 2002 0...

...ct sockaddr *)&addr, addr.sun_len) == -1) { - muxserver_sock = -1; - if (errno == EINVAL || errno == EADDRINUSE) { - error("ControlSocket %s already exists, " - "disabling multiplexing", options.control_path); - close(muxserver_sock); - muxserver_sock = -1; - xfree(options.control_path); - options.control_path = NULL; - options.control_master = SSHCTL_MASTER_NO; - return; - } else - fatal("%s bind(): %s", __func__, strerror(errno)); + debug3("%s: entering for channel %d", __func__, cid); + if (c == NULL) + fatal("%s: channel...

..._domain.params || - !d->arch.hvm_domain.io_handler ) + if ( !d->arch.hvm_domain.params || !d->arch.hvm_domain.io_handler ) goto fail0; d->arch.hvm_domain.io_handler->num_slot = 0; @@ -578,7 +573,6 @@ int hvm_domain_initialise(struct domain *d) fail0: xfree(d->arch.hvm_domain.io_handler); xfree(d->arch.hvm_domain.params); - xfree(d->arch.hvm_domain.pbuf); return rc; } @@ -603,7 +597,6 @@ void hvm_domain_relinquish_resources(struct domain *d) xfree(d->arch.hvm_domain.io_handler); xfree(d->arch.hvm_domain.param...