search for: xen_domain

Displaying 20 results from an estimated 157 matches for "xen_domain".

2016 Jan 31
2
[Xen-devel] [PATCH v5 09/10] vring: Use the DMA API on Xen
...ble >> > + * the DMA API if we're a Xen guest, which at least allows >> > + * all of the sensible Xen configurations to work correctly. >> > + */ >> > + return static_cpu_has(X86_FEATURE_XENPV); >> >> You want: >> >> if (xen_domain()) >> return true; >> >> Without the #if so we use the DMA API for all types of Xen guest on all >> architectures. >> >> David > > I doubt HVM domains can have virtio devices. > They certainly can under nested virt (L0 provides virtio device, L1...
2016 Jan 31
2
[Xen-devel] [PATCH v5 09/10] vring: Use the DMA API on Xen
...ble >> > + * the DMA API if we're a Xen guest, which at least allows >> > + * all of the sensible Xen configurations to work correctly. >> > + */ >> > + return static_cpu_has(X86_FEATURE_XENPV); >> >> You want: >> >> if (xen_domain()) >> return true; >> >> Without the #if so we use the DMA API for all types of Xen guest on all >> architectures. >> >> David > > I doubt HVM domains can have virtio devices. > They certainly can under nested virt (L0 provides virtio device, L1...
2020 Jun 24
2
[PATCH] xen: introduce xen_vring_use_dma
...ses dma_ops to translate Linux's idea of a physical address into a real physical address (this is unneeded on ARM.) So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 always and on Xen/ARM if Linux is Dom0 (because it has foreign mappings.) That is why we have the if (xen_domain) return true; in vring_use_dma_api. You might have noticed that I missed one possible case above: Xen/ARM DomU :-) Xen/ARM domUs don't need swiotlb_xen, it is not even initialized. So if (xen_domain) return true; would give the wrong answer in that case. Linux would end up calling the "n...
2020 Jun 24
2
[PATCH] xen: introduce xen_vring_use_dma
...ses dma_ops to translate Linux's idea of a physical address into a real physical address (this is unneeded on ARM.) So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 always and on Xen/ARM if Linux is Dom0 (because it has foreign mappings.) That is why we have the if (xen_domain) return true; in vring_use_dma_api. You might have noticed that I missed one possible case above: Xen/ARM DomU :-) Xen/ARM domUs don't need swiotlb_xen, it is not even initialized. So if (xen_domain) return true; would give the wrong answer in that case. Linux would end up calling the "n...
2020 Jun 29
2
[PATCH] xen: introduce xen_vring_use_dma
...> > > > > > > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > > > > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > > > > > mappings.) That is why we have the if (xen_domain) return true; in > > > > > > vring_use_dma_api. > > > > > > > > > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > > > > > > > > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > > > >...
2020 Jun 29
2
[PATCH] xen: introduce xen_vring_use_dma
...> > > > > > > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > > > > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > > > > > mappings.) That is why we have the if (xen_domain) return true; in > > > > > > vring_use_dma_api. > > > > > > > > > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > > > > > > > > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > > > >...
2016 Jan 29
3
[Xen-devel] [PATCH v5 09/10] vring: Use the DMA API on Xen
...orked and will > + * not work without an even larger kludge. Instead, enable > + * the DMA API if we're a Xen guest, which at least allows > + * all of the sensible Xen configurations to work correctly. > + */ > + return static_cpu_has(X86_FEATURE_XENPV); You want: if (xen_domain()) return true; Without the #if so we use the DMA API for all types of Xen guest on all architectures. David
2016 Jan 29
3
[Xen-devel] [PATCH v5 09/10] vring: Use the DMA API on Xen
...orked and will > + * not work without an even larger kludge. Instead, enable > + * the DMA API if we're a Xen guest, which at least allows > + * all of the sensible Xen configurations to work correctly. > + */ > + return static_cpu_has(X86_FEATURE_XENPV); You want: if (xen_domain()) return true; Without the #if so we use the DMA API for all types of Xen guest on all architectures. David
2020 Jun 25
4
[PATCH] xen: introduce xen_vring_use_dma
...s unneeded on ARM.) > > > > > > > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > > > mappings.) That is why we have the if (xen_domain) return true; in > > > > vring_use_dma_api. > > > > > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > > > > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > > > forces DMA ops even if VIRTIO_F_IOMMU_PLATFORM is clear...
2020 Jun 25
4
[PATCH] xen: introduce xen_vring_use_dma
...s unneeded on ARM.) > > > > > > > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > > > mappings.) That is why we have the if (xen_domain) return true; in > > > > vring_use_dma_api. > > > > > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > > > > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > > > forces DMA ops even if VIRTIO_F_IOMMU_PLATFORM is clear...
2019 Oct 13
2
[PATCH] tools/virtio: Fix build
...issing function and header stubs. >> >> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com> > > Thanks! > I think it's already fixes in the vhost tree. > That tree also includes a bugfix for the test. > Can you pls give it a spin and report? Mostly fixed: the xen_domain stup is missing. Jan > Thanks! > >> --- >> tools/virtio/crypto/hash.h | 0 >> tools/virtio/linux/dma-mapping.h | 2 ++ >> tools/virtio/linux/kernel.h | 2 ++ >> 3 files changed, 4 insertions(+) >> create mode 100644 tools/virtio/crypto/hash.h...
2019 Oct 13
2
[PATCH] tools/virtio: Fix build
...issing function and header stubs. >> >> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com> > > Thanks! > I think it's already fixes in the vhost tree. > That tree also includes a bugfix for the test. > Can you pls give it a spin and report? Mostly fixed: the xen_domain stup is missing. Jan > Thanks! > >> --- >> tools/virtio/crypto/hash.h | 0 >> tools/virtio/linux/dma-mapping.h | 2 ++ >> tools/virtio/linux/kernel.h | 2 ++ >> 3 files changed, 4 insertions(+) >> create mode 100644 tools/virtio/crypto/hash.h...
2020 Jun 24
2
[PATCH] xen: introduce xen_vring_use_dma
...> address into a real physical address (this is unneeded on ARM.) > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > mappings.) That is why we have the if (xen_domain) return true; in > > vring_use_dma_api. > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > forces DMA ops even if VIRTIO_F_IOMMU_PLATFORM is clear. > > Unfortunately as a result Xen never got around t...
2020 Jun 24
2
[PATCH] xen: introduce xen_vring_use_dma
...> address into a real physical address (this is unneeded on ARM.) > > > > > > So regardless of VIRTIO_F_IOMMU_PLATFORM, dma_ops should be used on Xen/x86 > > always and on Xen/ARM if Linux is Dom0 (because it has foreign > > mappings.) That is why we have the if (xen_domain) return true; in > > vring_use_dma_api. > > VIRTIO_F_IOMMU_PLATFORM makes guest always use DMA ops. > > Xen hack predates VIRTIO_F_IOMMU_PLATFORM so it *also* > forces DMA ops even if VIRTIO_F_IOMMU_PLATFORM is clear. > > Unfortunately as a result Xen never got around t...
2018 Jul 28
3
[RFC 2/4] virtio: Override device's DMA OPS with virtio_direct_dma_ops selectively
...and Xen enabled at the same time. On - * such a configuration, virtio has never worked and will - * not work without an even larger kludge. Instead, enable - * the DMA API if we're a Xen guest, which at least allows - * all of the sensible Xen configurations to work correctly. - */ - if (xen_domain()) - return true; - - return false; -} XEN guests would not like override with virtio_direct_dma_ops in any case irrespective of the flag VIRTIO_F_IOMMU_PLATFORM. So the existing semantics can be preserved with something like this. It just assumes that dev->dma_ops is non-NULL and a valid one...
2018 Jul 28
3
[RFC 2/4] virtio: Override device's DMA OPS with virtio_direct_dma_ops selectively
...and Xen enabled at the same time. On - * such a configuration, virtio has never worked and will - * not work without an even larger kludge. Instead, enable - * the DMA API if we're a Xen guest, which at least allows - * all of the sensible Xen configurations to work correctly. - */ - if (xen_domain()) - return true; - - return false; -} XEN guests would not like override with virtio_direct_dma_ops in any case irrespective of the flag VIRTIO_F_IOMMU_PLATFORM. So the existing semantics can be preserved with something like this. It just assumes that dev->dma_ops is non-NULL and a valid one...
2018 Aug 06
4
[RFC 0/4] Virtio uses DMA API for all devices
...s/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -155,7 +155,7 @@ static bool vring_use_dma_api(struct virtio_device *vdev) * the DMA API if we're a Xen guest, which at least allows * all of the sensible Xen configurations to work correctly. */ - if (xen_domain()) + if (xen_domain() || arch_virtio_direct_dma_ops(&vdev->dev)) return true; return false; (Passing the dev allows the arch to know this is a virtio device in "direct" mode or whatever we want to call the !iommu case, and construct appropriate DMA...
2018 Aug 06
4
[RFC 0/4] Virtio uses DMA API for all devices
...s/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c @@ -155,7 +155,7 @@ static bool vring_use_dma_api(struct virtio_device *vdev) * the DMA API if we're a Xen guest, which at least allows * all of the sensible Xen configurations to work correctly. */ - if (xen_domain()) + if (xen_domain() || arch_virtio_direct_dma_ops(&vdev->dev)) return true; return false; (Passing the dev allows the arch to know this is a virtio device in "direct" mode or whatever we want to call the !iommu case, and construct appropriate DMA...
2005 Sep 30
14
pdb missing files?
...e PDB system currently broken? Thanks, -Jon Output of errors from warnings: root:01:20 AM:pdb $ make make[1]: Entering directory `/usr/src/xen-unstable.hg-20050930_orig/tools/debugger/pdb'' making ._bcdi/Process.di from Process.mli making ._bcdi/Domain.di from Domain.mli making ._bcdi/Xen_domain.di from Xen_domain.mli making ._bcdi/xcs.di from xcs.mli making ._bcdi/evtchn.di from evtchn.mli making ._d/server.d from server.ml making ._d/debugger.d from debugger.ml making ._d/PDB.d from PDB.ml making ._d/Process.d from Process.ml making ._d/Domain.d from Domain.ml making ._d/Xen_domain.d fro...
2018 Jul 30
1
[RFC 2/4] virtio: Override device's DMA OPS with virtio_direct_dma_ops selectively
> > + > > + if (xen_domain()) > > + goto skip_override; > > + > > + if (virtio_has_iommu_quirk(dev)) > > + set_dma_ops(dev->dev.parent, &virtio_direct_dma_ops); > > + > > + skip_override: > > + > > I prefer normal if scoping as opposed to goto spaghetti pls. > Bett...