search for: xdr_free

...t.com> For stubs of functions that had arguments, code did this: static void mount_stub (XDR *xdr_in) { int r; struct guestfs_mount_args args; if (optargs_bitmask != 0) { //... goto done; } // possibly other tests here memset (&args, 0, sizeof args); [...] done: xdr_free ((xdrproc_t) xdr_guestfs_mount_args, (char *) &args); return; } This caused xdr_free to be called on uninitialized 'args' struct, causing a segfault. The fix is to add another label, so the code looks like: static void mount_stub (XDR *xdr_in) { int r; struct guestfs_mount_args...

...r.h:150: conflicting types for `XDR_ENCODE' /usr/include/rpc/xdr.h:84: previous declaration of `XDR_ENCODE' /usr/include/rx/xdr.h:151: conflicting types for `XDR_DECODE' /usr/include/rpc/xdr.h:85: previous declaration of `XDR_DECODE' /usr/include/rx/xdr.h:153: conflicting types for `XDR_FREE' /usr/include/rpc/xdr.h:87: previous declaration of `XDR_FREE' /usr/include/rx/xdr.h:153: confused by earlier errors, bailing out make: *** [auth/pass_check.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.91607 (%build) Any solution would be appreciated. thanks., Sandor -- ...F...

...) -> pr " struct guestfs_%s_ret ret;\n" name; pr " ret.%s = *r;\n" n; - pr " free (r);\n"; pr " reply ((xdrproc_t) xdr_guestfs_%s_ret, (char *) &ret);\n" name; pr " xdr_free ((xdrproc_t) xdr_guestfs_%s_ret, (char *) &ret);\n" @@ -404,7 +401,6 @@ let generate_daemon_stubs actions () = | RStructList (n, _) -> pr " struct guestfs_%s_ret ret;\n" name; pr " ret.%s = *r;\n" n; - pr " free (...

...licting types for `XDR_ENCODE' /usr/include/rpc/xdr.h:99: previous declaration of `XDR_ENCODE' /usr/afsws/include/rx/xdr.h:109: conflicting types for `XDR_DECODE' /usr/include/rpc/xdr.h:100: previous declaration of `XDR_DECODE' /usr/afsws/include/rx/xdr.h:111: conflicting types for `XDR_FREE' /usr/include/rpc/xdr.h:102: previous declaration of `XDR_FREE' /usr/afsws/include/rx/xdr.h:127: warning: redefinition of `xdrproc_t' /usr/include/rpc/xdr.h:120: warning: `xdrproc_t' previously declared here /usr/afsws/include/rx/xdr.h:137: redefinition of `struct xdr_ops' /usr/...

This is a simpler patch series to add symbol versioning. I have pushed patches 1-3 upstream. Rich.

This is a series of simplifications to the stubs code. It's all refactoring, there is no functional change. Rich.

This rather more complex patch series adds symbol versioning (7/7 shows it in action). This works for me, tested by running old and new virt-inspector binaries against the new library. Rich.

...; + pr "void\n"; + pr "cleanup_free_int_%s (void *ptr)\n" typ; + pr "{\n"; + pr " struct guestfs_int_%s *x = (* (struct guestfs_int_%s **) ptr);\n" typ typ; + pr "\n"; + pr " if (x) {\n"; + pr " xdr_free ((xdrproc_t) xdr_guestfs_int_%s, (char *) x);\n" typ; + pr " free (x);\n"; + pr " }\n"; + pr "}\n"; + pr "\n"; + + pr "void\n"; + pr "cleanup_free_int_%s_list (void *ptr)\n" typ; + pr "{\n&q...

...ENCODE' /usr/include/rpc/xdr.h:84: error: previous declaration of `XDR_ENCODE' /usr/include/afs/rx/xdr.h:151: error: conflicting types for `XDR_DECODE' /usr/include/rpc/xdr.h:85: error: previous declaration of `XDR_DECODE' /usr/include/afs/rx/xdr.h:153: error: conflicting types for `XDR_FREE' /usr/include/rpc/xdr.h:87: error: previous declaration of `XDR_FREE' /usr/include/afs/rx/xdr.h:169: error: conflicting types for `xdrproc_t' /usr/include/rpc/xdr.h:154: error: previous declaration of `xdrproc_t' /usr/include/afs/rx/xdr.h:179: error: redefinition of `struct xdr_ops&...

...DE? /usr/include/rpc/xdr.h:84: error: previous definition of ?XDR_ENCODE? was here /usr/include/rx/xdr.h:157: error: redeclaration of enumerator ?XDR_DECODE? /usr/include/rpc/xdr.h:85: error: previous definition of ?XDR_DECODE? was here /usr/include/rx/xdr.h:159: error: redeclaration of enumerator ?XDR_FREE? /usr/include/rpc/xdr.h:87: error: previous definition of ?XDR_FREE? was here /usr/include/rx/xdr.h:179: error: conflicting types for ?xdrproc_t? /usr/include/rpc/xdr.h:154: error: previous declaration of ?xdrproc_t? was here /usr/include/rx/xdr.h:194: error: redefinition of ?struct xdr_ops? /usr/i...

...rogram received signal SIGSEGV, Segmentation fault. 0xef5a4614 in strlen () (gdb) bt #0 0xef5a4614 in strlen () #1 0xef695164 in xdr_string () #2 0xef69b130 in xdr_nis_name () #3 0xef69eeac in xdr_nis_object () #4 0xef69b2d8 in xdr_array () #5 0xef69f528 in xdr_nis_result () #6 0xef69bb5c in xdr_free () #7 0xef69f854 in nis_freeresult () #8 0x38a48 in add_nisp21pwd_entry () #9 0x390ec in add_nisppwd_entry () #10 0x35900 in add_smbpwd_entry () #11 0x39258 in add_new_user () #12 0x393d8 in local_password_change () #13 0x2322c in password_change () #14 0x236cc in process_root () #15 0x23b70 in...

Hi, In data venerdì 2 gennaio 2015 23:57:43, Gabriele Cerami ha scritto: > added: > --no-compare-xattrs > --no-compare-extra-stats > --no-compare-perms > --no-compare-uids > --no-compare-times > > to ignore specified files informations when comparing. > > The current strategy to disable comparison on file informations is to > flatten data structure so they

...d by this event in the message. */ @@ -279,7 +279,7 @@ do_inotify_files (void) const char *name = events->guestfs_int_inotify_event_list_val[i].in_name; if (name[0] != '\0') - fprintf (fp, "%s\n", name); + fprintf (fp, "%s\n", name); } xdr_free ((xdrproc_t) xdr_guestfs_int_inotify_event_list, (char *) events); diff --git a/daemon/link.c b/daemon/link.c index 57e3538..29ae679 100644 --- a/daemon/link.c +++ b/daemon/link.c @@ -90,19 +90,19 @@ _link (const char *flag, int symbolic, const char *target, const char *linkname) if (flag)...

From: "Richard W.M. Jones" <rjones at redhat.com> Callers are supposed to use the availability API to check for functions that may not be available in particular builds of libguestfs. If they don't do this, currently they tend to get obscure error messages, eg: libguestfs: error: zerofree: /dev/vda1: zerofree: No such file or directory This commit changes the error

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

...@@ -459,7 +459,7 @@ receive_file (receive_cb cb, void *opaque) if (chunk.cancel) { if (verbose) fprintf (stderr, - "guestfsd: receive_file: received cancellation from library\n"); + "guestfsd: receive_file: received cancellation from library\n"); xdr_free ((xdrproc_t) xdr_guestfs_chunk, (char *) &chunk); return -2; } diff --git a/daemon/uuids.c b/daemon/uuids.c index e6287c5..7e69862 100644 --- a/daemon/uuids.c +++ b/daemon/uuids.c @@ -79,7 +79,7 @@ do_set_uuid (const char *device, const char *uuid) else NOT_SUPPORTED (-1,...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

...wo versions must match exactly.\n"), + fprintf (stderr, _("guestfish: protocol error: version mismatch, server version ‘%s’ does not match client version ‘%s’. The two versions must match exactly.\n"), PACKAGE_VERSION, hello.vers); xdr_free ((xdrproc_t) xdr_guestfish_hello, (char *) &hello); diff --git a/fish/reopen.c b/fish/reopen.c index 9098a9c31..37995d209 100644 --- a/fish/reopen.c +++ b/fish/reopen.c @@ -40,7 +40,7 @@ run_reopen (const char *cmd, size_t argc, char *argv[]) void *cb_data; if (argc > 0) { - fprin...

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.