search for: xbt_null

...x *ctx, uint32_t domid) { + libxl_gc gc = LIBXL_INIT_GC(ctx); char *path; char *state; - int ret; + int ret, rc = 0; if (is_hvm(ctx, domid)) { - path = libxl_sprintf(ctx, "/local/domain/0/device-model/%d/state", domid); - state = libxl_xs_read(ctx, XBT_NULL, path); + path = libxl_sprintf(&gc, "/local/domain/0/device-model/%d/state", domid); + state = libxl_xs_read(&gc, XBT_NULL, path); if (state != NULL && !strcmp(state, "paused")) { - libxl_xs_write(ctx, XBT_NULL, libxl_sprintf(ctx...

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> -- 1.7.10.4

...ar *kvs[3]; - int rc; struct xs_handle *xsh; - xsh = xs_daemon_open(); /* we mustn''t use the parent''s handle in the child */ kvs[0] = "image/device-model-pid"; @@ -1398,9 +1396,10 @@ return; kvs[2] = NULL; - rc = xs_writev(xsh, XBT_NULL, starting->dom_path, kvs); - if (rc) - return; + xsh = xs_daemon_open(); + if (!xsh) + xsh = xs_domain_open(); + xs_writev(xsh, XBT_NULL, starting->dom_path, kvs); xs_daemon_close(xsh); } diff -r eff592364826 tools/libxl/libxl_device.c --- a/tools/libxl/libxl...

Hi, compilation of xen-unstable with a fresh Ubuntu 11.10 x86_64 fails with following error: cc1: warnings being treated as errors libxl_create.c: In function ‘store_libxl_entry’: libxl_create.c:465: error: format not a string literal and no format arguments Steps to reproduce: - Install Ubuntu 11.10 ( http://www.ubuntu.com/start-download?distro=desktop&bits=64&release=latest) - sudo

...f --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 5783cd2..9e06a7d 100644 - --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -2569,7 +2569,8 @@ void libxl__device_nic_add(libxl__egc *egc, uint32_t domid, goto out_free; } if (!(l = libxl__xs_directory(gc, XBT_NULL, - - libxl__sprintf(gc, "%s/device/vif", dompath), &nb))) { + libxl__sprintf(gc, "%s/device/vif", dompath), &nb)) || + nb == 0) { nic->devid = 0; } else {...

To remove a pci passthough device from QEMU (upstream). Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libxl/libxl_internal.h | 2 ++ tools/libxl/libxl_qmp.c | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 1dff211..84da6b1 100644 ---

...t char *state) { char path[50]; + if (xs == NULL) { + fprintf(stderr, "xenstore connection not initialized\n"); + exit(1); + } + snprintf(path, sizeof (path), "/local/domain/0/device-model/%u/state", xen_domid); - if (!xs_write(s->xenstore, XBT_NULL, path, state, strlen(state))) { + if (!xs_write(xs, XBT_NULL, path, state, strlen(state))) { fprintf(stderr, "error recording dm state\n"); exit(1); } @@ -823,15 +828,20 @@ static void xen_main_loop_prepare(XenIOState *state) if (evtchn_fd != -1) {...

...0 +++ b/tools/console/daemon/io.c Mon Aug 09 14:26:22 2010 +0100 @@ -451,27 +451,6 @@ static int domain_create_tty(struct doma free(data); } free(path); - } - - success = asprintf(&path, "%s/limit", dom->serialpath) != -1; - if (!success) - goto out; - data = xs_read(xs, XBT_NULL, path, &len); - if (data) { - dom->buffer.max_capacity = strtoul(data, 0, 0); - free(data); - } - free(path); - - success = asprintf(&path, "%s/tty", dom->serialpath) != -1; - if (!success) - goto out; - success = xs_write(xs, XBT_NULL, path, slave, strlen(slave)); - free...

...eturn; @@ -75,5 +76,11 @@ void libxl__device_destroy_tapdisk(libxl err = tap_ctl_find(type, disk, &tap); if (err < 0) return; + /* + * Remove the instance of the backend device to avoid a deadlock with the + * removal of the tap device. + */ + xs_rm(ctx->xsh, XBT_NULL, be_path); + tap_ctl_destroy(tap.id, tap.minor); } diff -r b184698e0893 tools/libxl/libxl_device.c --- a/tools/libxl/libxl_device.c Tue Nov 06 19:53:48 2012 -0600 +++ b/tools/libxl/libxl_device.c Tue Nov 06 19:54:23 2012 -0600 @@ -250,8 +250,7 @@ int libxl__device_destroy(libxl_ctx *ctx...

This patch introduces support for two new parameters in libxl: smbios_firmware=<path_to_smbios_structures_file> acpi_firmware=<path_to_acpi_tables_file> The changes are primarily in the domain building code where the firmware files are read and passed to libxc for loading into the new guest. After the domain building call to libxc, the addresses for the loaded blobs are returned and

...t iovec iov[2]; + struct xs_stored_msg *msg, *tmsg; + bool res; + char *s, *p; + unsigned int i; + char *l_token, *l_path; iov[0].iov_base = (char *)path; iov[0].iov_len = strlen(path) + 1; iov[1].iov_base = (char *)token; iov[1].iov_len = strlen(token) + 1; - return xs_bool(xs_talkv(h, XBT_NULL, XS_UNWATCH, iov, - ARRAY_SIZE(iov), NULL)); + res = xs_bool(xs_talkv(h, XBT_NULL, XS_UNWATCH, iov, + ARRAY_SIZE(iov), NULL)); + + /* Filter the watch list to remove potential message */ + mutex_lock(&h->watch_mutex); + + if (list_empty(&h->watch_list)) { + mutex_unlock(&a...

...hutdown(struct libxl_ctx *ctx, uint32_t domid, int req) return ERROR_INVAL; dom_path = libxl_xs_get_dompath(ctx, domid); + if (!dom_path) + return ERROR_FAIL; + shutdown_path = libxl_sprintf(ctx, "%s/control/shutdown", dom_path); xs_write(ctx->xsh, XBT_NULL, shutdown_path, req_table[req], strlen(req_table[req])); @@ -347,20 +353,21 @@ static int libxl_destroy_device_model(struct libxl_ctx *ctx, uint32_t domid) pid = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "/local/domain/%d/image/device-model-pid", domid)); if (!pid) { -...

...return NULL; } + + +void libxl__device_destroy_tapdisk(libxl__gc *gc, char *be_path) +{ + char *path, *params, *type, *disk; + int err; + tap_list_t tap; + + path = libxl__sprintf(gc, "%s/tapdisk-params", be_path); + if (!path) return; + + params = libxl__xs_read(gc, XBT_NULL, path); + if (!params) return; + + type = params; + disk = strchr(params, '':''); + if (!disk) return; + + *disk++ = ''\0''; + + err = tap_ctl_find(type, disk, &tap); + if (err < 0) return; + + tap_ctl_destroy(tap.id, tap.minor); +} dif...

...t iovec iov[2]; + struct xs_stored_msg *msg, *tmsg; + bool res; + char *s, *p; + unsigned int i; + char *l_token, *l_path; iov[0].iov_base = (char *)path; iov[0].iov_len = strlen(path) + 1; iov[1].iov_base = (char *)token; iov[1].iov_len = strlen(token) + 1; - return xs_bool(xs_talkv(h, XBT_NULL, XS_UNWATCH, iov, - ARRAY_SIZE(iov), NULL)); + res = xs_bool(xs_talkv(h, XBT_NULL, XS_UNWATCH, iov, + ARRAY_SIZE(iov), NULL)); + + if (!h->unwatch_filter) /* Don''t filter the watch list */ + return res; + + + /* Filter the watch list to remove potential message */ + mutex_lo...

This patch introduces support for two new parameters in libxl: smbios_firmware=<path_to_smbios_structures_file> acpi_firmware=<path_to_acpi_tables_file> The changes are primarily in the domain building code where the firmware files are read and passed to libxc for loading into the new guest. After the domain building call to libxc, the addresses for the loaded blobs are returned and

...-3.0-testing). I had to modify the network backend driver (file netback.c), and each call to a xenbus function in a virtual machine make my machine reboot (not the virtual, the real machine). for example, I ''ve add this line of code (wich is useless): printk("%d",xenbus_exists(XBT_NULL,"/local/domain/0/","domid")); after a network packet reception. When I launch my virtual machine, the station reboot after the virtual machine console log is stopped after this block: TCP: Hash tables configured (established 8192 bind 8192) NET: Registered protocol family 1 NE...

This patch series adds support for preservation of the VM generation ID buffer address in xenstore across save/restore and migrate, and also code to increment the value in all cases except for migration. The first patch modifies creation of the hvmloader key in xenstore and adds creation of a new read/write hvmloader/generation-id-addr key. The second patch changes hvmloader to use the new key (as

...return NULL; } + + +void libxl__device_destroy_tapdisk(libxl__gc *gc, char *be_path) +{ + char *path, *params, *type, *disk; + int err; + tap_list_t tap; + + path = libxl__sprintf(gc, "%s/tapdisk-params", be_path); + if (!path) return; + + params = libxl__xs_read(gc, XBT_NULL, path); + if (!params) return; + + type = params; + disk = strchr(params, '':''); + if (!disk) return; + + *disk++ = ''\0''; + + err = tap_ctl_find(type, disk, &tap); + if (err < 0) return; + + tap_ctl_destroy(tap.id, tap.minor); +} dif...

Hey Ian and Stefano, Please see this thread: http://lists.xen.org/archives/html/xen-devel/2013-05/msg01053.html for the debug patches and some of the discussion. These three patches fix an race that has been in QEMU traditional for a long time. The guts of the bug is that if you have a guest with these options: vcpus=1 maxvcpus=32 and do ''xl vcpu-set <guest> 32'' the

...b/tools/xenstore/xenstore_client.c index 3ac214b..996ee64 100644 --- a/tools/xenstore/xenstore_client.c +++ b/tools/xenstore/xenstore_client.c @@ -134,8 +134,13 @@ static void do_ls(struct xs_handle *h, char *path, int cur_depth, int show_perms unsigned int num, len; e = xs_directory(h, XBT_NULL, path, &num); - if (e == NULL) + if (e == NULL) { + if(errno == EACCES && cur_depth) + /* Don''t stop listing just because access was denied to a descendant */ + return; + err(1, "xs_directory (%s)", path); + } for...