search for: xattributes

Displaying 19 results from an estimated 19 matches for "xattributes".

Did you mean: attributes
2014 Jan 10
3
Re: RFC: copy-attributes command
On Fri, Jan 10, 2014 at 01:33:38PM +0000, Richard W.M. Jones wrote: > The API is now pretty confusing. Each OBool flag is really a > tristate. It can either be "true", "false" or "not specified". > > Therefore I think it should be: > > xattributes:true # copies only xattrs and nothing else > all:true # copies everything > all:true xattributes:false # copies everything except xattrs > > In other words, 'all' changes the default (ie. "not specified") state > of the other flag...
2014 Jan 10
0
Re: RFC: copy-attributes command
...#39;ve added a "all" argument which would enable every change, overriding > even mode:false. The API is now pretty confusing. Each OBool flag is really a tristate. It can either be "true", "false" or "not specified". Therefore I think it should be: xattributes:true # copies only xattrs and nothing else all:true # copies everything all:true xattributes:false # copies everything except xattrs In other words, 'all' changes the default (ie. "not specified") state of the other flags. To be clearer, the fo...
2014 Jan 10
4
Re: RFC: copy-attributes command
..., > > > > attached there is a prototype of patch for adding a new > > copy-attributes command. Such command would allow copy the > > attributes of a "file" to> > > another, so for example in guestfish: > > copy-attributes foo bar permissions:true xattributes:false > > > > would only copy the permissions of foo to bar, not copying its > > extended attributes too. > > I think the general idea of the new API is fine. > > More comments about the code below. > > > Just few notes: > > - my first daemon command...
2014 Jan 13
0
[PATCH] New API: copy-attributes.
...clude "actions.h" +#include "optgroups.h" GUESTFSD_EXT_CMD(str_file, file); GUESTFSD_EXT_CMD(str_zcat, zcat); @@ -584,3 +585,74 @@ do_filesize (const char *path) return buf.st_size; } + +int +do_copy_attributes (const char *src, const char *dest, int all, int mode, int xattributes, int ownership) +{ + int r; + struct stat srcstat, deststat; + + static const unsigned int file_mask = 07777; + + /* If it was specified to copy everything, manually enable all the flags + * not manually specified to avoid checking for flag || all everytime. + */ + if (all) { + if (!(op...
2014 Jan 07
8
RFC: copy-attributes command
Hi, attached there is a prototype of patch for adding a new copy-attributes command. Such command would allow copy the attributes of a "file" to another, so for example in guestfish: copy-attributes foo bar permissions:true xattributes:false would only copy the permissions of foo to bar, not copying its extended attributes too. Just few notes: - my first daemon command, so possibly I could be missing something - copy_xattrs is in xattr.c to avoid spreading the usage of xattr API in many places - copy_xattrs does a bit of code...
2014 Jan 07
0
Re: RFC: copy-attributes command
...3PM +0100, Pino Toscano wrote: > Hi, > > attached there is a prototype of patch for adding a new copy-attributes > command. Such command would allow copy the attributes of a "file" to > another, so for example in guestfish: > copy-attributes foo bar permissions:true xattributes:false > would only copy the permissions of foo to bar, not copying its extended > attributes too. I think the general idea of the new API is fine. More comments about the code below. > Just few notes: > - my first daemon command, so possibly I could be missing something > - copy_...
2014 Jan 10
2
Re: RFC: copy-attributes command
On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > +int > +copy_xattrs (const char *src, const char *dest) > +{ > + abort (); > +} Is this called in the case where someone does copy-attributes foo bar xattributes:true on a version of libguestfs with no support for xattrs? It's probably better to silently ignore this case instead of crashing. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build...
2014 Jan 10
2
Re: RFC: copy-attributes command
On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: [..] This still isn't quite what I meant. My meaning was that mode would be disabled by default (unless all:true). How about: int copy_mode, copy_xattributes, copy_ownership; /* Set defaults. */ if (all) copy_mode = copy_xattributes = copy_ownership = 1; else copy_mode = copy_xattributes = copy_ownership = 0; /* If set in the original struct, copy those settings overriding * the defaults. */ if ((optargs_bitmask & GUESTFS_COPY_ATTRIBUTES_MOD...
2014 Jan 10
0
Re: RFC: copy-attributes command
...l flag is really a > > tristate. It can either be "true", "false" or "not specified". I see, I did not pay much attention to the use of optargs_bitmask outside the auto-generated RPC stuff the daemon code. > > Therefore I think it should be: > > xattributes:true # copies only xattrs and nothing else > > all:true # copies everything > > all:true xattributes:false # copies everything except xattrs > > > > In other words, 'all' changes the default (ie. "not specified") > &gt...
2008 Jun 12
3
DO NOT REPLY [Bug 5538] New: rsync -X does not work
...QAContact: rsync-qa@samba.org With the git source, the -X flag no-longer works. I suspect this problem was introduced fixing bug #5526. For a simple test case try: sudo mkdir /var2 sudo rsync -aX --link-dest=/var /var/. /var2/. ls -laZ /var2 You should see that /var2 does not have the correct xattributes. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
2008 Jun 12
1
DO NOT REPLY [Bug 5539] New: rsync -X does not work
...QAContact: rsync-qa@samba.org With the git source, the -X flag no-longer works. I suspect this problem was introduced fixing bug #5526. For a simple test case try: sudo mkdir /var2 sudo rsync -aX --link-dest=/var /var/. /var2/. ls -laZ /var2 You should see that /var2 does not have the correct xattributes. -- Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.
2014 Jan 10
0
Re: RFC: copy-attributes command
...M. Jones wrote: > On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > > +int > > +copy_xattrs (const char *src, const char *dest) > > +{ > > + abort (); > > +} > > Is this called in the case where someone does > > copy-attributes foo bar xattributes:true > > on a version of libguestfs with no support for xattrs? It's probably > better to silently ignore this case instead of crashing. This version shouldn't be ever called, since it is called when optgroup_linuxxattrs_available returns true, which is not the case in the !HA...
2014 Jan 13
0
Re: RFC: copy-attributes command
...014 16:53:32 Richard W.M. Jones wrote: > On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > [..] > > This still isn't quite what I meant. My meaning was that mode > would be disabled by default (unless all:true). OK. > How about: > > int copy_mode, copy_xattributes, copy_ownership; > > /* Set defaults. */ > if (all) > copy_mode = copy_xattributes = copy_ownership = 1; > else > copy_mode = copy_xattributes = copy_ownership = 0; > > /* If set in the original struct, copy those settings overriding > * the defaults. > */ >...
2015 Jun 23
10
[PATCH 0/7] Better testing of the guestfsd daemon.
Currently we are unable to properly run guestfsd (the daemon) under valgrind. Attempts to run valgrind inside the appliance have not been successful (see patch 1/7). However we desperately need better valgrind coverage of the daemon, particularly because it is doing a lot of complex parsing of program output. This has been a problem for a long time. A better way to attack this problem is to
2017 Apr 21
0
[PATCH 1/2] generator: Simplify the handling of string parameters.
...7 +8786,7 @@ This function is used internally when testing the appliance." }; { defaults with name = "copy_attributes"; added = (1, 25, 21); - style = RErr, [Pathname "src"; Pathname "dest"], [OBool "all"; OBool "mode"; OBool "xattributes"; OBool "ownership"]; + style = RErr, [String (Pathname, "src"); String (Pathname, "dest")], [OBool "all"; OBool "mode"; OBool "xattributes"; OBool "ownership"]; shortdesc = "copy the attributes of a path (file/...
2017 Apr 21
4
[PATCH 0/2] generator: Simplify the handling of string parameters.
Very large but mechanical change to the generator. Rich.
2017 Feb 21
1
[PATCH] generator: Put all the daemon procedure numbers (proc_nr)
This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.
2017 Feb 18
8
[PATCH 0/6] generator: Split up generator/actions.ml
Split up the huge generator/actions.ml into several smaller files. Rich.
2015 May 26
6
[PATCH 0/6] Update the way that API versions are generated for the man page.
The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.