search for: x86masmprint

Here's the new MASM backend. It has the following files :- lib/Target/X86/X86AsmPrinter.h lib/Target/X86/X86AsmPrinter.cpp lib/Target/X86/X86MASMPrinter.h lib/Target/X86/X86MASMPrinter.cpp lib/Target/X86/X86.td lib/Target/X86/X86InstrInfo.td lib/Target/X86/makefile Makefile.rules win32/x86/x86.vcproj X86AsmPrinter.{cpp|h} - have new variable 'forWindows' added which fits in with working wit...

...t cs.uiuc.edu> >Subject: [LLVMdev] MASM Backend >Date: Tue, 12 Jul 2005 00:16:02 +0100 > >Here's the new MASM backend. > >It has the following files :- > > lib/Target/X86/X86AsmPrinter.h > lib/Target/X86/X86AsmPrinter.cpp > lib/Target/X86/X86MASMPrinter.h > lib/Target/X86/X86MASMPrinter.cpp > lib/Target/X86/X86.td > lib/Target/X86/X86InstrInfo.td > lib/Target/X86/makefile > Makefile.rules > win32/x86/x86.vcproj > >X86AsmPrinter.{cpp|h} - have new variable 'forWindows'...

...therefore cannot be overriden ? > > Why does it need to be virtual? No 'intel' printers want % signs. The GAS intel code generator generates percents, look at the X86InstrInfo.td file it is full of them. The X86IntelAsmPrinter is not overridable and inheritable for this job. The X86MASMPrinter overrides too much for the Intel one to be useful. Aaron

...N8rr : I<0xEC, RawFrm, (ops), "in{b} {%dx, %al|AL, DX}">, Imp<[DX], [AL]>; For register allocatable values, changing printOp in the X86IntelAsmPrinter should do the job. > The X86IntelAsmPrinter is not overridable and inheritable for this job. The > X86MASMPrinter overrides too much for the Intel one to be useful. Again, there is *nothing* currently using the 'intel' asm printer. Feel free to change it however you find convenient... such as the above items. Also, when you do things like this, please send patches. Also, patches should generall...

...t;>, Imp<[DX], [AL]>; > > For register allocatable values, changing printOp in the > X86IntelAsmPrinter should do the job. Yes GNU AS works either with or without % symbols for its register names. So presumably we remove the percents from the intel generator and then have the X86MASMPrinter inherit from the X86IntelAsmPrinter as was originally intended. > Also, when you do things like this, please send patches. Also, patches > should generally be sent to the llvmbugs list (which is designed for bugs > and patches), not llvmdev. In response to your recent 'MASM Bac...

...the x86 namespaces to the X86 namespace. It's possible that the > problem I described above was causing this issue for you. No dont worry about that now. Just the X86 namespace was clashing with the X86 instruction enum when it was not nested under the LLVM namespace. I have written the X86MASMPrinter and will test it tommorow. It had to override behaviour right back to the AsmPrinter class as it had to override the basic 'gas' behaviour of the AsmPrinter class. I am not really sure whether to do a X86NASMPrinter or whether to bypass that for now and work on an X86COFFWriter which...

> You shouldn't have to add new classes to the .td file, just modify printOp > for your asmprinters. I dont think printOp is virtual and therefore cannot be overriden ? Aaron

On Tue, 12 Jul 2005, Aaron Gray wrote: >> You shouldn't have to add new classes to the .td file, just modify printOp >> for your asmprinters. > > I dont think printOp is virtual and therefore cannot be overriden ? Why does it need to be virtual? No 'intel' printers want % signs. -Chris -- http://nondot.org/sabre/ http://llvm.org/

...>> >> For register allocatable values, changing printOp in the X86IntelAsmPrinter >> should do the job. > > Yes GNU AS works either with or without % symbols for its register names. So > presumably we remove the percents from the intel generator and then have the > X86MASMPrinter inherit from the X86IntelAsmPrinter as was originally > intended. Please don't worry about preserving compatibility with GAS in Intel mode. GAS has several bugs in its support for intel mode that makes it hard to depend on. Feel free to change the current intel printer in any way to d...

...6 namespace. It's possible that the >> problem I described above was causing this issue for you. > > No dont worry about that now. Just the X86 namespace was clashing with the > X86 instruction enum when it was not nested under the LLVM namespace. Ok. > I have written the X86MASMPrinter and will test it tommorow. It had to > override behaviour right back to the AsmPrinter class as it had to override > the basic 'gas' behaviour of the AsmPrinter class. Ok. > I am not really sure whether to do a X86NASMPrinter or whether to bypass that > for now and work o...

On Fri, 1 Jul 2005, Aaron Gray wrote: > Okay, I have done as you have requested. Patch committed here: I made a couple of changes to the code you submitted. The most important is that I converted this (in the .h files): using namespace llvm; namespace x86 { ... into: namespace llvm { namespace x86 { ... The former defines the "..." stuff in the x86 namespace, the later defines

Chris, Okay, I have done as you have requested. The only thing I did not like was a clsh between the enum X86 and the new namespace X86, which I had to rename as x86 :( Anyway, I suppose the lower case 'x' in 'x86' fits in with the lowercase 'llvm' namespace. Build tested on MS VC2003 and Linux. Aaron -------------- next part -------------- A non-text attachment was