search for: writing_reviewable_cod

Hi, I haven't got any comments to add that haven't already been discussed but I thought it would be worth mentioning that Phabricator's documentation has a fairly good section on good commit messages at https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/#write-sensible-commit-me. > -----Original Message----- > From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] > On Behalf Of Renato Golin > Sent: 25 September 2014 17:15 > To: Reid Kleckner > Cc: Clang Dev; LLVM Dev > Subject: Re: [cfe-dev] [LLVMdev]...

That seems mostly reasonable. I'd try to make it more concise, though. The coding standards and developer policy docs should be short. +Commit message +-------------- + +Although we don't enforce the format of commit messages, there are general +guidelines that will help review, search in logs, email formatting and so on. +Mostly, the rules that apply are similar to other git