Displaying 5 results from an estimated 5 matches for "writer_".
Did you mean:
writers
2010 Jul 21
0
[LLVMdev] MC-JIT
...ng paren.
+ // Add common CodeGen passes.
+ if (addCommonCodeGenPasses(PM, OptLevel, DisableVerify, Ctx))
+ return true;
+ // Make sure the code model is set.
+ setCodeModelForJIT();
+
+ return false; // success!
+}
+
-void MCAssembler::Finish() {
+void MCAssembler::Finish(MCObjectWriter *Writer_) {
Why two variables Writer_ and Writer? I don't know of any rules against
modifying parameters.
...
- llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
- if (!Writer)
- report_fatal_error("unable to create object writer!");
+
+ llvm::OwningP...
2010 Jul 20
2
[LLVMdev] MC-JIT
... I'd also suggest changing the name of the
> method appropriately.
>
> - llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
> - if (!Writer)
> - report_fatal_error("unable to create object writer!");
> + MCObjectWriter *Writer = Writer_;
> + if (Writer == 0) {
> + Writer = getBackend().createObjectWriter(OS);
> + if (!Writer)
> + report_fatal_error("unable to create object writer!");
> + }
>
> It would be cleaner if you kept around the OwningPtr, but only
> assigned to it in t...
2010 Jul 21
1
[LLVMdev] MC-JIT
...(addCommonCodeGenPasses(PM, OptLevel, DisableVerify, Ctx))
> + return true;
> + // Make sure the code model is set.
> + setCodeModelForJIT();
> +
> + return false; // success!
> +}
> +
>
> -void MCAssembler::Finish() {
> +void MCAssembler::Finish(MCObjectWriter *Writer_) {
>
> Why two variables Writer_ and Writer? I don't know of any rules against
> modifying parameters.
>
> ...
>
> - llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
> - if (!Writer)
> - report_fatal_error("unable to create...
2010 Jul 20
0
[LLVMdev] MC-JIT
...ence
on, for example, x86-64. I'd also suggest changing the name of the
method appropriately.
- llvm::OwningPtr<MCObjectWriter> Writer(getBackend().createObjectWriter(OS));
- if (!Writer)
- report_fatal_error("unable to create object writer!");
+ MCObjectWriter *Writer = Writer_;
+ if (Writer == 0) {
+ Writer = getBackend().createObjectWriter(OS);
+ if (!Writer)
+ report_fatal_error("unable to create object writer!");
+ }
It would be cleaner if you kept around the OwningPtr, but only
assigned to it in the case where the writer take ownership...
2010 Jul 20
2
[LLVMdev] MC-JIT
> In the context of the JIT, there really is no such thing as a
> relocation, just fixups. I'm not completely sure what the right
> approach is, but the JIT should be able to fully resolve all of the
> symbols that are being used in the module. We may need some extra
> interfaces to allow the JIT to tell the MCAssembler about the address
> of some external symbols though.