search for: write_status

...vice, or > has a comparable way to find out that the device won't accept the > status it tried to write. Ugh, it actually caches the status in the transport :( > I can think of two solutions: > > (1) Introduce a new ccw that actually reads the device status. > (2) Make the WRITE_STATUS ccw fail (with a unit check) if the driver > sets FEATURES_OK after it tried to set features the device won't > accept. > > (1) is probably more generic, while (2) is more straightforward to > implement. > > Good thing we actually try to finally implement this, &...

...vice, or > has a comparable way to find out that the device won't accept the > status it tried to write. Ugh, it actually caches the status in the transport :( > I can think of two solutions: > > (1) Introduce a new ccw that actually reads the device status. > (2) Make the WRITE_STATUS ccw fail (with a unit check) if the driver > sets FEATURES_OK after it tried to set features the device won't > accept. > > (1) is probably more generic, while (2) is more straightforward to > implement. > > Good thing we actually try to finally implement this, &...

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index f3fe33a..a6d0cde 100644 ---

set FEATURES_OK as per virtio 1.0 spec Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- include/uapi/linux/virtio_config.h | 2 ++ drivers/virtio/virtio.c | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index f3fe33a..a6d0cde 100644 ---

...it tried to write. > > Ugh, it actually caches the status in the transport :( Well, it worked as long as this was unidirectional... > > > > I can think of two solutions: > > > > (1) Introduce a new ccw that actually reads the device status. > > (2) Make the WRITE_STATUS ccw fail (with a unit check) if the driver > > sets FEATURES_OK after it tried to set features the device won't > > accept. > > > > (1) is probably more generic, while (2) is more straightforward to > > implement. > > > > Good thing we actuall...

...quot; part now actually requires that the driver can get "status" from the device, or has a comparable way to find out that the device won't accept the status it tried to write. I can think of two solutions: (1) Introduce a new ccw that actually reads the device status. (2) Make the WRITE_STATUS ccw fail (with a unit check) if the driver sets FEATURES_OK after it tried to set features the device won't accept. (1) is probably more generic, while (2) is more straightforward to implement. Good thing we actually try to finally implement this, I did not notice this problem during...

...__u8 > +status_error_check(struct vring_desc *desc) > +{ > + if (le32toh(desc->len) != sizeof(__u8)) { > + mpsslog("%s() %d: length is not sizeof(status)\n", > + __func__, __LINE__); > + return -EIO; > + } > + return 0; > +} > + > +static int > +write_status(int fd, __u8 *status) > +{ > + struct iovec iovec; > + struct mic_copy_desc copy; > + > + iovec.iov_base = status; > + iovec.iov_len = sizeof(*status); > + copy.iov = &iovec; > + copy.iovcnt = 1; > + copy.vr_idx = 0; /* only one vring on virtio_block */ > + copy.u...

...__u8 > +status_error_check(struct vring_desc *desc) > +{ > + if (le32toh(desc->len) != sizeof(__u8)) { > + mpsslog("%s() %d: length is not sizeof(status)\n", > + __func__, __LINE__); > + return -EIO; > + } > + return 0; > +} > + > +static int > +write_status(int fd, __u8 *status) > +{ > + struct iovec iovec; > + struct mic_copy_desc copy; > + > + iovec.iov_base = status; > + iovec.iov_len = sizeof(*status); > + copy.iov = &iovec; > + copy.iovcnt = 1; > + copy.vr_idx = 0; /* only one vring on virtio_block */ > + copy.u...

...urn ioctl(fd, MIC_VIRTIO_COPY_DESC, &copy); +} + +static __u8 +status_error_check(struct vring_desc *desc) +{ + if (le32toh(desc->len) != sizeof(__u8)) { + mpsslog("%s() %d: length is not sizeof(status)\n", + __func__, __LINE__); + return -EIO; + } + return 0; +} + +static int +write_status(int fd, __u8 *status) +{ + struct iovec iovec; + struct mic_copy_desc copy; + + iovec.iov_base = status; + iovec.iov_len = sizeof(*status); + copy.iov = &iovec; + copy.iovcnt = 1; + copy.vr_idx = 0; /* only one vring on virtio_block */ + copy.update_used = true; /* Update used index */ + retur...

ChangeLog: ========= v1 => v2: a) License wording cleanup, sysfs ABI documentation, patch 1 refactoring into 3 smaller patches and function renames, as per feedback from Greg Kroah-Hartman. b) Use VRINGH infrastructure for accessing virtio rings from the host in patch 5, as per feedback from Michael S. Tsirkin. v1: Initial post @ https://lkml.org/lkml/2013/7/24/810 Description:

ChangeLog: ========= v1 => v2: a) License wording cleanup, sysfs ABI documentation, patch 1 refactoring into 3 smaller patches and function renames, as per feedback from Greg Kroah-Hartman. b) Use VRINGH infrastructure for accessing virtio rings from the host in patch 5, as per feedback from Michael S. Tsirkin. v1: Initial post @ https://lkml.org/lkml/2013/7/24/810 Description:

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)

An Intel MIC X100 device is a PCIe form factor add-in coprocessor card based on the Intel Many Integrated Core (MIC) architecture that runs a Linux OS. It is a PCIe endpoint in a platform and therefore implements the three required standard address spaces i.e. configuration, memory and I/O. The host OS loads a device driver as is typical for PCIe devices. The card itself runs a bootstrap after

An Intel MIC X100 device is a PCIe form factor add-in coprocessor card based on the Intel Many Integrated Core (MIC) architecture that runs a Linux OS. It is a PCIe endpoint in a platform and therefore implements the three required standard address spaces i.e. configuration, memory and I/O. The host OS loads a device driver as is typical for PCIe devices. The card itself runs a bootstrap after