search for: write_sparse

...+69,28 @@ return len; } int write_file(int f,char *buf,size_t len) { int ret = 0; - if (!sparse_files) { - return write(f,buf,len); - } - while (len>0) { - int len1 = MIN(len, SPARSE_WRITE_SIZE); - int r1 = write_sparse(f, buf, len1); + int r1; + if (sparse_files) { + int len1 = MIN(len, SPARSE_WRITE_SIZE); + r1 = write_sparse(f, buf, len1); + } else { + /* Normal writes are in this loop, too, so that */ +...

Hi, In fileio.c, function write_sparse() there is a bug that can lead to corrupt copies if the write() call only completes partially. for (l1 = 0; l1 < len && buf[l1] == 0; l1++) {} for (l2 = 0; l2 < len-l1 && buf[len-(l2+1)] == 0; l2++) {} sparse_seek += l1; if (l1 == len)...

...ze; static char last_byte; static size_t sparse_seek = 0; @@ -115,7 +116,7 @@ int write_file(int f,char *buf,size_t len) while (len > 0) { int r1; if (sparse_files > 0) { - int len1 = MIN(len, SPARSE_WRITE_SIZE); + int len1 = MIN(len, (size_t)sparse_files_block_size); r1 = write_sparse(f, buf, len1); } else { if (!wf_writeBuf) { diff --git a/options.c b/options.c index f2d23f6..aaffdc7 100644 --- a/options.c +++ b/options.c @@ -73,6 +73,7 @@ int remove_source_files = 0; int one_file_system = 0; int protocol_version = PROTOCOL_VERSION; int sparse_files = 0; +long sparse_...

https://bugzilla.samba.org/show_bug.cgi?id=13320 Bug ID: 13320 Summary: file contents cause rsync to fail (with certains args and dir structure) Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core

https://bugzilla.samba.org/show_bug.cgi?id=3925 Summary: rsync is unable to sync large (approx 4G) sparse files Product: rsync Version: 2.6.8 Platform: x86 OS/Version: Linux Status: NEW Severity: major Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy:

https://bugzilla.samba.org/show_bug.cgi?id=13317 Bug ID: 13317 Summary: rsync returns success when target filesystem is full Product: rsync Version: 3.1.2 Hardware: x64 OS: FreeBSD Status: NEW Severity: major Priority: P5 Component: core Assignee: wayned at samba.org