Displaying 9 results from an estimated 9 matches for "write_longint".
2003 Nov 29
1
bogus hardlinks bug?
dear rsyncists,
rsync is superb!
but did i actually find a bug?
i did:
$ rsync -vRHSPa rsync://rsync.mirror.ac.uk/updates.redhat.com/7.3/en/os/SRPMS .
into an empty local directory
the result was 140 bogus hardlinks of the same file:
-rw-rw-r-- 140 g g 6147582 2002/12/04 16:55:24 Canna-3.5b2-62.7.3.src.rpm
-rw-rw-r-- 140 g g 6147582 2002/12/04 16:55:24
2003 Mar 21
2
x>>32 warning in io.c
...32
Another 32 bit shift (<<32) at line 385 does not cause a warning because
of this test at line 379:
#ifdef NO_INT64
I verified that NO_INT64 is defined on my system in rsync.h
However there is no #ifdef NO_INT64 test protecting line 653.
Here are lines 652,653, and 654 from io.c in subr write_longint:
SIVAL(b,0,(x&0xFFFFFFFF));
SIVAL(b,4,((x>>32)&0xFFFFFFFF));
writefd(f,b,8);
On my system, x>>32 evaluates to the value x, not 0 (since the
shift count is invalid). This will cause the up...
2004 Jul 22
2
Strange behaviour rsync pull from sun to ppc linux, Integer overflow - attempted 64 bit offset
Hi,
I am running rsync on an embedded linux (ppc) like this:
rsync -avvv sun::file-system/ /rsyncexperiment
Where sun is a solaris machine that has rsync:
rsync version 2.5.7 protocol version 26
Copyright (C) 1996-2002 by Andrew Tridgell and others
<http://rsync.samba.org/>
Capabilities: 64-bit files, socketpairs, hard links, symlinks,
batchfiles, no IPv6, 64-bit system inums,
2002 Jan 13
0
rsynd-2.5.1 / io.c patches
...ned char * buf;
+ buf = (unsigned char *)buf1;
stats.total_written += len;
err_list_push();
@@ -560,7 +575,7 @@
void write_int(int f,int32 x)
{
- char b[4];
+ unsigned char b[4];
SIVAL(b,0,x);
writefd(f,b,4);
}
@@ -573,7 +588,7 @@
void write_longint(int f, int64 x)
{
extern int remote_version;
- char b[8];
+ unsigned char b[8];
if (remote_version < 16 || x <= 0x7FFFFFFF) {
write_int(f, (int)x);
@@ -587,13 +602,13 @@
writefd(f,b,8);
}
-void write_buf(int f,char *buf,int len)
+v...
2004 Apr 10
0
patches for copying atimes
...;
+ if (protocol_version > 28) {
+ if (file->atime == atime)
+ flags |= XMIT_SAME_ATIME;
+ else
+ atime = file->atime;
+ }
#if SUPPORT_HARD_LINKS
if (file->link_u.idev) {
@@ -439,6 +446,8 @@
write_longint(f, file->length);
if (!(flags & XMIT_SAME_TIME))
write_int(f, modtime);
+ if (protocol_version > 28 && !(flags & XMIT_SAME_ATIME))
+ write_int(f, atime);
if (!(flags & XMIT_SAME_MODE))
write_int(f, to_wire_mode(mode));
if (preserve_uid && !(flags &...
2006 Jan 24
1
propagate atimes with rsync-2.6.6 (fwd)
...= 0, mode = 0;
dev = 0, rdev = makedev(0, 0);
rdev_major = 0;
uid = 0, gid = 0;
@@ -379,6 +381,8 @@
else
modtime = file->modtime;
+ acctime = file->acctime;
+
#ifdef SUPPORT_HARD_LINKS
if (file->link_u.idev) {
if (file->F_DEV == dev) {
@@ -431,6 +435,8 @@
write_longint(f, file->length);
if (!(flags & XMIT_SAME_TIME))
write_int(f, modtime);
+ if (remote_protocol >= 30)
+ write_int(f, acctime);
if (!(flags & XMIT_SAME_MODE))
write_int(f, to_wire_mode(mode));
if (preserve_uid && !(flags & XMIT_SAME_UID)) {
@@ -506,6 +512,7 @@...
2004 Apr 20
1
improved atime patch
...;
+ if (protocol_version > 28) {
+ if (file->atime == atime)
+ flags |= XMIT_SAME_ATIME;
+ else
+ atime = file->atime;
+ }
#if SUPPORT_HARD_LINKS
if (file->link_u.idev) {
@@ -443,6 +450,8 @@
write_longint(f, file->length);
if (!(flags & XMIT_SAME_TIME))
write_int(f, modtime);
+ if (protocol_version > 28 && !(flags & XMIT_SAME_ATIME))
+ write_int(f, atime);
if (!(flags & XMIT_SAME_MODE))
write_int(f, to_wire_mode(mode));
if (preserve_uid && !(flags &...
2004 Jul 12
2
[PATCH] Batch-mode rewrite
...ing child processes,
***************
*** 125,130 ****
--- 127,151 ----
return;
}
+ /* CAS: I think that this is a good candidate for a protocol
+ * change. Instead of making the protocol depend on
+ * am_server, I think this should be a simple:
+ *
+ * if (am_sender)
+ * write_longint stuff;
+ * else
+ * read_longing stuff;
+ *
+ * This would have several advantages: 1) It simplifies the
+ * protocol by removing variation based on server-ness. 2) It
+ * makes the client_run()-if(am_sender) path look more like
+ * do_server_sender (ideally, these should be the...
2003 Oct 03
2
Cygwin/rsync Hang Problem Testing Results
People of cygwin & rsync,
I recently attempted to get cygwin and rsync working to solve a
backup/mirroring need in my computer life. Well, as you might guess, I
ran into a little but of trouble.
Strangely enough, rsync seemed to be regularly hanging when I attempted
to do a "get" (sycronize a remote to a local dir). Well, considering I
want to automate this, that was not going