search for: write_iff_headers

The commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=99257e177eac96fa41a107b423080232f59ebe45 also requires some changes in write_iff_headers() function: currently flac don't write WAVEFORMATEXTENSIBLE header if decoder_session->channel_mask is equal to 0, 1 or 3. After the commit 99257e17 flac should do this for channel_mask equal to 0, 4 or 3. The patch fixes this. -------------------------- Also, I have a question. Curren...

...k) + size.QuadPart += d->foreign_metadata->blocks[i].size; + } + } + + if(SetFilePointerEx(fh, size, NULL, FILE_CURRENT)) /* tell filesystem the expected filesize to eliminate fragmentation */ + SetEndOfFile(fh); + } + CloseHandle(fh); + } + } +#endif if(!write_iff_headers(d->fout, d, d->total_samples)) { d->abort_flag = true; return false;

...RENT)) /* tell filesystem the expected filesize to eliminate fragmentation */ + SetEndOfFile(fh); + } + CloseHandle(fh); + } + } +#endif + /* write the WAVE/AIFF headers if necessary */ if(!d->analysis_mode && !d->test_only && d->format != FORMAT_RAW) { if(!write_iff_headers(d->fout, d, d->total_samples)) {

lvqcl wrote: > The commit http://git.xiph.org/?p=flac.git;a=commitdiff;h=99257e177eac96fa41a107b423080232f59ebe45 > also requires some changes in write_iff_headers() function: > > currently flac don't write WAVEFORMATEXTENSIBLE header if > decoder_session->channel_mask is equal to 0, 1 or 3. > After the commit 99257e17 flac should do this for channel_mask > equal to 0, 4 or 3. > > The patch fixes this. Applied, thanks. > ---...

...k) + size.QuadPart += d->foreign_metadata->blocks[i].size; + } + } + + if(SetFilePointerEx(fh, size, NULL, FILE_CURRENT)) /* tell filesystem the expected filesize to eliminate fragmentation */ + SetEndOfFile(fh); + } + CloseHandle(fh); + } + } +#endif if(!write_iff_headers(d->fout, d, d->total_samples)) { d->abort_flag = true; return false;

Can you please wrap the setvbuf in _WIN32 IFDEFs too? Currently memory usage of FLAC decoding is about 1MB, so this patch is increasing memory usage tenfold, also for platforms that do not need this. It is a non-problem on my system anyway. Op 26-09-14 om 10:36 schreef Janne Hyv?rinen: > I made some changes to the previous patch. I don't know why I > originally didn't put the

Decoding flac files is also prone to producing fragmented files. NTFS has the ability to completely avoid fragmentation if it is told the file size before hand, but that would require using special Windows-only functions. Increasing the write buffer from the default 512 bytes to 10 MB already reduces the problem tremendously. -------------- next part -------------- diff --git