search for: write_delay

...y to a new delay filter so that it can be used > with any plugin. > --- > +/* Write data. */ > +static int > +delay_pwrite (struct nbdkit_next *next, void *nxdata, > + void *handle, > + const void *buf, uint32_t count, uint64_t offset) > +{ > + write_delay (); > + return next->pwrite (nxdata, buf, count, offset); > +} > + > +/* Zero data. */ > +static int > +delay_zero (struct nbdkit_next *next, void *nxdata, > + void *handle, uint32_t count, uint64_t offset, int may_trim) > +{ > + write_delay (); > + re...

...} + } +} + +static void +delay (int ms) +{ + if (ms > 0) { + const struct timespec ts = { + .tv_sec = ms / 1000, + .tv_nsec = (ms * 1000000) % 1000000000 + }; + nanosleep (&ts, NULL); + } +} + +static void +read_delay (void) +{ + delay (rdelayms); +} + +static void +write_delay (void) +{ + delay (wdelayms); +} + +/* Called for each key=value passed on the command line. */ +static int +delay_config (nbdkit_next_config *next, void *nxdata, + const char *key, const char *value) +{ + if (strcmp (key, "rdelay") == 0) { + rdelayms = parse_delay (valu...

On Wed, Jan 17, 2018 at 04:38:04PM -0600, Eric Blake wrote: > > +/* Zero data. */ > > +static int > > +delay_zero (struct nbdkit_next *next, void *nxdata, > > + void *handle, uint32_t count, uint64_t offset, int may_trim) > > +{ > > + write_delay (); > > + return next->zero (nxdata, count, offset, may_trim); > > If next->zero() fails with EOPNOTSUPP, that means we will delay once in > trying the underlying command, and again for each iteration of the > fallback loop as it calls delay_pwrite(). Is that okay, or do...

...used >> with any plugin. >> --- > >> +/* Write data. */ >> +static int >> +delay_pwrite (struct nbdkit_next *next, void *nxdata, >> + void *handle, >> + const void *buf, uint32_t count, uint64_t offset) >> +{ >> + write_delay (); >> + return next->pwrite (nxdata, buf, count, offset); >> +} >> + >> +/* Zero data. */ >> +static int >> +delay_zero (struct nbdkit_next *next, void *nxdata, >> + void *handle, uint32_t count, uint64_t offset, int may_trim) >> +{ &g...

...t_ops->pread (nxdata, buf, count, offset); } /* Write data. */ static int -delay_pwrite (struct nbdkit_next *next, void *nxdata, +delay_pwrite (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle, const void *buf, uint32_t count, uint64_t offset) { write_delay (); - return next->pwrite (nxdata, buf, count, offset); + return next_ops->pwrite (nxdata, buf, count, offset); } /* Zero data. */ static int -delay_zero (struct nbdkit_next *next, void *nxdata, +delay_zero (struct nbdkit_next_ops *next_ops, void *nxdata, void *handle, uin...

This patch isn't complete (patch 6/6 isn't finished) so it's just for discussion, although it does compile and run. This introduces to nbdkit a concept of "filters" which can be placed in front of plugins to modify their behaviour. Some examples where you might use filters: * Serve a subset of the data, such as (offset, range) or a single partition from a disk image.

Rebased filters patch. Requires current git master + the locks / thread model fix (https://www.redhat.com/archives/libguestfs/2018-January/msg00128.html) So a few changes here since last time: The "introduce filters" and "implement filters" patches are squashed together. I introduced a concept of .prepare and .finalize. These run before and after the data serving phase

The first three patches are identical to: https://www.redhat.com/archives/libguestfs/2018-January/msg00079.html "[PATCH nbdkit v2 0/3] Refactor plugin_* functions into a backend" The rest of the patches add filters using the new filter API previously described here: https://www.redhat.com/archives/libguestfs/2018-January/msg00073.html This needs a lot more testing -- and tests --

This is still tentative and needs a lot of work, but: - partition filter works, supporting MBR & GPT - prepare and finalize methods fixed - open method can now be changed (allowing readonly flag to be modified) - thread_model can be limited I believe I made most of the changes which were previously suggested in email. I think the only one I didn't was preventing inclusion of both

A combination of the work that both Rich and I have been doing lately, where filters use only the new API with flags on every command that the client can send over the wire (we can then add support for more flags in nbdkit without having to add new callbacks, as NBD adds more flags upstream). Eric Blake (4): protocol: Split flags from cmd field in requests backend: Pass flags argument through

After more than a month since v2 [1], I've finally got my FUA support series polished. This is all of my outstanding patches, even though some of them were originally posted in separate threads from the original FUA post [2], [3] [1] https://www.redhat.com/archives/libguestfs/2018-January/msg00113.html [2] https://www.redhat.com/archives/libguestfs/2018-January/msg00219.html [3]