search for: wrap_id3

Hi, this is a patch to fix a bug in the XMMS plugin. The problem is that with the current version (1.1.0) it is impossible to get the year field to show up in the playlist, even if it's properly set in the file. The diff below fixes the problem. Tyler Eaves bash-2.05b$ diff -C 1 wrap_id3.c /usr/portage/distfiles/flac-1.1.0/src/plugin_xmms/wrap_id3.c *** wrap_id3.c Fri Jul 16 18:28:35 2004 --- /usr/portage/distfiles/flac-1.1.0/src/plugin_xmms/wrap_id3.c Thu Jan 2 02:18:57 2003 *************** *** 105,107 **** input->track_number = local__getnum(tag.track_number);...

...finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -g -O2 -I/sw/include -I/sw/include/xmms -I/sw/include/gtk-1.2 -I/sw/include/glib-1.2 -I/sw/lib/glib/include -I/usr/X11R6/include -o libxmms-flac.la -rpath /sw/lib/xmms/Input -module -avoid-version charset.lo configure.lo plugin.lo wrap_id3.lo fileinfo.lo ../../src/plugin_common/libplugin_common.a ../../src/share/grabbag/libgrabbag.a ../../src/share/gain_analysis/libgain_analysis.a ../../src/share/utf8/libutf8.a ../../src/libFLAC/libFLAC.la -L../../src/libFLAC/.libs -L/sw/lib -L/sw/lib -L/usr/X11R6/lib -lgtk -lgdk -lgmodule -lgl...

I have been using Apple's X11 on OS X and I got the source and compiled flac 1.0.5 beta2. Everything seemed to build and install OK, but the xmms-flac plugin is not working, and I cannot open xmms. I get the following error when I launch xmms from xterm: brian it's 8:41pm, what now? xmms & [1] 567 brian it's 8:41pm, what now? dyld: xmms Undefined symbols:

...d3-dev [...] > **** The following central src deps are (probably) missing: > libogg-dev (>= 1.0.0) [...] > (cd . && ln -s charset.lo charset.o) > (cd . && ln -s configure.lo configure.o) > (cd . && ln -s plugin.lo plugin.o) > (cd . && ln -s wrap_id3.lo wrap_id3.o) > gcc -shared charset.lo configure.lo plugin.lo wrap_id3.lo -Wl,--rpath -Wl,/build/buildd/flac-1.0.4/src/libFLAC/.libs -L/usr/lib/gcc-lib/hppa-linux/3.0.3/../../.. -L/usr/lib/gcc-lib/hppa-linux/3.0.3 ../../src/plugin_common/libplugin_common.a ../../src/libFLAC/.libs/libFLAC.so...

...ll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -I/sw/include -I/sw/include/xmms -I/sw/include/gtk-1.2 -I/sw/include/glib-1.2 -I/sw/lib/glib/include -I/usr/X11R6/include -o libxmms-flac.la -rpath /sw/lib/xmms/Input -module -avoid-version charset.lo configure.lo plugin.lo wrap_id3.lo fileinfo.lo ../../src/plugin_common/libplugin_common.a ../../src/share/grabbag/libgrabbag.a ../../src/share/gain_analysis/libgain_analysis.a ../../src/share/utf8/libutf8.a ../../src/libFLAC/libFLAC.la -L../../src/libFLAC/.libs -L/sw/lib -L/sw/lib -L/usr/X11R6/lib -lgtk -lgdk -lgmodule -lgl...

Well, I've rebuilt flac from the original source, without using the NetBSD package system, and I'm still seeing the same problem with the XMMS FLAC plugin: /usr/pkg/lib/xmms/Input/libxmms-flac.so: Undefined PLT symbol "FLAC__plugin_common__init_dither_context" (symnum = 30) I can see that the symbol is defined in the common library: $ nm src/plugin_common/libplugin_common.a |

...t is still playing. This might be considered a bug, but it's the same behavior as in the mpg123 input plugin. ,steven. *** old/Makefile.am Thu Feb 6 21:43:02 2003 --- Makefile.am Thu Jun 5 16:36:54 2003 *************** *** 25,31 **** noinst_HEADERS = \ charset.h \ configure.h \ ! wrap_id3.h CFLAGS = @CFLAGS@ @ID3LIB_CFLAGS@ @XMMS_CFLAGS@ INCLUDES = -I$(top_srcdir)/src --- 25,33 ---- noinst_HEADERS = \ charset.h \ configure.h \ ! wrap_id3.h \ ! http.h \ ! plugin.h CFLAGS = @CFLAGS@ @ID3LIB_CFLAGS@ @XMMS_CFLAGS@ INCLUDES = -I$(top_srcdir)/src *************** *...

...nctions -Wall -W -Winline > -DFLaC__INLINE=__inline__ -I/sw/include -I/sw/include/xmms > -I/sw/include/gtk-1.2 -I/sw/include/glib-1.2 -I/sw/lib/glib/include > -I/usr/X11R6/include -o libxmms-flac.la -rpath /sw/lib/xmms/Input > -module -avoid-version charset.lo configure.lo plugin.lo wrap_id3.lo > fileinfo.lo ../../src/plugin_common/libplugin_common.a > ../../src/share/grabbag/libgrabbag.a > ../../src/share/gain_analysis/libgain_analysis.a > ../../src/share/utf8/libutf8.a ../../src/libFLAC/libFLAC.la > -L../../src/libFLAC/.libs -L/sw/lib -L/sw/lib -L/usr/X11R6/lib -l...

...are these two calls necessary? */ flac_ip.output->buffer_free(); flac_ip.output->buffer_free(); + + g_free(file_info_.title); pthread_exit(NULL); return 0; /* to silence the compiler warning about not returning a value */ -------------- next part -------------- --- src/plugin_xmms/wrap_id3.c.orig 2002-11-07 18:40:44.000000000 +0100 +++ src/plugin_xmms/wrap_id3.c 2002-11-09 11:41:23.000000000 +0100 @@ -98,6 +98,8 @@ XMMS_NEW_TITLEINPUT(input); input->performer = local__getstr(tag.performer); + if (!input->performer) + input->performer = local__getstr(tag.composer); i...

On Fri, Nov 08, 2002 at 12:39:52PM -0800, Josh Coalson wrote: > --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > I have few notes: > > > > It seems there is changed API in CVS again. So, what about adding > > function like > > unsigned FLAC__format_frame_size(const FLAC__Frame *frame) > > which returns size of the frame in bytes. This

...e.am,v retrieving revision 1.18 diff -u -r1.18 Makefile.am --- src/plugin_xmms/Makefile.am 14 Nov 2002 04:57:46 -0000 1.18 +++ src/plugin_xmms/Makefile.am 15 Nov 2002 20:05:39 -0000 @@ -36,7 +36,7 @@ xmmsinputplugin_LTLIBRARIES = libxmms-flac.la -plugin_sources = charset.c configure.c plugin.c wrap_id3.c +plugin_sources = charset.c configure.c plugin.c wrap_id3.c fileinfo.c if FLaC__HAS_ID3LIB libxmms_flac_la_SOURCES = $(plugin_sources) Index: src/plugin_xmms/fileinfo.c =================================================================== RCS file: /cvsroot/flac/flac/src/plugin_xmms/fileinfo.c,...

On Wednesday, February 5, 2003, at 10:47 PM, Josh Coalson wrote: > --- Matt Zimmerman <mdz@debian.org> wrote: > > good, very good. it may take me a little bit to get to it > since I'm starting a new job next week. > > Ben, can you inspect the patch and confirm that it covers > what you also suggested? The patch fixed the problem with your libs. However, when