search for: woverload

I've long been an advocate of using -Woverloaded-virtual. The thing with this option is that it can REALLY help catch some nasty inheritance bugs. I'm running into these as I'm designing the bytecode analyzer interface. I make a change to the interface, forget to change a subclass, and bingo, that method doesn't get called any more...

...g I've just created a new unrelated method. Ya know, I think that everyone has done that at least once (myself included)... on THAT VERY METHOD. grr :) I definitely think that it would be a good idea to add this -W flag :) > After spending some time on this, I've decided to add > -Woverloaded-virtual option to compiler to catch such cases. However, it > also gives some warnings on LLVM code: > > ../../../include/llvm/Pass.h:264: warning: `virtual bool > llvm::FunctionPass::run(llvm::Module&)' was hidden > ../../../include/llvm/Pass.h:326: warning: by `bool...

I've just had some fun, because I wanted to override FunctionPass::addAnalysisUsage, but forgot "const" after the method name -- so instead of overriding I've just created a new unrelated method. After spending some time on this, I've decided to add -Woverloaded-virtual option to compiler to catch such cases. However, it also gives some warnings on LLVM code: ../../../include/llvm/Pass.h:264: warning: `virtual bool llvm::FunctionPass::run(llvm::Module&)' was hidden ../../../include/llvm/Pass.h:326: warning: by `bool llvm::BasicBlockP...

All, As of today, LLVM will be built with the -Woverloaded-virtual option turned on. This means that warnings will be generated for ambiguous overloads of C++ sub-classes. Typically this means you forgot to override an overloaded virtual in a subclass. Currently, LLVM is "overloaded virtual" clean. We intend to keep it that way. If you are mod...

...had some fun, because I wanted to override > > FunctionPass::addAnalysisUsage, but forgot "const" after the method name -- > > so instead of overriding I've just created a new unrelated method. > > > > After spending some time on this, I've decided to add -Woverloaded-virtual > > option to compiler to catch such cases. However, it also gives some warnings > > on LLVM code: > > > > ../../../include/llvm/Pass.h:264: warning: `virtual bool > > llvm::FunctionPass::run(llvm::Module&)' was hidden > > ../../../include/ll...

...te loop. Is there anything wrong? How to correct? --------------------------------- /bin/sh ./libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I. -I./common -I./include -Wall -W -Wredundant-decls -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wformat-security -fno-gnu-keywords -Woverloaded-virtual -Wundef -Wshadow -Wstrict-null-sentinel -Wshadow -fvisibility=hidden -g -O2 -MT matcher/branchpostlist.lo -MD -MP -MF $depbase.Tpo -c -o matcher/branchpostlist.lo matcher/branchpostlist.cc &&\ mv -f $depbase.Tpo $depbase.Plo g++ -DHAVE_CONFIG_H -I. -I./common -I./include -W...

...): No such file or directory hendrik at lovesong:~/dv/lang/hlvm$ So I execute the script by itself, and get hendrik at lovesong:~/dv/lang/hlvm$ llvm-config --cxxflags -I/usr/include/llvm -D_DEBUG -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -O2 -fomit-frame-pointer -DLLVM_DEBIAN_INFO= (Debian 2.2-7) -Woverloaded-virtual hendrik at lovesong:~/dv/lang/hlvm$ Putting that output into the command, and removing the -DLLVM_DEBIAN_INFO= (Debian 2.2-7) from it, things work as well as one might expect for a program without main(): hendrik at lovesong:~/dv/lang/hlvm$ g++ -o broken.o -I/usr/include/llvm -D_DEB...

...=================== During the compilation I get the following error: ==================================== /bin/bash ./libtool --tag=CXX --mode=link g++ -fshow-column -Wall -W -Wredundant-decls -Wpointer-arith -Wcast-qual -Wcast-align -Wno-long-long -Wformat-security -fno-gnu-keywords -Wundef -Woverloaded-virtual -Wstrict-null-sentinel -Wshadow -Wstrict-overflow=1 -Wlogical-op -Wmissing-declarations -Wdouble-promotion -Winit-self -fvisibility=hidden -g -O2 -std=gnu++11 -o bin/xapian-delve bin/xapian-delve.o libgetopt.la libxapian-1.3.la libtool: link: g++ -fshow-column -Wall -W -Wredundant-decl...

...unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -Wl,-allow-shlib-undefined -Wl,-rpath-link,/home/laguest/src/mine-new/llvm/llvm-project/build/./lib -Wl,-O3 -Wl,--gc-sections tools/clang/tools/extra/clang-change-namespace/tool/CMakeFiles/clang-change-namespace.dir/ClangChangeNamespace.cpp.o -o bin/...

...4/include -I/Users/me/Work/ code/synphony/llvmllila/build/include -I/Users/me/Work/code/synphony/ llvmllila/build/tools/llx -I/Users/me/Work/code/synphony/llvmllila/ include -I/Users/me/Work/code/synphony/llvmllila/tools/llx -D_DEBUG - D_GNU_SOURCE -D__STDC_LIMIT_MACROS -O3 -fno-exceptions -Woverloaded- virtual -pedantic -Wall -W -Wwrite-strings -Wno-long-long -Wunused - Wno-unused-parameter -fstrict-aliasing -Wstrict-aliasing -O3 -rpath / Users/me/Work/code/synphony/llvmllila/build/Release//bin -export- dynamic -L/Users/me/Work/code/synphony/llvmllila/build/Release//lib -L/ Users/me/Wor...

...ib/libpsapi.a | grep "GetProcessMemoryInfo" - returns: 00000000 T _GetProcessMemoryInfo at 12 00000000 I __imp__GetProcessMemoryInfo at 12 And llvm-config seems to be asking for them to be picked up: -I//include -D_DEBUG -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -O2 -fomit-frame-pointer -Woverloaded-virtual -L//lib -lpsapi -limagehlp -lm -lLLVMCore -lLLVMSupport -lLLVMSystem So I'm still mystified. Best regards, Duncan

...me/nlewycky/llvm/tools/llvmc/driver' llvm[3]: Linking Debug executable llvmc g++ -DLLVMC_BUILTIN_PLUGIN_1=Base -DLLVMC_BUILTIN_PLUGIN_2=Clang -I/home/nlewycky/llvm/include -I/home/nlewycky/llvm/tools/llvmc/driver -D_DEBUG -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -g -fPIC -Woverloaded-virtual -pedantic -Wno-long-long -Wall -W -Wno-unused-parameter -Wwrite-strings -lCompilerDriver -g -Wl,-R -Wl,/home/nlewycky/llvm/Debug/bin -Wl,-export-dynamic -L/home/nlewycky/llvm/Debug/lib -L/home/nlewycky/llvm/Debug/lib -o /home/nlewycky/llvm/Debug/bin/llvmc /home/nlewycky/llvm/tools/llv...

...e VERBOSE=1 > llvm[0]: Compiling CGFPass.cpp for Debug+Asserts build (PIC) > if g++ -I/home/cafxx/Projects/llvm2/include > -I/home/cafxx/Projects/llvm2/lib/Transforms/cgf -D_DEBUG > -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -g > -fno-exceptions -fno-rtti -fPIC -Woverloaded-virtual -Wcast-qual > -pedantic -Wno-long-long -Wall -W -Wno-unused-parameter > -Wwrite-strings -c -MMD -MP -MF > "/home/cafxx/Projects/llvm2/lib/Transforms/cgf/Debug+Asserts/CGFPass.d.tmp" > -MT > "/home/cafxx/Projects/llvm2/lib/Transforms/cgf/Debug+Asserts...

...e/Work/ > code/synphony/llvmllila/build/include -I/Users/me/Work/code/synphony/ > llvmllila/build/tools/llx -I/Users/me/Work/code/synphony/llvmllila/ > include -I/Users/me/Work/code/synphony/llvmllila/tools/llx -D_DEBUG - > D_GNU_SOURCE -D__STDC_LIMIT_MACROS -O3 -fno-exceptions -Woverloaded- > virtual -pedantic -Wall -W -Wwrite-strings -Wno-long-long -Wunused - > Wno-unused-parameter -fstrict-aliasing -Wstrict-aliasing -O3 -rpath / > Users/me/Work/code/synphony/llvmllila/build/Release//bin -export- > dynamic -L/Users/me/Work/code/synphony/llvmllila/build/Release//l...

...llvm-svn> which llvm-config > /home/melis/llvm/bin/llvm-config > melis at juggle2:~/c/llvm-svn> llvm-config --cxxflags --ldflags --libs core > -I/home/melis/llvm/include -D_DEBUG -D_GNU_SOURCE > -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -O3 -fomit-frame-pointer > -fPIC -Woverloaded-virtual > -L/home/melis/llvm/lib -lpthread -ldl -lm -lelf > -lLLVMCore -lLLVMSupport -lLLVMSystem > > melis at juggle2:~/c/llvm-svn-build> cmake /home/melis/c/llvm-svn > -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/home/melis/llvm-cmake > -DLLVM_ENABLE_THREADS=ON >...

...o" - > > returns: > > 00000000 T _GetProcessMemoryInfo at 12 > 00000000 I __imp__GetProcessMemoryInfo at 12 > > And llvm-config seems to be asking for them to be picked up: > > -I//include -D_DEBUG -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -O2 > -fomit-frame-pointer -Woverloaded-virtual > -L//lib -lpsapi -limagehlp -lm > -lLLVMCore -lLLVMSupport -lLLVMSystem > > So I'm still mystified. Put them at the end of the library list: -lLLVMCore -lLLVMSupport -lLLVMSystem -limagehlp -lpsapi -lm Unless recently changed, mingw's ld resolves symbols sequentia...

On May 8, 2009, at 1:02 PM, Chris Lattner wrote: > This goes against our general direction for llvm libraries: they > should generally all be built pic. After reviewing yet more of the Makefile,rules file, I believe ENABLE_PIC is the right thing to check. Currently ENABLE_PIC has to be set to get shared bits built, if the user wants them. Given that, we can use that to control

...rules (revision 71270) +++ clang/Makefile.rules (working copy) @@ -338,6 +338,11 @@ C.Flags += -fPIC endif endif +else + ifeq ($(OS),Darwin) + CXX.Flags += -mdynamic-no-pic + C.Flags += -mdynamic-no-pic + endif endif CXX.Flags += $(CXXFLAGS) -Woverloaded-virtual is the patch I had in mind. Any objections?

I updated my from LLVM 2.7 to 2.8/trunk tonight and was mystified as to why my GC plugin silently stopped working. The problem was that the signature of the virtual function GCMetadataPrinter::finishAssembly (and beginAssembly) changed. This change would probably be an excellent candidate for the "gotchas" section of the 2.8 release notes. Thanks! -- Ben -------------- next part

Hi Ben, > I updated my from LLVM 2.7 to 2.8/trunk tonight and was mystified as to why my > GC plugin silently stopped working. > > The problem was that the signature of the virtual function > GCMetadataPrinter::finishAssembly (and beginAssembly) changed. > > This change would probably be an excellent candidate for the "gotchas" section > of the 2.8 release notes.