search for: with_hive_writ

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

...; + | 5, 1 -> > + let key_path = ["Policies"; "Microsoft"; "Windows"; "DeviceInstall"; > + "Settings"] in > + let name = "SuppressNewHWUI" in > + let value = Windows.with_hive_write g software_hive_filename ( > + fun root -> > + set_reg_val_dword_1 root key_path name > + ) in > + reg_restore ("HKLM\\Software" :: key_path) name value > + > + (* WinXP 64bit / Win2k3 *) > + | 5, 2 -> &gt...

...; + | 5, 1 -> > + let key_path = ["Policies"; "Microsoft"; "Windows"; "DeviceInstall"; > + "Settings"] in > + let name = "SuppressNewHWUI" in > + let value = Windows.with_hive_write g software_hive_filename ( > + fun root -> > + set_reg_val_dword_1 root key_path name > + ) in > + reg_restore ("HKLM\\Software" :: key_path) name value > + > + (* WinXP 64bit / Win2k3 *) > + | 5, 2 -> &gt...

Wait for driver installations fired by the PnP manager to complete before running firstboot scripts. The first patch is a minor refactoring to pave the way for the second patch. The latter contains the bulk of the changes as well as the description of the idea. Roman Kagan (2): v2v:windows: factor out getting CurrentControlSet v2v:windows: prevent conflicts with PnP on firstboot --- v1

...if errorlevel 3010 exit /b 0 > ignore (g#pwrite_device rootpart bytes 0x1a_L) > ) > ) > + > + and fix_win_esp () = > + let fix_win_uefi_bcd esp_path = > + try > + let bcd_path = "/EFI/Microsoft/Boot/BCD" in > + Windows.with_hive_write g (esp_path ^ bcd_path) ( > + (* Remove the 'graphicsmodedisabled' key in BCD *) > + fun root -> > + let path = ["Objects"; "{9dea862c-5cdd-4e70-acc1-f32b344d4795}"; > + "Elements"; "23000003&...

...output rcaps = +let convert (g : G.guestfs) inspect source output rcaps force_interfaces = (*----------------------------------------------------------------------*) (* Inspect the Windows guest. *) @@ -228,6 +228,8 @@ let convert (g : G.guestfs) inspect source output rcaps = Registry.with_hive_write g inspect.i_windows_software_hive update_software_hive; + configure_network_interfaces net_driver; + fix_ntfs_heads (); fix_win_esp (); @@ -603,6 +605,77 @@ if errorlevel 3010 exit /b 0 | None -> warning (f_"could not find registr...

...source output rcaps = +let convert (g : G.guestfs) inspect source output rcaps static_ips = (*----------------------------------------------------------------------*) (* Inspect the Windows guest. *) @@ -228,6 +228,8 @@ let convert (g : G.guestfs) inspect source output rcaps = Registry.with_hive_write g inspect.i_windows_software_hive update_software_hive; + configure_network_interfaces net_driver; + fix_ntfs_heads (); fix_win_esp (); @@ -603,6 +605,77 @@ if errorlevel 3010 exit /b 0 | None -> warning (f_"could not find registr...

--- v2v/windows.ml | 24 ++++++++++++++++++++++++ v2v/windows.mli | 6 ++++++ 2 files changed, 30 insertions(+) diff --git a/v2v/windows.ml b/v2v/windows.ml index 23d589b00..dde64e677 100644 --- a/v2v/windows.ml +++ b/v2v/windows.ml @@ -19,6 +19,7 @@ open Printf open Common_gettext.Gettext +open Std_utils open Tools_utils open Utils @@ -45,3 +46,26 @@ and check_app { Guestfs.app2_name

Patch v2 was here: https://www.redhat.com/archives/libguestfs/2019-April/thread.html#00114 There's no change here except that I've rebased it against the latest master branch and retested. There was a comment by Pino (https://www.redhat.com/archives/libguestfs/2019-April/msg00117.html) which isn't incorporated into this patch. Rich.

This patch is just for discussion. There are still a couple of issues that I'm trying to fix. One is that all of the test guests I have, even ones with static IPs, have multiple interfaces, some using DHCP, so the conditions for adding the Powershell script don't kick in. This makes testing very awkward. However a bigger issue is that I think the premise is wrong. In some registries

Yaniv pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1438794 that virt-v2v both doesn't install the virtio-rng driver for Windows, and doesn't give the guest a virtio-rng PCI device either. There are two problems here: Firstly the Windows virtio-rng driver isn't included in the exploded tree (/usr/share/virtio-win) so it doesn't get copied into the guest. The solution

v1 was here with much discussion: https://www.redhat.com/archives/libguestfs/2018-December/msg00048.html v2: - Fix the case where there are multiple interfaces. Note this does not preserve order correctly (see patch for comment on why that is a hard problem). - Preserve name servers. This patch is still for discussion only. I'd like to see what might be done to get this upstream

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v1 -> v2: - Add support for -o glance. - Add support for -o qemu. - Fix the -o libvirt support for balloon as pointed out by Dan. - Fix a test failure caused by changing libvirt XML output. Rich.

Essentially identical to v1 except that it now uses (overloads?) the --mac option to supply this data. Rich.

v1: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v2: https://www.redhat.com/archives/libguestfs/2017-April/msg00040.html v2 -> v3: - Fix Xen PV-only kernel detection. Rich.

v1: https://www.redhat.com/archives/libguestfs/2017-April/msg00031.html v2: https://www.redhat.com/archives/libguestfs/2017-April/msg00040.html v3: https://www.redhat.com/archives/libguestfs/2017-April/msg00051.html v3 -> v4: - Properly fix Xen PV-only kernel detection, and test it. Rich.