search for: willemdebruijn

..._sys_write+0x14/0x20 > > do_fast_syscall_32+0x86/0xe0 > > entry_SYSENTER_compat+0x7c/0x8e > > > > A similar crash will likely trigger when enabling XDP. > > > > Reported-by: Alistair Delva <adelva at google.com> > > Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > > > Lightly tested. > > > > Alistair, could you please...

..._sys_write+0x14/0x20 > > do_fast_syscall_32+0x86/0xe0 > > entry_SYSENTER_compat+0x7c/0x8e > > > > A similar crash will likely trigger when enabling XDP. > > > > Reported-by: Alistair Delva <adelva at google.com> > > Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > > > Lightly tested. > > > > Alistair, could you please...

...F_HASH_REPORT feature is enabled, hdr_len = 20 But the sizeof(*hdr) is 12, memcpy(hdr, hdr_p, hdr_len); will copy 20 bytes to the hdr, which make a potential risk of bug. And this risk can be avoided by introducing struct skb_vnet_common_hdr. Change log v1->v2 feedback from Willem de Bruijn <willemdebruijn.kernel at gmail.com> feedback from Simon Horman <horms at kernel.org> 1. change to use net-next tree. 2. move skb_vnet_common_hdr inside kernel file instead of the UAPI header. v2->v3 feedback from Willem de Bruijn <willemdebruijn.kernel at gmail.com> 1. fix typo in commit messag...

On Mon, Dec 23, 2019 at 12:21:56PM -0800, Alistair Delva wrote: > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > <willemdebruijn.kernel at gmail.com> wrote: > > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > <willemdebruijn.kernel at gmail.com> wrote: > > > > > > 00fffe0ff0 DR7: 0000000000000400 > > > > > Call Trace: > > > > > ? preempt_cou...

On 2019/12/24 ??4:21, Alistair Delva wrote: > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > <willemdebruijn.kernel at gmail.com> wrote: >> On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn >> <willemdebruijn.kernel at gmail.com> wrote: >>> 00fffe0ff0 DR7: 0000000000000400 >>>>> Call Trace: >>>>> ? preempt_count_add+0x58/0xb0 >>>>&gt...

On Mon, Dec 23, 2019 at 3:22 PM Alistair Delva <adelva at google.com> wrote: > > On Mon, Dec 23, 2019 at 12:12 PM Willem de Bruijn > <willemdebruijn.kernel at gmail.com> wrote: > > > > On Mon, Dec 23, 2019 at 2:56 PM Willem de Bruijn > > <willemdebruijn.kernel at gmail.com> wrote: > > > > > > 00fffe0ff0 DR7: 0000000000000400 > > > > > Call Trace: > > > > > ? preempt_cou...

...ave to support it. Simply clear VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Note that Linux is still crashing if it tries to change the offloads when there's no control vq. That needs to be fixed by another patch. Reported-by: Alistair Delva <adelva at google.com> Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Same patch as v1 but update documentation so it's clear it's not enough to fix the crash. drivers/net...

...ave to support it. Simply clear VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. Note that Linux is still crashing if it tries to change the offloads when there's no control vq. That needs to be fixed by another patch. Reported-by: Alistair Delva <adelva at google.com> Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- Same patch as v1 but update documentation so it's clear it's not enough to fix the crash. drivers/net...

...OADS. > > Note that Linux is still crashing if it tries to > > change the offloads when there's no control vq. > > That needs to be fixed by another patch. > > > > Reported-by: Alistair Delva <adelva at google.com> > > Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > > > Same patch as v1 but update documentation so it's clear i...

...OADS. > > Note that Linux is still crashing if it tries to > > change the offloads when there's no control vq. > > That needs to be fixed by another patch. > > > > Reported-by: Alistair Delva <adelva at google.com> > > Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > --- > > > > Same patch as v1 but update documentation so it's clear i...

On Tue, Sep 29, 2020 at 3:32 PM Willem de Bruijn <willemdebruijn.kernel at gmail.com> wrote: > > On Tue, Sep 29, 2020 at 4:00 AM <xiangxia.m.yue at gmail.com> wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > Open vSwitch and Linux bridge will disable LRO of the interface > > when this int...

Jiri Pirko wrote: > Tue, Feb 21, 2023 at 05:12:33PM CET, willemdebruijn.kernel at gmail.com wrote: > >Jiri Pirko wrote: > >> Tue, Feb 21, 2023 at 04:11:53PM CET, willemdebruijn.kernel at gmail.com wrote: > >> >Jiri Pirko wrote: > >> >> From: Jiri Pirko <jiri at nvidia.com> > >> >> > >> >> Vi...

...y (0.9) and v1.0+. > > Since legacy virtio will no longer be modified, I don't think there is > much value is exposing this new union as UAPI. I do appreciate the > benefit to the implementation. > > [1] https://patches.linaro.org/project/netdev/patch/20210208185558.995292-3-willemdebruijn.kernel at gmail.com/ Hi, William and Simon Thanks for the detailed explanation. I kept virtio_net_hdr_mrg_rxbuf and virtio_net_hdr_v1_hash structures in virtio_net.h, which can be forward compatible with existing user applications which use these structures. After checking kernel code, the vir...

...if it tries to > > > > change the offloads when there's no control vq. > > > > That needs to be fixed by another patch. > > > > > > > > Reported-by: Alistair Delva <adelva at google.com> > > > > Reported-by: Willem de Bruijn <willemdebruijn.kernel at gmail.com> > > > > Fixes: 3f93522ffab2 ("virtio-net: switch off offloads on demand if possible on XDP set") > > > > Signed-off-by: Michael S. Tsirkin <mst at redhat.com> > > > > --- > > > > > > > > Same patch...

...H_REPORT feature is enabled, hdr_len = 20 But the sizeof(*hdr) is 12, memcpy(hdr, hdr_p, hdr_len); will copy 20 bytes to the hdr, which make a potential risk of bug. And this risk can be avoided by introducing struct virtio_net_hdr_mrg_rxbuf. Change log v1->v2 feedback from Willem de Bruijn <willemdebruijn.kernel at gmail.com> feedback from Simon Horman <horms at kernel.org> 1. change to use net-next tree. 2. move skb_vnet_common_hdr inside kernel file instead of the UAPI header. Signed-off-by: Feng Liu <feliu at nvidia.com> Reviewed-by: Jiri Pirko <jiri at nvidia.com> --- driv...

...at nothing was using sizeof(*hdr). Which would not be > > visible from the truncated patch contents itself. > > > Have checked. Nothing is using sizeof(*hdr). Thanks. > > >> > >> Change log > >> v1->v2 > >> feedback from Willem de Bruijn <willemdebruijn.kernel at gmail.com> > >> feedback from Simon Horman <horms at kernel.org> > >> 1. change to use net-next tree. > >> 2. move skb_vnet_common_hdr inside kernel file instead of the UAPI header. > >> > >> Signed-off-by: Feng Liu <feliu at nvidia...

...e the endianness between legacy (0.9) and v1.0+. Since legacy virtio will no longer be modified, I don't think there is much value is exposing this new union as UAPI. I do appreciate the benefit to the implementation. [1] https://patches.linaro.org/project/netdev/patch/20210208185558.995292-3-willemdebruijn.kernel at gmail.com/

...e the endianness between legacy (0.9) and v1.0+. Since legacy virtio will no longer be modified, I don't think there is much value is exposing this new union as UAPI. I do appreciate the benefit to the implementation. [1] https://patches.linaro.org/project/netdev/patch/20210208185558.995292-3-willemdebruijn.kernel at gmail.com/

>> - if (!use_napi) >> + if (use_napi) { >> + if (kick) >> + virtqueue_enable_cb_delayed(sq->vq); >> + else >> + virtqueue_disable_cb(sq->vq); > > > Since virtqueue_disable_cb() do nothing for event idx. I wonder whether or > not just calling enable_cb_dealyed()

On 2017?08?30? 11:11, Willem de Bruijn wrote: > On Tue, Aug 29, 2017 at 9:45 PM, Jason Wang <jasowang at redhat.com> wrote: >> >> On 2017?08?30? 03:35, Willem de Bruijn wrote: >>> On Fri, Aug 25, 2017 at 9:03 PM, Willem de Bruijn >>> <willemdebruijn.kernel at gmail.com> wrote: >>>> On Fri, Aug 25, 2017 at 7:32 PM, Michael S. Tsirkin <mst at redhat.com> >>>> wrote: >>>>> On Fri, Aug 25, 2017 at 06:44:36PM -0400, Willem de Bruijn wrote: [...] >>> Incomplete results at this stage, but I d...