Displaying 3 results from an estimated 3 matches for "widelinks_openat".
2024 Jun 10
2
4.20: case (in)sensitive is broken
...ug please and I'll add a regression test
for this ?
Thanks,
Jeremy.
diff --git a/source3/modules/vfs_widelinks.c b/source3/modules/vfs_widelinks.c
index c5b5084e108..f3c9f0e359c 100644
--- a/source3/modules/vfs_widelinks.c
+++ b/source3/modules/vfs_widelinks.c
@@ -383,8 +383,14 @@ static int widelinks_openat(vfs_handle_struct *handle,
}
lstat_ret = SMB_VFS_NEXT_LSTAT(handle,
full_fname);
- if (lstat_ret != -1 &&
- VALID_STAT(full_fname->st) &&
+ if (lstat_ret == -1) {
+ /* Can't be a DFS link. */
+ int saved_errno = errno;
+ TALLOC_FREE(full_fname);
+...
2024 Jun 11
1
4.20: case (in)sensitive is broken
...erly today.
But it looks like you were faster :)
> diff --git a/source3/modules/vfs_widelinks.c b/source3/modules/vfs_widelinks.c
> index c5b5084e108..f3c9f0e359c 100644
> --- a/source3/modules/vfs_widelinks.c
> +++ b/source3/modules/vfs_widelinks.c
> @@ -383,8 +383,14 @@ static int widelinks_openat(vfs_handle_struct *handle,
> ???????? }
> ???????? lstat_ret = SMB_VFS_NEXT_LSTAT(handle,
> ???????????????? full_fname);
> -??????? if (lstat_ret != -1 &&
> -??????????? VALID_STAT(full_fname->st) &&
> +??????? if (lstat_ret == -1) {
> +??????????? /* Can...
2024 Jun 07
1
4.20: case (in)sensitive is broken
07.06.2024 20:52, Jeremy Allison wrote:
> Fair enough. Can you post a minimal smb.conf and directory
> setup that reproduces the problem and how to demo it with smbclient
> command lines please ? I know I'm asking to be spoon-fed but my time for
> Samba these days is quite limited and this would aid immensely
> in creating a properly tested fix.
You're not asking to be