search for: wflag

There's an obvious bug in this patch in that it doesn't reset the h->wflags field in all cases. Updated patch below. I rechecked the performance measurements and they are the same after the updated patch. Rich. >From 15a687b50acecebcfd3dc6222d93e6df984b83c6 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" <rjones@redhat.com> Date: Sat, 8 Jun 2019...

...f..cce43d7 100644 --- a/generator/states-issue-command.c +++ b/generator/states-issue-command.c @@ -42,6 +42,8 @@ h->request.count = htobe32 ((uint32_t) cmd->count); h->wbuf = &h->request; h->wlen = sizeof (h->request); + if (cmd->type == NBD_CMD_WRITE) + h->wflags = MSG_MORE; SET_NEXT_STATE (%SEND_REQUEST); return 0; diff --git a/generator/states-newstyle-opt-export-name.c b/generator/states-newstyle-opt-export-name.c index 774c93c..968cea8 100644 --- a/generator/states-newstyle-opt-export-name.c +++ b/generator/states-newstyle-opt-export-name.c @@...

Appears to have a measurable benefit, see 3/3 for test results. Rich.

...@@ -92,7 +92,7 @@ send_from_wbuf (struct nbd_handle *h) if (h->wlen == 0) return 0; /* move to next state */ - r = h->sock->ops->send (h, h->sock, h->wbuf, h->wlen, 0); + r = h->sock->ops->send (h, h->sock, h->wbuf, h->wlen, h->wflags); if (r == -1) { if (errno == EAGAIN || errno == EWOULDBLOCK) return 1; /* more data */ @@ -101,8 +101,10 @@ send_from_wbuf (struct nbd_handle *h) } h->wbuf += r; h->wlen -= r; - if (h->wlen == 0) + if (h->wlen == 0) { + h->wflags = 0;...

I'm not sure if this is worth pursuing. On paper, it makes sense (if we know we have multiple commands batched to send over the wire, AND those commands are short in length, we might as well use MSG_MORE), but the measurement numbers with it applied might just be in the noise. Eric Blake (2): examples: Enhance access patterns of threaded-reads-and-writes states: Another use for MSG_MORE

...mapping=WMCHAR_MAP_DISPATCHMESSAGE) [/build/buildd/wine1.3-1.3.8/dlls/user32/winproc.c:901] in user32 (0x0032e1dc) 18 0x6810b68e DispatchMessageW+0x9d(msg=0x32e32c) [/build/buildd/wine1.3-1.3.8/dlls/user32/message.c:3710] in user32 (0x0032e37c) 19 0x681067bb MENU_TrackMenu+0x40a(hmenu=0x40080, wFlags=0x20000002, x=0, y=0, hwnd=0x10094, lprect=(nil)) [/build/buildd/wine1.3-1.3.8/dlls/user32/menu.c:3228] in user32 (0x0032e3cc) 20 0x681075d8 TrackPopupMenuEx+0x177(hMenu=0x40080, wFlags=0x0002, x=0x01cc, y=0x011c, hWnd=0x10094, lpTpm=(nil)) [/build/buildd/wine1.3-1.3.8/dlls/user32/menu.c:3443] i...

....c +++ b/generator/states-issue-command.c @@ -42,7 +42,7 @@ h->request.count = htobe32 ((uint32_t) cmd->count); h->wbuf = &h->request; h->wlen = sizeof (h->request); - if (cmd->type == NBD_CMD_WRITE) + if (cmd->type == NBD_CMD_WRITE || cmd->next) h->wflags = MSG_MORE; SET_NEXT_STATE (%SEND_REQUEST); return 0; @@ -70,6 +70,8 @@ if (cmd->type == NBD_CMD_WRITE) { h->wbuf = cmd->data; h->wlen = cmd->count; + if (cmd->next && cmd->count < 64 * 1024) + h->wflags = MSG_MORE; SET_NEXT_STATE...

...g the following error messages when trying to run our company software with Wine, can anybody help me and tell me what I have to do to get rid of these errors?! Am I missing any important dll files or what can the problem be? Thanks. fixme:ole:CoRegisterMessageFilter stub fixme:msvideo:DrawDibDraw wFlags == 0x00000200 not handled fixme:msvcrt:_XcptFilter (-529697949,0x40835230)semi-stub --- Eddie Zikeli Software Development Hans G?ntner GmbH Industriestr. 14 D-82256 F?rstenfeldbruck Tel.: +49(0)8141-242-240 Fax.: +49(0)8141-242-5-240 mailto:e.zikeli@guentner.de http://www.guentner.de/

...le("c:/data.txt", header=TRUE)') File "<COMObject StatConnectorSrv.StatConnector>", line 2, in Evaluate File "C:\PYTHON22\lib\site-packages\win32com\client\dynamic.py", line 237, in _ApplyTypes_ result = apply(self._oleobj_.InvokeTypes, (dispid, LCID, wFlags, retType, argTypes) + args) com_error: (-2147352567, 'Une exception est apparue.', (0, None, None, None, 0, -2147221500), None) ++++ nota bene : : " Une exception est apparue." means " an exception occured" >>>

...ra/half-l~1/sierra.inf". Check permissions or set VFAT "quiet" flag ! but I didn't succeed to mount my hda1 so that users can write on it too I although got 2 times : err:int21:INT21_SetCurrentPSP Cannot change PSP for non-DOS task! and a thousands of : fixme:msvideo:DrawDibDraw wFlags == 0x00000c0c not handledf and fixme:text:DrawTextExA Ignores params:20,4,0,0 Can anyone gimme some tips please ? BYe, MoonChild

...fixme:advapi:LsaOpenPolicy (L"",0x100e0c8,0x00000810,0x100e124) stub fixme:advapi:LookupAccountNameW L"" L"oms" 0xe6e4d0 0x100e0d8 0xdb0728 0x100e0e4 0x100e0d4 - stub fixme:advapi:LsaClose (0xcafe) stub fixme:msi:AutomationObject_Invoke Method 2, L"Property" wflags 1 not implemented, clsid {000c109e-0000-0000-c000-000000000046} fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates -> 3 ignored L"Upgrade" table values fixme:msi:msi_unimplemented_action_stub RemoveExistingProducts -> 3 ignored L"Upgrade" table values fixme:msi:...

nbdkit 1.2 as a server waits for read() to see EOF, even after the client has sent NBD_CMD_DISC. That was fixed in mbdkit 1.4; and most modern NBD servers are smarter than this (they close() the write end of their traffic soon after NBD_CMD_DISC). But it's easy enough to revert nbdkit commit c70616f8 to get back to a server with the same behavior as the older nbdkit, at which point both

Necessary when writing a client that wants to avoid unnecessary EINVAL errors from sending unaligned requests. At some point, we may want to add synchronous convenience API wrappers that do request splitting or read-modify-write to obey server constraints while still appearing to the library client as accepting any possible request. But such a wrapper should only be synchronous and not copied to

...0.5.1-LDLIBS.patch b/tools/vtpm/vtpm-0.5.1-LDLIBS.patch --- a/tools/vtpm/vtpm-0.5.1-LDLIBS.patch +++ /dev/null @@ -1,12 +0,0 @@ -diff -Naurp tpm_emulator-0.5.1/tpmd/Makefile tpm_emulator-0.5.1/tpmd/Makefile ---- tpm_emulator-0.5.1/tpmd/Makefile -+++ tpm_emulator-0.5.1/tpmd/Makefile -@@ -8,7 +8,7 @@ WFLAGS := -Wall -Wno-unused -Wpointer-a - #WFLAGS += -Wextra -Wcast-qual -Wmissing-prototypes -Wmissing-declarations -Wstrict-aliasing - CFLAGS += $(WFLAGS) -g -I.. -I. -O2 -fno-strict-aliasing - CFLAGS += -I../../../../tools/vtpm_manager/manager --LDFLAGS += -lgmp -+LDLIBS += -lgmp - - B...

...GetSecurityInfo default action not implemented fixme:mshtml:nsChannel_GetSecurityInfo default action not implemented fixme:mshtml:nsChannel_GetSecurityInfo default action not implemented fixme:mshtml:DispatchEx_GetNameSpaceParent (0x5fa3278)->(0x32c7d8) fixme:mshtml:DispatchEx_InvokeEx unhandled wFlags c fixme:seh:_abnormal_termination (void)stub fixme:mshtml:ActiveScriptSite_OnScriptError (0x69ef538)->(0x6942c80) fixme:seh:_abnormal_termination (void)stub fixme:mshtml:ActiveScriptSite_OnScriptError (0x69ef538)->(0x6942c80) fixme:seh:_abnormal_termination (void)stub fixme:mshtml:ActiveScri...

This adds coalescing of adjacent extents of the same type, as mentioned by Eric Blake in the commit message here: https://github.com/libguestfs/libnbd/commit/46072f6611f80245846a445766da071e457b00cd The patch series is rather long because it detours through adding the <vector.h> library from nbdkit into libnbd and replacing ad hoc uses of realloc, char ** etc in various places. Rich.

Well, I'm not quite done (I still want to get nbdinfo to work on a single nbd connection for all cases when reading the heads of the file is not required), but I'm happy with patches 1-11, and 12-13 show where I'm headed for getting NBD_OPT_INFO to work. Posting now to see if some of the earlier patches are ready to commit while I continue working on the latter half. Eric Blake (13):