search for: wenlei

Also see my replies inline. From: Hongtao Yu <hoy at fb.com> Date: Saturday, August 8, 2020 at 11:25 AM To: Xinliang David Li <davidxl at google.com> Cc: Wenlei He <wenlei at fb.com>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Wei Mi <wmi at google.com> Subject: Re: [RFC] Context-sensitive Sample PGO with Pseudo-Instrumentation Replied inline. From: Xinliang David Li <davidxl at google.com> Date: Saturday...

...gh massive machine-independent/machine-dependent transforms. Besides probing basic blocks, a probe can be used to probe each value site of interest. So far only direct/indirect call sites are supported. From: Rahman Lavaee <rahmanl at google.com> Date: Saturday, August 8, 2020 at 9:44 AM To: Wenlei He <wenlei at fb.com> Cc: Hongtao Yu <hoy at fb.com>, Wei Mi <wmi at google.com>, Xinliang David Li <davidxl at google.com>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] Context-sensitive Sample PGO with Pseudo-Instr...

...ne number | Discriminator (ULEB128) // FUNCTION BODY // A FUNCTION BODY entry describing the inlined function. From: Rahman Lavaee <rahmanl at google.com> Date: Saturday, August 8, 2020 at 1:09 PM To: Hongtao Yu <hoy at fb.com> Cc: Wei Mi <wmi at google.com>, Wenlei He <wenlei at fb.com>, Xinliang David Li <davidxl at google.com>, "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] Context-sensitive Sample PGO with Pseudo-Instrumentation Thanks for the kind words. For the basic block mapping, wou...

See my answers inline. From: Xinliang David Li <davidxl at google.com> Date: Friday, August 7, 2020 at 7:57 PM To: Wenlei He <wenlei at fb.com> Cc: "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Wei Mi <wmi at google.com>, Hongtao Yu <hoy at fb.com> Subject: Re: [RFC] Context-sensitive Sample PGO with Pseudo-Instrumentation On Fri, Aug 7, 2020 at 4:44 PM Wenlei He <w...

On Fri, Aug 7, 2020 at 11:28 PM Hongtao Yu <hoy at fb.com> wrote: > A few add-ons. > > > > *From: *Wenlei He <wenlei at fb.com> > *Date: *Friday, August 7, 2020 at 10:34 PM > *To: *Xinliang David Li <davidxl at google.com> > *Cc: *"llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Wei Mi < > wmi at google.com>, Hongtao Yu <hoy at fb.com> >...

Thanks for the thoughtful questions, David. See my answers inline. Thanks, Wenlei From: Xinliang David Li <davidxl at google.com> Date: Friday, August 7, 2020 at 1:24 PM To: Wenlei He <wenlei at fb.com> Cc: "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, Wei Mi <wmi at google.com>, Hongtao Yu <hoy at fb.com> Subject: Re: [RFC]...

...mark suite is different from large workloads, we think the results demonstrated the potential of CSSPGO and served its purpose for proof of concept. We plan to continue tuning and start to evaluate larger internal workloads soon, and we’d like to upstream our work. Feedbacks are welcomed! Thanks, Wenlei & Hongtao -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200807/580b8ac3/attachment-0001.html>

On Wed, Sep 9, 2020 at 9:23 PM Wenlei He via llvm-dev < llvm-dev at lists.llvm.org> wrote: > I think calling PGSO size opt is probably a bit misleading though. It’s > more of an adaptive opt strategy, and it can improve performance too due to > better locality. We have something similar internally for selecting opt >...

> -----Original Message----- > From: Fāng-ruì Sòng <maskray at google.com> > Sent: Tuesday, November 17, 2020 1:51 AM > To: Alexander Yermolovich <ayermolo at fb.com> > Cc: David Blaikie <dblaikie at gmail.com>; Wenlei He <wenlei at fb.com>; llvm- > dev at lists.llvm.org; Robinson, Paul <paul.robinson at sony.com>; James > Henderson <jh7370.2008 at my.bristol.ac.uk>; Eric Christopher > <echristo at gmail.com>; Igor Kudrin <ikudrin at accesssoftek.com> > Subject: Re: [llvm...

FYI David is referring to PGSO (profile-guided size optimization) as it exists directly under that name, see: https://reviews.llvm.org/D67120. And yeah using PGSO is selecting optsize while this change is selecting optnone. On 9/9/20, 10:58 AM, "llvm-dev on behalf of Tobias Hieta via llvm-dev" <llvm-dev-bounces at lists.llvm.org<mailto:llvm-dev-bounces at lists.llvm.org> on

On Sat, Jul 4, 2020 at 11:28 PM Wenlei He <wenlei at fb.com> wrote: > This sounds very useful. We’ve improved and used memoro > <https://www.youtube.com/watch?v=fm47XsATelI> for memory profiling and > analysis, and we are also looking for ways to leverage memory profile for > PGO/FDO. I think having a common pro...

....debug_str output section. It doesn't really specify the ordering within the output .debug_str section. Thank You Alex ________________________________ From: Fāng-ruì Sòng <maskray at google.com> Sent: Friday, November 13, 2020 12:42 PM To: David Blaikie <dblaikie at gmail.com> Cc: Wenlei He <wenlei at fb.com>; Alexander Yermolovich <ayermolo at fb.com>; llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>; Robinson, Paul <paul.robinson at sony.com>; James Henderson <jh7370.2008 at my.bristol.ac.uk>; Eric Christopher <echristo at gmail.com>; Ig...

...DWARF spec that says if DWARF32 and DWARF64 the onus is on the user. Alex ________________________________ From: Fāng-ruì Sòng <maskray at google.com> Sent: Tuesday, November 17, 2020 4:49 PM To: Igor Kudrin <ikudrin at accesssoftek.com> Cc: David Blaikie <dblaikie at gmail.com>; Wenlei He <wenlei at fb.com>; Alexander Yermolovich <ayermolo at fb.com>; llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>; Robinson, Paul <paul.robinson at sony.com>; James Henderson <jh7370.2008 at my.bristol.ac.uk>; Eric Christopher <echristo at gmail.com> Sub...

On 2020-11-14, Alexander Yermolovich wrote: >Thanks for doing a diff and asking in other groups. > >So if I understand your concern with using first reloc as it relates to .debug_str. > >In DWARF4 for .debug_str is referenced from .debug_info, .debug_type using DW_FORM_strp. For DWARF32 it's 32bit unsigned, for DWARF64 it's 64bit unsigned. So in relocation section for some

On 2020-11-17, Igor Kudrin wrote: > >On 17.11.2020 14:05, Fāng-ruì Sòng wrote: >>On Mon, Nov 16, 2020 at 10:42 PM Igor Kudrin <ikudrin at accesssoftek.com> wrote: >>> >>>On 14.11.2020 3:42, Fāng-ruì Sòng wrote: >>>>For .debug_* in object files: >>>> >>>>DWARF32 -> SHT_PROGBITS (unchanged) >>>>DWARF64 ->

...name. > > > > * It needs a linker script feature to match input sections by type. > > > > > > > > On Fri, Nov 13, 2020 at 9:52 AM David Blaikie <dblaikie at gmail.com> wrote: > > > > > > > > > > On Fri, Nov 13, 2020 at 8:35 AM Wenlei He via llvm-dev > > > > > <llvm-dev at lists.llvm.org> wrote: > > > > > > > > > > > > > Thinking about it, I wouldn't expect an LTO generated object itself to have a mixture of DWARF32/64, although I guess the 32/64 bit state could be...

Hi all, Here I include an RFC for control flow sensitive AutoFDO (FS-AFDO). This is a joint work with David Li. Questions and feedback are welcome. Thanks, Rong ============= [RFC] Control Flow Sensitive AutoFDO (FS-AFDO) 1. Motivation AFDO profile is derived from PMU samples from running an earlier build binary. PMU samples are indexed by the IP addresses. An offline tool uses the debug

...our implementation * It needs a clarification on multiple output section descriptions with the same name. * It needs a linker script feature to match input sections by type. On Fri, Nov 13, 2020 at 9:52 AM David Blaikie <dblaikie at gmail.com> wrote: > > On Fri, Nov 13, 2020 at 8:35 AM Wenlei He via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > > > > Thinking about it, I wouldn't expect an LTO generated object itself to have a mixture of DWARF32/64, although I guess the 32/64 bit state could be encoded in the IR (I am not familiar enough with it to know...

> Thinking about it, I wouldn't expect an LTO generated object itself to have a mixture of DWARF32/64, although I guess the 32/64 bit state could be encoded in the IR (I am not familiar enough with it to know if it actually is or not). It might be necessary to find ways to configure LTO to generate DWARF64, possibly via a link-time option. I don’t think we need to encode dwarf32/64 in IR

...utput section descriptions > > with the same name. > > * It needs a linker script feature to match input sections by type. > > > > On Fri, Nov 13, 2020 at 9:52 AM David Blaikie <dblaikie at gmail.com> wrote: > > > > > > On Fri, Nov 13, 2020 at 8:35 AM Wenlei He via llvm-dev > > > <llvm-dev at lists.llvm.org> wrote: > > > > > > > > > Thinking about it, I wouldn't expect an LTO generated object itself to have a mixture of DWARF32/64, although I guess the 32/64 bit state could be encoded in the IR (I am not f...